Page MenuHomePhabricator
Differential D14135

[native] Move render function in MultimediaMessageMultimedia to functional component
ClosedPublic
Actions

Authored by angelika on Wed, Dec 11, 12:38 PM.
Tags
None
Referenced Files
F3506891: D14135.id46354.diff
Fri, Dec 20, 6:31 PM
F3506473: D14135.id46492.diff
Fri, Dec 20, 4:51 PM
F3505869: D14135.id46528.diff
Fri, Dec 20, 2:53 PM
F3505101: D14135.id46354.diff
Fri, Dec 20, 12:13 PM
F3505089: D14135.id46493.diff
Fri, Dec 20, 12:08 PM
F3505081: D14135.id46494.diff
Fri, Dec 20, 12:06 PM
F3504986: D14135.id46429.diff
Fri, Dec 20, 11:49 AM
F3504853: D14135.id46429.diff
Fri, Dec 20, 10:49 AM
View All 16 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMf8b744c38505: [native] Move render function in MultimediaMessageMultimedia to functional…
Summary

Move render() function to functional component as a part of MultimediaMessageMultimedia migration to a functional component. This finishes the migration of the MultimediaMessageMultimedia component to a functional component.

Depends on D14134

Test Plan

Open up a multimedia message and see if it behaves correctly.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Wed, Dec 11, 12:38 PM
angelika held this revision as a draft.
angelika edited the summary of this revision. (Show Details)Wed, Dec 11, 12:38 PM
angelika added a parent revision: D14134: [native] Move componentDidUpdate logic in MultimediaMessageMultimedia to functional component.
Harbormaster completed remote builds in B33036: Diff 46354.Wed, Dec 11, 1:22 PM
angelika published this revision for review.Wed, Dec 11, 5:30 PM
ashoat accepted this revision.Wed, Dec 11, 8:11 PM
ashoat added inline comments.
native/chat/multimedia-message-multimedia.react.js
28 ↗(On Diff #46354)

This can be renamed

53 ↗(On Diff #46354)

This can be renamed

156 ↗(On Diff #46354)

Can you wrap this with a React.useMemo?

This revision is now accepted and ready to land.Wed, Dec 11, 8:11 PM
angelika updated this revision to Diff 46429.Fri, Dec 13, 5:43 AM

Rebase and address feedback

angelika marked 3 inline comments as done.Fri, Dec 13, 6:29 AM
Harbormaster completed remote builds in B33107: Diff 46429.Fri, Dec 13, 9:54 AM
angelika updated this revision to Diff 46492.Mon, Dec 16, 6:25 AM

Rebase

angelika updated this revision to Diff 46493.Mon, Dec 16, 6:26 AM

Rebase

Harbormaster completed remote builds in B33151: Diff 46492.Mon, Dec 16, 10:52 AM
Harbormaster completed remote builds in B33152: Diff 46493.Mon, Dec 16, 11:00 AM
Closed by commit rCOMMf8b744c38505: [native] Move render function in MultimediaMessageMultimedia to functional… (authored by angelika). · Explain WhyMon, Dec 16, 1:35 PM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMMf8b744c38505: [native] Move render function in MultimediaMessageMultimedia to functional….

Revision Contents
Changeset List

PathSize
native/
chat/
105 lines

Diff 46429

View Options

native/chat/multimedia-message-multimedia.react.js

Loading...