Page MenuHomePhabricator

[lib] Fix stack overflow from lastUpdatedTime
ClosedPublic

Authored by ashoat on Dec 13 2024, 9:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 22, 4:52 AM
Unknown Object (File)
Tue, Apr 22, 3:51 AM
Unknown Object (File)
Tue, Apr 22, 2:34 AM
Unknown Object (File)
Sun, Apr 20, 11:10 PM
Unknown Object (File)
Sun, Apr 6, 9:08 AM
Unknown Object (File)
Mar 20 2025, 5:24 PM
Unknown Object (File)
Mar 11 2025, 4:12 PM
Unknown Object (File)
Mar 11 2025, 4:11 PM
Subscribers
None

Details

Summary

This resolves ENG-10016. It looks like when this was changed from an immediately-invoked Promise to a function that returns a Promise, we ended up in a situation where the lastUpdatedTime dereference ended up resolving to the new value rather than the prior value.

Test Plan

Prior to this change, I was able to reproduce the issue in the Linear task. Afterwards, it no longer reproduces

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/fixfix
Lint
No Lint Coverage
Unit
No Test Coverage