[native] Move haptics in Tooltip to functional compononent
ClosedPublic
Actions

Authored by angelika on Wed, Dec 11, 7:47 AM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM66f08779a84d: [native] Move haptics in Tooltip to functional compononent

Summary

Move Haptics.impactAsync() call to functional component as a part of Tooltip migration to functional component.

Depends on D14109

Test Plan

Open up a tooltip and verify the phone vibrates.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Wed, Dec 11, 7:47 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptWed, Dec 11, 7:47 AM

angelika edited the test plan for this revision. (Show Details)Wed, Dec 11, 7:48 AM

angelika added reviewers: ashoat, tomek.

angelika added a child revision: D14111: [native] Move methods from Tooltip to functional compononent.Wed, Dec 11, 7:54 AM

Harbormaster completed remote builds in B33010: Diff 46328.Wed, Dec 11, 9:10 AM

angelika published this revision for review.Wed, Dec 11, 4:55 PM

ashoat accepted this revision.Wed, Dec 11, 5:53 PM

This revision is now accepted and ready to land.Wed, Dec 11, 5:53 PM

Rebase and address feedback

Harbormaster completed remote builds in B33085: Diff 46407.Fri, Dec 13, 6:50 AM

Rebase

Harbormaster completed remote builds in B33129: Diff 46470.Mon, Dec 16, 7:44 AM

Closed by commit rCOMM66f08779a84d: [native] Move haptics in Tooltip to functional compononent (authored by angelika). · Explain WhyMon, Dec 16, 1:34 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM66f08779a84d: [native] Move haptics in Tooltip to functional compononent.

Revision Contents
Changeset List

Path

Size

native/

tooltip/

tooltip.react.js

8 lines

Diff 46506

View Options

native/tooltip/tooltip.react.js

[native] Move haptics in Tooltip to functional compononentClosedPublicActions