[native] rename `<Registration` components to `<Auth` components
ClosedPublic
Actions

Authored by kamil on Dec 18 2024, 5:20 AM.

Details

Reviewers

bartek
tomek

Commits

rCOMM39d7f06a7465: [native] rename `<Registration*` components to `<Auth*` components

Summary

This is a follow-up to what I suggested in D14114 - to avoid confusion renaming to something more generic as now those components are also used outside of registration flow.

This diff is only rename, I am going to move them to a different directory in next diff to make review easy.

Depends on D14169

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Branch

fixes

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Dec 18 2024, 5:20 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptDec 18 2024, 5:20 AM

Harbormaster completed remote builds in B33173: Diff 46567.Dec 18 2024, 5:37 AM

kamil retitled this revision from [native] rename `<Registration*` components to ``<Auth*` components to [native] rename `<Registration*` components to `<Auth*` components.Dec 18 2024, 5:55 AM

kamil added a child revision: D14171: [native] move `<Auth*` components to a `/auth-components` directory.Dec 18 2024, 5:57 AM

kamil published this revision for review.Dec 19 2024, 2:40 AM

bartek accepted this revision.Dec 19 2024, 5:19 AM

This revision is now accepted and ready to land.Dec 19 2024, 5:19 AM

rebase

Harbormaster completed remote builds in B33199: Diff 46607.Jan 8 2025, 2:19 AM

Closed by commit rCOMM39d7f06a7465: [native] rename `<Registration*` components to `<Auth*` components (authored by kamil). · Explain WhyJan 9 2025, 4:16 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM39d7f06a7465: [native] rename `<Registration*` components to `<Auth*` components.

Revision Contents
Changeset List

Path

Size

native/

account/

qr-auth/

connect-secondary-device.react.js

18 lines

qr-auth-not-primary-device.react.js

18 lines

secondary-device-connected.react.js

18 lines

secondary-device-not-responding.react.js

18 lines

qr-code-screen.react.js

18 lines

registration/

account-does-not-exist.react.js

18 lines

avatar-selection.react.js

18 lines

connect-ethereum.react.js

18 lines

connect-farcaster.react.js

18 lines

cool-or-nerd-mode-selection.react.js

18 lines

emoji-avatar-selection.react.js

12 lines

existing-ethereum-account.react.js

18 lines

keyserver-selection.react.js

18 lines

password-selection.react.js

18 lines

registration-button-container.react.js

4 lines

registration-container.react.js

4 lines

registration-content-container.react.js

4 lines

registration-terms.react.js

18 lines

siwe-backup-message-creation.react.js

32 lines

username-selection.react.js

18 lines

restore-backup-screen.react.js

12 lines

restore-password-account-screen.react.js

18 lines

restore-prompt-screen.react.js

18 lines

community-creation/

community-configuration.react.js

18 lines

Diff 46567

View Options

native/account/qr-auth/connect-secondary-device.react.js

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Lines
import {		import {
type RobotextMessageInfo,		type RobotextMessageInfo,
type ComposableMessageInfo,		type ComposableMessageInfo,
} from '../types/message-types.js';		} from '../types/message-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js';		import { userRelationshipStatus } from '../types/relationship-types.js';
import {		import {
threadPermissionPropagationPrefixes,		threadPermissionPropagationPrefixes,
threadPermissions,		threadPermissions,
		configurableCommunityPermissions,
type ThreadPermission,		type ThreadPermission,
type ThreadPermissionsInfo,		type ThreadPermissionsInfo,
		type UserSurfacedPermission,
} from '../types/thread-permission-types.js';		} from '../types/thread-permission-types.js';
import {		import {
type ThreadType,		type ThreadType,
threadTypes,		threadTypes,
threadTypeIsCommunityRoot,		threadTypeIsCommunityRoot,
assertThreadType,		assertThreadType,
} from '../types/thread-types-enum.js';		} from '../types/thread-types-enum.js';
import {		import {
▲ Show 20 Lines • Show All 1,496 Lines • ▼ Show 20 Lines	Object.keys(roleIDsToNames).forEach(roleName => {
roleNamesToMemberCount[roleIDsToNames[roleName]] = 0;		roleNamesToMemberCount[roleIDsToNames[roleName]] = 0;
}		}
});		});

return roleNamesToMemberCount;		return roleNamesToMemberCount;
}, [threadInfo]);		}, [threadInfo]);
}		}

		type RoleUserSurfacedPermissions = {
		+[roleName: string]: $ReadOnlyArray<UserSurfacedPermission>,
		};
		// Iterates through the existing roles in the community and 'reverse maps'
		// the set of permission literals for each role to user-facing permission enums
		// to help pre-populate the permission checkboxes when editing roles.
		function useRoleUserSurfacedPermissions(
		threadInfo: ThreadInfo,
		): RoleUserSurfacedPermissions {
		return React.useMemo(() => {
		const roleNamesToPermissions = {};

		Object.keys(threadInfo.roles).forEach(roleID => {
		const roleName = threadInfo.roles[roleID].name;
		const rolePermissions = Object.keys(threadInfo.roles[roleID].permissions);
		const setOfUserSurfacedPermissions = new Set();

		rolePermissions.forEach(rolePermission => {
		const userSurfacedPermission = Object.keys(
		configurableCommunityPermissions,
		).find(key =>
		configurableCommunityPermissions[key].has(rolePermission),
		);

		if (userSurfacedPermission) {
		setOfUserSurfacedPermissions.add(userSurfacedPermission);
		}
		});
		roleNamesToPermissions[roleName] = [...setOfUserSurfacedPermissions];
		});

		return roleNamesToPermissions;
		}, [threadInfo]);
		}

export {		export {
threadHasPermission,		threadHasPermission,
viewerIsMember,		viewerIsMember,
threadInChatList,		threadInChatList,
threadIsTopLevel,		threadIsTopLevel,
threadIsChannel,		threadIsChannel,
threadIsSidebar,		threadIsSidebar,
threadInBackgroundChatList,		threadInBackgroundChatList,
▲ Show 20 Lines • Show All 50 Lines • ▼ Show 20 Lines	export {
switchMemberAdminRoleInThread,		switchMemberAdminRoleInThread,
getAvailableThreadMemberActions,		getAvailableThreadMemberActions,
threadMembersWithoutAddedAshoat,		threadMembersWithoutAddedAshoat,
validChatNameRegex,		validChatNameRegex,
chatNameMaxLength,		chatNameMaxLength,
patchThreadInfoToIncludeMentionedMembersOfParent,		patchThreadInfoToIncludeMentionedMembersOfParent,
threadInfoInsideCommunity,		threadInfoInsideCommunity,
useRoleMemberCountsForCommunity,		useRoleMemberCountsForCommunity,
		useRoleUserSurfacedPermissions,
};		};

View Options

native/account/qr-auth/qr-auth-not-primary-device.react.js

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Lines
import {		import {
type RobotextMessageInfo,		type RobotextMessageInfo,
type ComposableMessageInfo,		type ComposableMessageInfo,
} from '../types/message-types.js';		} from '../types/message-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js';		import { userRelationshipStatus } from '../types/relationship-types.js';
import {		import {
threadPermissionPropagationPrefixes,		threadPermissionPropagationPrefixes,
threadPermissions,		threadPermissions,
		configurableCommunityPermissions,
type ThreadPermission,		type ThreadPermission,
type ThreadPermissionsInfo,		type ThreadPermissionsInfo,
		type UserSurfacedPermission,
} from '../types/thread-permission-types.js';		} from '../types/thread-permission-types.js';
import {		import {
type ThreadType,		type ThreadType,
threadTypes,		threadTypes,
threadTypeIsCommunityRoot,		threadTypeIsCommunityRoot,
assertThreadType,		assertThreadType,
} from '../types/thread-types-enum.js';		} from '../types/thread-types-enum.js';
import {		import {
▲ Show 20 Lines • Show All 1,496 Lines • ▼ Show 20 Lines	Object.keys(roleIDsToNames).forEach(roleName => {
roleNamesToMemberCount[roleIDsToNames[roleName]] = 0;		roleNamesToMemberCount[roleIDsToNames[roleName]] = 0;
}		}
});		});

return roleNamesToMemberCount;		return roleNamesToMemberCount;
}, [threadInfo]);		}, [threadInfo]);
}		}

		type RoleUserSurfacedPermissions = {
		+[roleName: string]: $ReadOnlyArray<UserSurfacedPermission>,
		};
		// Iterates through the existing roles in the community and 'reverse maps'
		// the set of permission literals for each role to user-facing permission enums
		// to help pre-populate the permission checkboxes when editing roles.
		function useRoleUserSurfacedPermissions(
		threadInfo: ThreadInfo,
		): RoleUserSurfacedPermissions {
		return React.useMemo(() => {
		const roleNamesToPermissions = {};

		Object.keys(threadInfo.roles).forEach(roleID => {
		const roleName = threadInfo.roles[roleID].name;
		const rolePermissions = Object.keys(threadInfo.roles[roleID].permissions);
		const setOfUserSurfacedPermissions = new Set();

		rolePermissions.forEach(rolePermission => {
		const userSurfacedPermission = Object.keys(
		configurableCommunityPermissions,
		).find(key =>
		configurableCommunityPermissions[key].has(rolePermission),
		);

		if (userSurfacedPermission) {
		setOfUserSurfacedPermissions.add(userSurfacedPermission);
		}
		});
		roleNamesToPermissions[roleName] = [...setOfUserSurfacedPermissions];
		});

		return roleNamesToPermissions;
		}, [threadInfo]);
		}

export {		export {
threadHasPermission,		threadHasPermission,
viewerIsMember,		viewerIsMember,
threadInChatList,		threadInChatList,
threadIsTopLevel,		threadIsTopLevel,
threadIsChannel,		threadIsChannel,
threadIsSidebar,		threadIsSidebar,
threadInBackgroundChatList,		threadInBackgroundChatList,
▲ Show 20 Lines • Show All 50 Lines • ▼ Show 20 Lines	export {
switchMemberAdminRoleInThread,		switchMemberAdminRoleInThread,
getAvailableThreadMemberActions,		getAvailableThreadMemberActions,
threadMembersWithoutAddedAshoat,		threadMembersWithoutAddedAshoat,
validChatNameRegex,		validChatNameRegex,
chatNameMaxLength,		chatNameMaxLength,
patchThreadInfoToIncludeMentionedMembersOfParent,		patchThreadInfoToIncludeMentionedMembersOfParent,
threadInfoInsideCommunity,		threadInfoInsideCommunity,
useRoleMemberCountsForCommunity,		useRoleMemberCountsForCommunity,
		useRoleUserSurfacedPermissions,
};		};

View Options

native/account/qr-auth/secondary-device-connected.react.js

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Lines
import {		import {
type RobotextMessageInfo,		type RobotextMessageInfo,
type ComposableMessageInfo,		type ComposableMessageInfo,
} from '../types/message-types.js';		} from '../types/message-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js';		import { userRelationshipStatus } from '../types/relationship-types.js';
import {		import {
threadPermissionPropagationPrefixes,		threadPermissionPropagationPrefixes,
threadPermissions,		threadPermissions,
		configurableCommunityPermissions,
type ThreadPermission,		type ThreadPermission,
type ThreadPermissionsInfo,		type ThreadPermissionsInfo,
		type UserSurfacedPermission,
} from '../types/thread-permission-types.js';		} from '../types/thread-permission-types.js';
import {		import {
type ThreadType,		type ThreadType,
threadTypes,		threadTypes,
threadTypeIsCommunityRoot,		threadTypeIsCommunityRoot,
assertThreadType,		assertThreadType,
} from '../types/thread-types-enum.js';		} from '../types/thread-types-enum.js';
import {		import {
▲ Show 20 Lines • Show All 1,496 Lines • ▼ Show 20 Lines	Object.keys(roleIDsToNames).forEach(roleName => {
roleNamesToMemberCount[roleIDsToNames[roleName]] = 0;		roleNamesToMemberCount[roleIDsToNames[roleName]] = 0;
}		}
});		});

return roleNamesToMemberCount;		return roleNamesToMemberCount;
}, [threadInfo]);		}, [threadInfo]);
}		}

		type RoleUserSurfacedPermissions = {
		+[roleName: string]: $ReadOnlyArray<UserSurfacedPermission>,
		};
		// Iterates through the existing roles in the community and 'reverse maps'
		// the set of permission literals for each role to user-facing permission enums
		// to help pre-populate the permission checkboxes when editing roles.
		function useRoleUserSurfacedPermissions(
		threadInfo: ThreadInfo,
		): RoleUserSurfacedPermissions {
		return React.useMemo(() => {
		const roleNamesToPermissions = {};

		Object.keys(threadInfo.roles).forEach(roleID => {
		const roleName = threadInfo.roles[roleID].name;
		const rolePermissions = Object.keys(threadInfo.roles[roleID].permissions);
		const setOfUserSurfacedPermissions = new Set();

		rolePermissions.forEach(rolePermission => {
		const userSurfacedPermission = Object.keys(
		configurableCommunityPermissions,
		).find(key =>
		configurableCommunityPermissions[key].has(rolePermission),
		);

		if (userSurfacedPermission) {
		setOfUserSurfacedPermissions.add(userSurfacedPermission);
		}
		});
		roleNamesToPermissions[roleName] = [...setOfUserSurfacedPermissions];
		});

		return roleNamesToPermissions;
		}, [threadInfo]);
		}

export {		export {
threadHasPermission,		threadHasPermission,
viewerIsMember,		viewerIsMember,
threadInChatList,		threadInChatList,
threadIsTopLevel,		threadIsTopLevel,
threadIsChannel,		threadIsChannel,
threadIsSidebar,		threadIsSidebar,
threadInBackgroundChatList,		threadInBackgroundChatList,
▲ Show 20 Lines • Show All 50 Lines • ▼ Show 20 Lines	export {
switchMemberAdminRoleInThread,		switchMemberAdminRoleInThread,
getAvailableThreadMemberActions,		getAvailableThreadMemberActions,
threadMembersWithoutAddedAshoat,		threadMembersWithoutAddedAshoat,
validChatNameRegex,		validChatNameRegex,
chatNameMaxLength,		chatNameMaxLength,
patchThreadInfoToIncludeMentionedMembersOfParent,		patchThreadInfoToIncludeMentionedMembersOfParent,
threadInfoInsideCommunity,		threadInfoInsideCommunity,
useRoleMemberCountsForCommunity,		useRoleMemberCountsForCommunity,
		useRoleUserSurfacedPermissions,
};		};

View Options

native/account/qr-auth/secondary-device-not-responding.react.js

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Lines
import {		import {
type RobotextMessageInfo,		type RobotextMessageInfo,
type ComposableMessageInfo,		type ComposableMessageInfo,
} from '../types/message-types.js';		} from '../types/message-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js';		import { userRelationshipStatus } from '../types/relationship-types.js';
import {		import {
threadPermissionPropagationPrefixes,		threadPermissionPropagationPrefixes,
threadPermissions,		threadPermissions,
		configurableCommunityPermissions,
type ThreadPermission,		type ThreadPermission,
type ThreadPermissionsInfo,		type ThreadPermissionsInfo,
		type UserSurfacedPermission,
} from '../types/thread-permission-types.js';		} from '../types/thread-permission-types.js';
import {		import {
type ThreadType,		type ThreadType,
threadTypes,		threadTypes,
threadTypeIsCommunityRoot,		threadTypeIsCommunityRoot,
assertThreadType,		assertThreadType,
} from '../types/thread-types-enum.js';		} from '../types/thread-types-enum.js';
import {		import {
▲ Show 20 Lines • Show All 1,496 Lines • ▼ Show 20 Lines	Object.keys(roleIDsToNames).forEach(roleName => {
roleNamesToMemberCount[roleIDsToNames[roleName]] = 0;		roleNamesToMemberCount[roleIDsToNames[roleName]] = 0;
}		}
});		});

return roleNamesToMemberCount;		return roleNamesToMemberCount;
}, [threadInfo]);		}, [threadInfo]);
}		}

		type RoleUserSurfacedPermissions = {
		+[roleName: string]: $ReadOnlyArray<UserSurfacedPermission>,
		};
		// Iterates through the existing roles in the community and 'reverse maps'
		// the set of permission literals for each role to user-facing permission enums
		// to help pre-populate the permission checkboxes when editing roles.
		function useRoleUserSurfacedPermissions(
		threadInfo: ThreadInfo,
		): RoleUserSurfacedPermissions {
		return React.useMemo(() => {
		const roleNamesToPermissions = {};

		Object.keys(threadInfo.roles).forEach(roleID => {
		const roleName = threadInfo.roles[roleID].name;
		const rolePermissions = Object.keys(threadInfo.roles[roleID].permissions);
		const setOfUserSurfacedPermissions = new Set();

		rolePermissions.forEach(rolePermission => {
		const userSurfacedPermission = Object.keys(
		configurableCommunityPermissions,
		).find(key =>
		configurableCommunityPermissions[key].has(rolePermission),
		);

		if (userSurfacedPermission) {
		setOfUserSurfacedPermissions.add(userSurfacedPermission);
		}
		});
		roleNamesToPermissions[roleName] = [...setOfUserSurfacedPermissions];
		});

		return roleNamesToPermissions;
		}, [threadInfo]);
		}

export {		export {
threadHasPermission,		threadHasPermission,
viewerIsMember,		viewerIsMember,
threadInChatList,		threadInChatList,
threadIsTopLevel,		threadIsTopLevel,
threadIsChannel,		threadIsChannel,
threadIsSidebar,		threadIsSidebar,
threadInBackgroundChatList,		threadInBackgroundChatList,
▲ Show 20 Lines • Show All 50 Lines • ▼ Show 20 Lines	export {
switchMemberAdminRoleInThread,		switchMemberAdminRoleInThread,
getAvailableThreadMemberActions,		getAvailableThreadMemberActions,
threadMembersWithoutAddedAshoat,		threadMembersWithoutAddedAshoat,
validChatNameRegex,		validChatNameRegex,
chatNameMaxLength,		chatNameMaxLength,
patchThreadInfoToIncludeMentionedMembersOfParent,		patchThreadInfoToIncludeMentionedMembersOfParent,
threadInfoInsideCommunity,		threadInfoInsideCommunity,
useRoleMemberCountsForCommunity,		useRoleMemberCountsForCommunity,
		useRoleUserSurfacedPermissions,
};		};