Page MenuHomePhabricator
Differential D14088

[identity] Verify new flow migration device list update
ClosedPublic
Actions

Authored by bartek on Dec 6 2024, 1:35 AM.
Tags
None
Referenced Files
F3761523: D14088.id46459.diff
Fri, Jan 10, 4:44 PM
F3760195: D14088.id46574.diff
Fri, Jan 10, 12:45 PM
Unknown Object (File)
Wed, Jan 8, 8:20 PM
Unknown Object (File)
Wed, Jan 8, 7:49 AM
Unknown Object (File)
Tue, Jan 7, 9:42 PM
Unknown Object (File)
Mon, Jan 6, 1:52 AM
Unknown Object (File)
Fri, Jan 3, 2:05 PM
Unknown Object (File)
Fri, Jan 3, 1:05 PM
View All 36 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
Commits
rCOMMefd40b9457f6: [identity] Verify new flow migration device list update
Summary

Address ENG-9694

  • For old flows: Should allow reordering primary device under the following conditions:
    • Previous device list was unsigned.
    • Reorder only makes the calling device primary (only one swap, no more changes).
  • Otherwise, if previous device list was signed, it should act as before

Depends on D14087

Test Plan
  • Commtest
  • Manual testing during development of device list migration handler

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Dec 6 2024, 1:35 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 6 2024, 1:35 AM
Harbormaster failed remote builds in B32943: Diff 46227!Dec 6 2024, 2:00 AM
bartek updated this revision to Diff 46457.Sun, Dec 15, 10:32 PM

Rebase

Harbormaster failed remote builds in B33116: Diff 46457!Sun, Dec 15, 10:57 PM
bartek updated this revision to Diff 46459.Mon, Dec 16, 3:56 AM

Fix missing test

Harbormaster completed remote builds in B33118: Diff 46459.Mon, Dec 16, 4:13 AM
bartek published this revision for review.Mon, Dec 16, 4:24 AM
bartek added inline comments.
services/commtest/tests/identity_device_list_tests.rs
202–209 ↗(On Diff #46459)

Now all updates after migration need to be signed

bartek edited the test plan for this revision. (Show Details)Mon, Dec 16, 6:04 AM
kamil accepted this revision.Mon, Dec 16, 8:33 AM
This revision is now accepted and ready to land.Mon, Dec 16, 8:33 AM
Closed by commit rCOMMefd40b9457f6: [identity] Verify new flow migration device list update (authored by bartek). · Explain WhyThu, Dec 19, 1:55 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMefd40b9457f6: [identity] Verify new flow migration device list update.

Revision Contents
Changeset List

PathSize
services/
commtest/
tests/
59 lines
identity/
src/
16 lines
grpc_services/
51 lines

Diff 46574

View Options

services/commtest/tests/identity_device_list_tests.rs

Loading...
View Options

services/identity/src/device_list.rs

Loading...
View Options

services/identity/src/grpc_services/authenticated.rs

Loading...