[comm-lib] Move exponential backoff helper to a separate mod
ClosedPublic
Actions

Authored by bartek on May 12 2025, 8:49 AM.

Details

Reviewers

kamil

Commits

rCOMM2c9470498df6: [comm-lib] Move exponential backoff helper to a separate mod

Summary

This used to be DDB-specific but this helper is so universal that can be used anywhere, I want to use it for Blob client retries in later diffs.
Factored it out.

Depends on D14676

Test Plan

cargo check --all-features for the whole cargo workspace.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.May 12 2025, 8:49 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 12 2025, 8:49 AM

bartek added a child revision: D14681: [blob-client] Add assign_multiple_holders_with_retries.May 12 2025, 8:51 AM

Harbormaster completed remote builds in B34142: Diff 48029.May 12 2025, 9:09 AM

bartek published this revision for review.May 12 2025, 9:48 AM

bartek added inline comments.

shared/comm-lib/Cargo.toml
40	Previously, the `time` feature was used exclusively in the AWS-specific comm-lib parts, and aws-sdk-* implicitly included this feature. When I moved the code outside the `aws` feature, specifying this here became necessary.
shared/comm-lib/src/tools/exponential_backoff.rs
23–28	Technically, this should stay in the DDB-specific module, and be extracted to a separate db-specific config struct, but I didn't want to complicate things too much.