Differential D14706

[native][backup] Pass version info with backup upload
ClosedPublic
Actions

Authored by bartek on May 15 2025, 12:46 PM.

Details

Reviewers

kamil

Commits

rCOMMb768ae10ab7d: [native][backup] Pass version info with backup upload

Summary

ENG-10688 and its subtasks

Updated backup service and client to pass version info when uploading backup:

It's optional for UserKeys upload - old clients don't support it
It's required for UserData upload and full backup upload endpoint

Client-side, it's going to be uploaded for all three endpoints from now on.

Depends on D14705

Test Plan

Tested on staging. Performed full backup and backup restore on native, checked that version info is in DDB

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.May 15 2025, 12:46 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 15 2025, 12:46 PM

bartek edited the summary of this revision. (Show Details)May 15 2025, 12:48 PM

Harbormaster failed remote builds in B34182: Diff 48091!May 15 2025, 1:18 PM

Fix commtest

Harbormaster completed remote builds in B34185: Diff 48094.May 15 2025, 5:02 PM

bartek published this revision for review.May 16 2025, 8:56 AM

bartek added inline comments.

native/native_rust_library/src/backup/upload_handler.rs
240–241 ↗	(On Diff #48094)	https://linear.app/comm/issue/ENG-10771/pass-sqlite-database-version-to-backup-client

bartek added a child revision: D14708: [backup] Improve logging.May 16 2025, 9:21 AM

kamil accepted this revision.May 19 2025, 12:22 PM

This revision is now accepted and ready to land.May 19 2025, 12:22 PM

bartek edited the test plan for this revision. (Show Details)May 19 2025, 1:30 PM

Closed by commit rCOMMb768ae10ab7d: [native][backup] Pass version info with backup upload. · Explain WhyMay 19 2025, 1:52 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMb768ae10ab7d: [native][backup] Pass version info with backup upload.

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

backup/

upload_handler.rs

8 lines

services/

backup/

src/

http/

handlers/

backup.rs

30 lines

commtest/

src/

backup/

backup_utils.rs

1 line

shared/

backup_client/

src/

lib.rs

5 lines

Diff 48091

View Options

native/native_rust_library/src/backup/upload_handler.rs

View Options

services/backup/src/http/handlers/backup.rs

View Options

services/commtest/src/backup/backup_utils.rs

View Options

shared/backup_client/src/lib.rs

[native][backup] Pass version info with backup uploadClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48091

native/native_rust_library/src/backup/upload_handler.rs

services/backup/src/http/handlers/backup.rs

services/commtest/src/backup/backup_utils.rs

shared/backup_client/src/lib.rs

[native][backup] Pass version info with backup upload
ClosedPublic
Actions

Revision Contents
Changeset List