Differential D14675

[native] Pass backup size, timestamp and version info to JS
ClosedPublic
Actions

Authored by bartek on May 9 2025, 9:53 AM.

Tags

None

Referenced Files

	F32895392: D14675.1768178916.diff
	Sun, Jan 11, 12:48 AM

	F32895277: D14675.1768177537.diff
	Sun, Jan 11, 12:25 AM

	F32885357: D14675.1768162118.diff
	Sat, Jan 10, 8:08 PM

	F32885346: D14675.1768162110.diff
	Sat, Jan 10, 8:08 PM

Subscribers

Details

Reviewers

kamil
tomek

Commits

rCOMM8b776350234b: [native] Pass backup size, timestamp and version info to JS

Summary

Passed values from D14674 and D14704 to JS. Now console-logging them during restore, later we can add a UI

Depends on D14704

Test Plan

With backup deployed to staging, performed a restore flow and checked RN logs - all the new values were printed when restoring

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.May 9 2025, 9:53 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMay 9 2025, 9:53 AM

Harbormaster failed remote builds in B34130: Diff 48003!May 9 2025, 10:05 AM

Fix toString

Harbormaster completed remote builds in B34140: Diff 48027.May 12 2025, 9:08 AM

Also add version info

bartek edited the summary of this revision. (Show Details)May 15 2025, 12:34 PM

bartek added a parent revision: D14704: [backup][terraform] Add size and version info to OrderedBackupItem.

bartek removed a parent revision: D14674: [backup] Return backup size and timestamp in LatestBackupInfo.

bartek edited the summary of this revision. (Show Details)

bartek retitled this revision from [native] Pass backup size and creation time to JS to [native] Pass backup size, timestamp and version info to JS.May 15 2025, 12:37 PM

Harbormaster completed remote builds in B34180: Diff 48089.May 15 2025, 1:05 PM

JSON stringify to make it clean

bartek published this revision for review.May 16 2025, 9:24 AM

Harbormaster completed remote builds in B34188: Diff 48097.May 16 2025, 9:41 AM

bartek edited the test plan for this revision. (Show Details)May 19 2025, 1:31 PM

kamil accepted this revision.May 19 2025, 2:28 PM

This revision is now accepted and ready to land.May 19 2025, 2:28 PM

bartek mentioned this in D14715: [comm-lib] Fix restore flow for non-deployed backup.May 20 2025, 10:25 AM

bartek mentioned this in rCOMM3d1afa738a4d: [comm-lib] Fix restore flow for non-deployed backup.May 20 2025, 10:52 AM

Rebase. Revert temporary changes to defaults

Harbormaster completed remote builds in B34262: Diff 48226.May 26 2025, 11:50 AM

Closed by commit rCOMM8b776350234b: [native] Pass backup size, timestamp and version info to JS. · Explain WhyMay 26 2025, 11:59 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM8b776350234b: [native] Pass backup size, timestamp and version info to JS.

Revision Contents
Changeset List

Path

Size

lib/

types/

backup-types.js

20 lines

native/

account/

18 lines

native_rust_library/

src/

15 lines

shared/

backup_client/

src/

4 lines

Diff 48097

lib/types/backup-types.js

Loading...

native/account/restore.js

Loading...

native/native_rust_library/src/backup.rs

Loading...

shared/backup_client/src/lib.rs

Loading...