Page MenuHomePhabricator
Differential D3122

[web] [fix] render correct font family's in app
ClosedPublic
Actions

Authored by • benschac on Feb 7 2022, 5:52 AM.
Tags
None
Referenced Files
F3298732: D3122.id9453.diff
Sun, Nov 17, 8:16 AM
F3298439: D3122.diff
Sun, Nov 17, 6:29 AM
Unknown Object (File)
Tue, Nov 5, 12:51 AM
Unknown Object (File)
Sun, Nov 3, 1:21 PM
Unknown Object (File)
Sun, Nov 3, 1:21 PM
Unknown Object (File)
Sun, Nov 3, 1:21 PM
Unknown Object (File)
Thu, Oct 24, 11:54 PM
Unknown Object (File)
Thu, Oct 24, 11:54 PM
View All Files
Subscribers
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMM9a1a50b40f57: [web] [fix] render correct font family's in app
Summary

Word mark is now loaded both client and server side. Additionally, I updated google fonts to include Inter as well.

Test Plan

N/A. There isn't a great way to test this in development

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• benschac created this revision.Feb 7 2022, 5:52 AM
Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptFeb 7 2022, 5:52 AM
• benschac published this revision for review.Feb 7 2022, 5:53 AM
• benschac added inline comments.
server/src/responders/website-responders.js
54 ↗(On Diff #9343)

We don't use any of these fonts any more

54 ↗(On Diff #9343)

Add 600 weight to font

Harbormaster completed remote builds in B6591: Diff 9343.Feb 7 2022, 5:56 AM
• benschac retitled this revision from [web] [fix] word mark header font family to [web] [fix] render correct font family's in app.Feb 7 2022, 6:02 AM
atul requested changes to this revision.Feb 7 2022, 6:02 AM

I might have missed it, but what's the point of @fontsource if we're still using Google Fonts?

This revision now requires changes to proceed.Feb 7 2022, 6:02 AM
• benschac added a comment.Feb 7 2022, 12:07 PM
In D3122#82247, @atul wrote:

I might have missed it, but what's the point of @fontsource if we're still using Google Fonts?

I thought we'd need it if the user had JS turned off. But

Image 2022-02-07 at 3.05.42 PM.jpg (1×1 px, 430 KB)
, seems like fontsource is working.

• benschac updated this revision to Diff 9358.Feb 7 2022, 12:26 PM

remove google changes

Harbormaster completed remote builds in B6602: Diff 9358.Feb 7 2022, 12:32 PM
atul accepted this revision.Feb 8 2022, 8:33 AM

There isn't a great way to test this in development

At least on Safari you can do Inspect Element and go to the Font tab and it'll tell you computed font, where it sourced it from, etc.

This revision is now accepted and ready to land.Feb 8 2022, 8:33 AM
Herald added a reviewer: ashoat. · View Herald TranscriptFeb 8 2022, 8:33 AM
This revision now requires review to proceed.Feb 8 2022, 8:33 AM
ashoat accepted this revision.Feb 8 2022, 8:15 PM
This revision is now accepted and ready to land.Feb 8 2022, 8:15 PM
Closed by commit rCOMM9a1a50b40f57: [web] [fix] render correct font family's in app (authored by • benschac). · Explain WhyFeb 9 2022, 6:55 AM
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMM9a1a50b40f57: [web] [fix] render correct font family's in app.
ashoat mentioned this in D3372: [web] Remove fontsource.Mar 8 2022, 4:08 PM
ashoat mentioned this in rCOMM84125bd37f37: [web] Remove fontsource.Mar 8 2022, 4:14 PM

Revision Contents
Changeset List

PathSize
server/
src/
responders/
2 lines
web/
5 lines
1 line
5 lines

Diff 9453

View Options

server/src/responders/website-responders.js

Loading...
View Options

web/app.react.js

Loading...
View Options

web/package.json

Loading...
View Options

yarn.lock

Loading...