Page MenuHomePhabricator

[web] [fix] render correct font family's in app
ClosedPublic

Authored by benschac on Feb 7 2022, 5:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 17 2024, 8:46 AM
Unknown Object (File)
Nov 17 2024, 8:46 AM
Unknown Object (File)
Nov 17 2024, 8:16 AM
Unknown Object (File)
Nov 17 2024, 6:29 AM
Unknown Object (File)
Nov 5 2024, 12:51 AM
Unknown Object (File)
Nov 3 2024, 1:21 PM
Unknown Object (File)
Nov 3 2024, 1:21 PM
Unknown Object (File)
Nov 3 2024, 1:21 PM

Details

Summary

Word mark is now loaded both client and server side. Additionally, I updated google fonts to include Inter as well.

Test Plan

N/A. There isn't a great way to test this in development

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

benschac added inline comments.
server/src/responders/website-responders.js
54 ↗(On Diff #9343)

We don't use any of these fonts any more

54 ↗(On Diff #9343)

Add 600 weight to font

benschac retitled this revision from [web] [fix] word mark header font family to [web] [fix] render correct font family's in app.Feb 7 2022, 6:02 AM
atul requested changes to this revision.Feb 7 2022, 6:02 AM

I might have missed it, but what's the point of @fontsource if we're still using Google Fonts?

This revision now requires changes to proceed.Feb 7 2022, 6:02 AM
In D3122#82247, @atul wrote:

I might have missed it, but what's the point of @fontsource if we're still using Google Fonts?

I thought we'd need it if the user had JS turned off. But

Image 2022-02-07 at 3.05.42 PM.jpg (1×1 px, 430 KB)
, seems like fontsource is working.

There isn't a great way to test this in development

At least on Safari you can do Inspect Element and go to the Font tab and it'll tell you computed font, where it sourced it from, etc.

This revision is now accepted and ready to land.Feb 8 2022, 8:33 AM
This revision now requires review to proceed.Feb 8 2022, 8:33 AM
This revision is now accepted and ready to land.Feb 8 2022, 8:15 PM