Page MenuHomePhabricator
Feed Advanced Search

Jul 26 2022

jacek closed D4610: [web] Introduce `SidebarsModal`.
Jul 26 2022, 8:30 AM
jacek closed D4609: [web] Introduce `SidebarList` component.
Jul 26 2022, 8:30 AM
jacek committed rCOMM496e35e418ab: [web] Introduce `SidebarsModal` (authored by jacek).
[web] Introduce `SidebarsModal`
Jul 26 2022, 8:30 AM
jacek committed rCOMM0c0089870261: [web] Introduce `SidebarList` component (authored by jacek).
[web] Introduce `SidebarList` component
Jul 26 2022, 8:30 AM
jacek closed D4608: [web] Introduce `Sidebar` component.
Jul 26 2022, 8:30 AM
jacek closed D4607: [web] Add SVGs with arrows for sidebars modal.
Jul 26 2022, 8:30 AM
jacek committed rCOMM23bcfc59b265: [web] Add SVGs with arrows for sidebars modal (authored by jacek).
[web] Add SVGs with arrows for sidebars modal
Jul 26 2022, 8:30 AM
jacek committed rCOMM296f64250f2e: [web] Introduce `Sidebar` component (authored by jacek).
[web] Introduce `Sidebar` component
Jul 26 2022, 8:30 AM
jacek closed D4606: [web] Introduce `useFilteredChildThreads` hook.
Jul 26 2022, 8:30 AM
jacek committed rCOMM740dc18c6558: [web] Introduce `useFilteredChildThreads` hook (authored by jacek).
[web] Introduce `useFilteredChildThreads` hook
Jul 26 2022, 8:30 AM
jacek updated the diff for D4610: [web] Introduce `SidebarsModal`.

remove redundant boolean cast

Jul 26 2022, 8:12 AM
jacek added inline comments to D4610: [web] Introduce `SidebarsModal`.
Jul 26 2022, 8:09 AM
jacek requested review of D4644: [lib] Rename `locallyUnique...` to `pending...` to improve readability.
Jul 26 2022, 7:41 AM
jacek requested changes to D4640: [web] Remove creating a new siedebar/thread with an empty message.

I think the title of the diff should reference any chat - not only sidebar.

Jul 26 2022, 6:22 AM
jacek requested review of D4610: [web] Introduce `SidebarsModal`.
Jul 26 2022, 4:39 AM
jacek requested review of D4608: [web] Introduce `Sidebar` component.
Jul 26 2022, 4:37 AM
jacek updated the diff for D4610: [web] Introduce `SidebarsModal`.

Address Tomek's sugegstions. Moved callback to thread-utils.js

Jul 26 2022, 4:37 AM
jacek updated the diff for D4608: [web] Introduce `Sidebar` component.

Replace div with button

Jul 26 2022, 4:35 AM
jacek added inline comments to D4610: [web] Introduce `SidebarsModal`.
Jul 26 2022, 4:15 AM
jacek requested review of D4612: [web] Remove old `SidebarListModal` component.
Jul 26 2022, 3:41 AM
jacek updated the diff for D4612: [web] Remove old `SidebarListModal` component.

removed unused styles

Jul 26 2022, 3:41 AM
jacek closed D4599: [web] Simplify `MessageListContainer` and `ChatTabs` CSS.
Jul 26 2022, 3:32 AM
jacek committed rCOMM095e619020e3: [web] Simplify `MessageListContainer` and `ChatTabs` CSS (authored by jacek).
[web] Simplify `MessageListContainer` and `ChatTabs` CSS
Jul 26 2022, 3:32 AM
jacek updated the diff for D4599: [web] Simplify `MessageListContainer` and `ChatTabs` CSS.

rebase

Jul 26 2022, 3:14 AM
jacek closed D4618: [web] Remove old `NewThreadModal` component.
Jul 26 2022, 3:06 AM
jacek closed D4615: [web] Move selected chat to the top of the list in creation mode.
Jul 26 2022, 3:06 AM
jacek committed rCOMM633414d38308: [web] Remove old `NewThreadModal` component (authored by jacek).
[web] Remove old `NewThreadModal` component
Jul 26 2022, 3:06 AM
jacek closed D4474: [web] Keep `activeChatThreadID` and `pendingThread` updated in `navInfo` in thread creation mode.
Jul 26 2022, 3:06 AM
jacek committed rCOMM1d3670bbd248: [web] Move selected chat to the top of the list in creation mode (authored by jacek).
[web] Move selected chat to the top of the list in creation mode
Jul 26 2022, 3:06 AM
jacek closed D4470: [web] Fix navigation after clicking on thread from thread list.
Jul 26 2022, 3:06 AM
jacek closed D4469: [web] Introduce "Create new chat" button.
Jul 26 2022, 3:06 AM
jacek committed rCOMM2a5d63b3766a: [web] Fix navigation after clicking on thread from thread list (authored by jacek).
[web] Fix navigation after clicking on thread from thread list
Jul 26 2022, 3:06 AM
jacek committed rCOMMf99f20f2579e: [web] Keep `activeChatThreadID` and `pendingThread` updated in `navInfo` in… (authored by jacek).
[web] Keep `activeChatThreadID` and `pendingThread` updated in `navInfo` in…
Jul 26 2022, 3:06 AM
jacek closed D4466: [web] Introduce `useOnClickNewThread` hook.
Jul 26 2022, 3:06 AM
jacek committed rCOMM59666b4c55b9: [web] Introduce `useOnClickNewThread` hook (authored by jacek).
[web] Introduce `useOnClickNewThread` hook
Jul 26 2022, 3:06 AM
jacek committed rCOMM3dc5eb28e945: [web] Introduce "Create new chat" button (authored by jacek).
[web] Introduce "Create new chat" button
Jul 26 2022, 3:06 AM
jacek closed D4465: [web] Support chat creation in `ChatMessageListContainer`.
Jul 26 2022, 3:06 AM
jacek closed D4464: [web] Close thread composer after sending a message.
Jul 26 2022, 3:06 AM
jacek committed rCOMM0f195a6a243d: [web] Support chat creation in `ChatMessageListContainer` (authored by jacek).
[web] Support chat creation in `ChatMessageListContainer`
Jul 26 2022, 3:06 AM
jacek closed D4463: [web] Introduce onMessageSent callbacks.
Jul 26 2022, 3:06 AM
jacek committed rCOMMc0f4929b9b40: [web] Introduce onMessageSent callbacks (authored by jacek).
[web] Introduce onMessageSent callbacks
Jul 26 2022, 3:06 AM
jacek committed rCOMM8812e9359992: [web] Close thread composer after sending a message (authored by jacek).
[web] Close thread composer after sending a message
Jul 26 2022, 3:06 AM
jacek closed D4462: [web] Implement callbacks modifying navigation from `ChatThreadComposer`.
Jul 26 2022, 3:06 AM
jacek closed D4461: [web] Introduce `ChatThreadComposer` component for selecting users to new thread.
Jul 26 2022, 3:06 AM
jacek committed rCOMM031fe399d93b: [web] Implement callbacks modifying navigation from `ChatThreadComposer` (authored by jacek).
[web] Implement callbacks modifying navigation from `ChatThreadComposer`
Jul 26 2022, 3:06 AM
jacek committed rCOMM13cfca120395: [web] Introduce `ChatThreadComposer` component for selecting users to new thread (authored by jacek).
[web] Introduce `ChatThreadComposer` component for selecting users to new thread
Jul 26 2022, 3:06 AM
jacek closed D4457: [web] Introduce `chat-creation` mode in `navInfo`.
Jul 26 2022, 3:06 AM
jacek committed rCOMMaeededdb14bb: [web] Introduce `chat-creation` mode in `navInfo` (authored by jacek).
[web] Introduce `chat-creation` mode in `navInfo`
Jul 26 2022, 3:06 AM
jacek updated the diff for D4462: [web] Implement callbacks modifying navigation from `ChatThreadComposer`.

rebase

Jul 26 2022, 2:47 AM
jacek updated the diff for D4464: [web] Close thread composer after sending a message.

rebase

Jul 26 2022, 2:33 AM
jacek updated the diff for D4466: [web] Introduce `useOnClickNewThread` hook.

rebase

Jul 26 2022, 2:33 AM
jacek updated the diff for D4465: [web] Support chat creation in `ChatMessageListContainer`.

rebase

Jul 26 2022, 2:31 AM
jacek added a comment to D4457: [web] Introduce `chat-creation` mode in `navInfo`.

Agree with both of those conclusions!

We also agreed, that as a follow-up task it would be good to refactor the navigation to keep navigation state in more nested structure

We could create a new backlog task for this one.

Jul 26 2022, 1:52 AM
jacek added inline comments to D4606: [web] Introduce `useFilteredChildThreads` hook.
Jul 26 2022, 1:09 AM
jacek updated the diff for D4606: [web] Introduce `useFilteredChildThreads` hook.

wrap default value in useCallback

Jul 26 2022, 1:06 AM

Jul 25 2022

jacek requested review of D4618: [web] Remove old `NewThreadModal` component.
Jul 25 2022, 7:22 AM
jacek requested review of D4606: [web] Introduce `useFilteredChildThreads` hook.
Jul 25 2022, 7:18 AM
jacek closed D4455: [web] Introduce pending thread creation in `websiteResponder` if it is missing.
Jul 25 2022, 6:56 AM
jacek closed D4456: [web] Include current pending thread in thread list.
Jul 25 2022, 6:56 AM
jacek committed rCOMM4aaa1bb72682: [web] Include current pending thread in thread list (authored by jacek).
[web] Include current pending thread in thread list
Jul 25 2022, 6:56 AM
jacek committed rCOMM7cbf37b87e29: [web] Introduce pending thread creation in `websiteResponder` if it is missing (authored by jacek).
[web] Introduce pending thread creation in `websiteResponder` if it is missing
Jul 25 2022, 6:56 AM
jacek closed D4446: [lib] Create util function for parsing locally unique thread ID.
Jul 25 2022, 6:56 AM
jacek committed rCOMM6f183e6bbeee: [lib] Create util function for parsing locally unique thread ID (authored by jacek).
[lib] Create util function for parsing locally unique thread ID
Jul 25 2022, 6:56 AM
jacek added a comment to D4455: [web] Introduce pending thread creation in `websiteResponder` if it is missing.
  1. Optional: Introduce new action types to separate out the logic in reduceNavInfo(...)

I'm not sure if it's necessary for the case here, but it may be good to cover it with a separate task, as it may help in the future to keep the navigation state consistent.

Jul 25 2022, 6:53 AM
jacek updated the diff for D4609: [web] Introduce `SidebarList` component.

Replaced "!" with "." and address Tomek's suggestion

Jul 25 2022, 6:39 AM
jacek retitled D4606: [web] Introduce `useFilteredChildThreads` hook from [web] Introduce `useChildThreads` hook to [web] Introduce `useFilteredChildThreads` hook.
Jul 25 2022, 6:35 AM
jacek updated the diff for D4606: [web] Introduce `useFilteredChildThreads` hook.

address Tomek's suggestions

Jul 25 2022, 6:35 AM
jacek updated the summary of D4609: [web] Introduce `SidebarList` component.
Jul 25 2022, 6:12 AM
jacek added inline comments to D4465: [web] Support chat creation in `ChatMessageListContainer`.
Jul 25 2022, 6:03 AM
jacek requested review of D4457: [web] Introduce `chat-creation` mode in `navInfo`.
Jul 25 2022, 5:54 AM
jacek added inline comments to D4457: [web] Introduce `chat-creation` mode in `navInfo`.
Jul 25 2022, 5:54 AM
jacek updated the diff for D4457: [web] Introduce `chat-creation` mode in `navInfo`.

modified regex so it support only non-empty IDs

Jul 25 2022, 5:52 AM
jacek closed D4443: [lib] Support pending threads in `URLInfo` calculation.
Jul 25 2022, 4:02 AM
jacek closed D4435: [server] Support pending threads when calculating `finalNavInfo`.
Jul 25 2022, 4:02 AM
jacek committed rCOMM00d18fc18e7b: [server] Support pending threads when calculating `finalNavInfo` (authored by jacek).
[server] Support pending threads when calculating `finalNavInfo`
Jul 25 2022, 4:02 AM
jacek committed rCOMMd87483fb6dce: [lib] Support pending threads in `URLInfo` calculation (authored by jacek).
[lib] Support pending threads in `URLInfo` calculation
Jul 25 2022, 4:02 AM
jacek closed D4434: [web] Separate `ChatMessageListContainer` from `ChatMessageList`.
Jul 25 2022, 4:02 AM
jacek committed rCOMMb4970a37dfb0: [web] Separate `ChatMessageListContainer` from `ChatMessageList` (authored by jacek).
[web] Separate `ChatMessageListContainer` from `ChatMessageList`
Jul 25 2022, 4:02 AM
jacek requested review of D4615: [web] Move selected chat to the top of the list in creation mode.
Jul 25 2022, 3:17 AM
jacek added a comment to D4461: [web] Introduce `ChatThreadComposer` component for selecting users to new thread.

We could maybe make a Backlog task to make this better (either "zoom" the scrollbar to the part of the inbox that has the thread, or move the thread to the top when it's selected)

Would be good to do this before landing

Jul 25 2022, 3:08 AM
jacek requested review of D4599: [web] Simplify `MessageListContainer` and `ChatTabs` CSS.

Can you modify the test plan to make sure you test on all relevant browsers? We shouldn't be making big layout changes like this without testing every browser

Jul 25 2022, 1:28 AM
jacek updated the test plan for D4599: [web] Simplify `MessageListContainer` and `ChatTabs` CSS.
Jul 25 2022, 1:25 AM

Jul 22 2022

jacek requested review of D4611: [web] Open `SidebarsModal` instead `SidebarListModal` on web.
Jul 22 2022, 10:34 AM
jacek requested review of D4612: [web] Remove old `SidebarListModal` component.
Jul 22 2022, 8:44 AM
jacek requested review of D4610: [web] Introduce `SidebarsModal`.
Jul 22 2022, 8:38 AM
jacek requested review of D4609: [web] Introduce `SidebarList` component.
Jul 22 2022, 8:35 AM
jacek requested review of D4608: [web] Introduce `Sidebar` component.
Jul 22 2022, 8:33 AM
jacek requested review of D4607: [web] Add SVGs with arrows for sidebars modal.
Jul 22 2022, 8:28 AM
jacek requested review of D4606: [web] Introduce `useFilteredChildThreads` hook.
Jul 22 2022, 8:24 AM
jacek added 1 blocking reviewer(s) for D4601: Remove messageInfos fileds from iOS notification if its size exceeds defined limit: tomek.

I may have not enough context about the notifications (maybe it would be good to add linear task reference in diff description), so adding @tomek as blocking reviewer, but I have some comments and questions below:
First, it's good to always add related revisions when some changes depend on other diffs.
I see, that the diff uses variables from D4600, but in D4600 also validateAndroidNotificationByteSize is defined - was it just moved, or is it duplicated? Maybe push/utils.js is a better place for these functions?
I'm not sure if validate... is a good name for the function that mutates an object. Maybe something more like validateAndReduceExceededNotificationSize... would better describe what it does?
What happens if notifications after removing messageInfos still exceeds limits? Shouldn't the size be checked again somewhere after reducing notification and such situation be handled somehow? Or is it impossible to happen?

Jul 22 2022, 1:21 AM

Jul 21 2022

jacek requested review of D4599: [web] Simplify `MessageListContainer` and `ChatTabs` CSS.
Jul 21 2022, 6:58 AM
jacek updated the diff for D4474: [web] Keep `activeChatThreadID` and `pendingThread` updated in `navInfo` in thread creation mode.

address Tomek's comment

Jul 21 2022, 6:31 AM
jacek added inline comments to D4474: [web] Keep `activeChatThreadID` and `pendingThread` updated in `navInfo` in thread creation mode.
Jul 21 2022, 6:29 AM
jacek requested review of D4465: [web] Support chat creation in `ChatMessageListContainer`.

Returning to review after discussion with Tomek about other possible solutions

Jul 21 2022, 6:00 AM
jacek updated the diff for D4463: [web] Introduce onMessageSent callbacks.

changed the types to () => mixed & wrap using useCallback

Jul 21 2022, 5:56 AM
jacek planned changes to D4474: [web] Keep `activeChatThreadID` and `pendingThread` updated in `navInfo` in thread creation mode.
Jul 21 2022, 5:51 AM
jacek updated the summary of D4469: [web] Introduce "Create new chat" button.
Jul 21 2022, 5:50 AM
jacek retitled D4469: [web] Introduce "Create new chat" button from [web] Introduce "Create new thread" button to [web] Introduce "Create new chat" button.
Jul 21 2022, 5:49 AM
jacek updated the diff for D4469: [web] Introduce "Create new chat" button.

rename thread to chat & address Tomek's comment

Jul 21 2022, 5:49 AM
jacek updated the diff for D4474: [web] Keep `activeChatThreadID` and `pendingThread` updated in `navInfo` in thread creation mode.

changed the types to () => mixed & wrap using useCallback
Accidentally added description from different diff

Jul 21 2022, 5:03 AM