update
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Sep 6 2022
Sep 6 2022
• karol updated the diff for D5030: [services] Rust Integration - Backup - Make report_error shared.
update
• karol updated the diff for D5037: [services] Rust Integration - Backup - Rust - Multiple get clients.
revert incorrect change
• karol added inline comments to D5037: [services] Rust Integration - Backup - Rust - Multiple get clients.
• karol added a comment to D5036: [services] Rust Integration - Backup - c++ - Multiple put clients.
I think I meant "I don't think so" instead of "I think so", sorry.
• karol updated the diff for D5035: [services] Rust Integration - Backup - Rust - Multiple put clients.
address comments
• karol added inline comments to D5035: [services] Rust Integration - Backup - Rust - Multiple put clients.
• karol requested review of D5036: [services] Rust Integration - Backup - c++ - Multiple put clients.
In D5036#147000, @tomek wrote:Can we avoid having to put an additional argument to every call? This is error-prone.
• karol updated the diff for D5034: [services] Rust Integration - Backup - Rust - Add converting functions.
avoid unwrap
• karol added inline comments to D5034: [services] Rust Integration - Backup - Rust - Add converting functions.
• karol updated the summary of D5029: [services] Rust Integration - Backup - Stop rethrowing in create new backup reactor.
• karol added inline comments to D5024: [services] Rust Integration - Catch std::exception in base bidi reactor.
• karol added inline comments to D5020: [services] Backup - Use Blob client in c++ - Implement pull backup.
• karol requested review of D5020: [services] Backup - Use Blob client in c++ - Implement pull backup.
In D5019#146919, @tomek wrote:Why do we call put_client_blocking_read_cxx a couple of times?
• karol added inline comments to D5018: [services] Backup - Use Blob client in c++ - Implement add attachment.
• karol updated the diff for D5018: [services] Backup - Use Blob client in c++ - Implement add attachment.
fix
• karol updated the diff for D5017: [services] Backup - Use Blob client in c++ - Implement create new backup.
address fdbck
• karol added inline comments to D5017: [services] Backup - Use Blob client in c++ - Implement create new backup.
address comments
address comments
remove comment
remove comment
add check error
remove comment
update comment
address comments
Sep 5 2022
Sep 5 2022
address comment
• karol added inline comments to D5005: [services] Backup - Blob Put Client - Add essential objects.
What about this @jon
Could you please address my comment? Thanks!
Sep 4 2022
Sep 4 2022
Why do you keep blocking this? I created and linked a linear task for this. I think this is not a high priority, this can be done anytime by anyone on the team, it's better to first focus on crucial functionalities and only when they work, finish up by polishing the details, especially that we're going through unknown a little bit.
Sep 2 2022
Sep 2 2022
• karol requested review of D5038: [services] Rust Integration - Backup - c++ - Multiple get clients.
rebase
update
address feedback
• karol added inline comments to D5005: [services] Backup - Blob Put Client - Add essential objects.
• karol updated the diff for D5019: [services] Backup - Use Blob client in c++ - Implement send log.
rebase
• karol updated the diff for D5018: [services] Backup - Use Blob client in c++ - Implement add attachment.
rebase
• karol updated the diff for D5017: [services] Backup - Use Blob client in c++ - Implement create new backup.
rebase
• karol planned changes to D5018: [services] Backup - Use Blob client in c++ - Implement add attachment.
rebase
address feedback
You're right, we can use a field from the files generated by the protobuf
• karol updated the diff for D5030: [services] Rust Integration - Backup - Make report_error shared.
update
• karol updated the diff for D5029: [services] Rust Integration - Backup - Stop rethrowing in create new backup reactor.
retrigger CI
• karol added a comment to D5029: [services] Rust Integration - Backup - Stop rethrowing in create new backup reactor.
It builds on my mac, also cargo check works (and the CI error is from rust). Not sure what's going on, I'm going to restart the CI.
• karol requested review of D5036: [services] Rust Integration - Backup - c++ - Multiple put clients.
• karol requested review of D5034: [services] Rust Integration - Backup - Rust - Add converting functions.
• karol requested review of D5035: [services] Rust Integration - Backup - Rust - Multiple put clients.
Backup doesn't build but this is explained in the test plan section.
• karol requested review of D5037: [services] Rust Integration - Backup - Rust - Multiple get clients.
Backup doesn't build but this is explained in the test plan section.
CI
• karol planned changes to D5029: [services] Rust Integration - Backup - Stop rethrowing in create new backup reactor.
CI
• karol updated the diff for D5030: [services] Rust Integration - Backup - Make report_error shared.
update
• karol updated the diff for D5029: [services] Rust Integration - Backup - Stop rethrowing in create new backup reactor.
update
• karol updated the diff for D5030: [services] Rust Integration - Backup - Make report_error shared.
update
Then we should either have a linear task for it or a diff already up.
• karol requested review of D5027: [services] Rust Integration - Backup - Stop rethrowing in send log reactor.
• karol requested review of D5026: [services] Rust Integration - Catch std::exception in base write reactor.
• karol requested review of D5025: [services] Rust Integration - Catch std::exception in base read reactor.
• karol requested review of D5024: [services] Rust Integration - Catch std::exception in base bidi reactor.
Sep 1 2022
Sep 1 2022
- Ok, I understand, but then the diff title isn't valid. The diff title says explicitly "move" and yet you're not moving things, so maybe it should say "add"? If this is about to be addressed in the future, we should either have a diff for it or a task on linear and add a reference here.
- What about my inline comment? Has not been addressed.
• karol requested review of D5020: [services] Backup - Use Blob client in c++ - Implement pull backup.
• karol requested review of D5017: [services] Backup - Use Blob client in c++ - Implement create new backup.
Abandoning this stack in favor of the new one that starts @ D5002.
• karol requested review of D5018: [services] Backup - Use Blob client in c++ - Implement add attachment.
Abandoning this stack in favor of the new one that starts @ D5002.