Page MenuHomePhabricator
Feed Advanced Search

Sep 19 2022

karol closed D5099: [services] Backup - Blob Get Client - Pass rust string instead of const char*.
Sep 19 2022, 7:28 AM
karol committed rCOMMfad989a99d6c: [services] Backup - Blob Get Client - Pass rust string instead of const char* (authored by karol).
[services] Backup - Blob Get Client - Pass rust string instead of const char*
Sep 19 2022, 7:28 AM
karol closed D5097: [services] Backup - Blob Get Client - Cleanup.
Sep 19 2022, 7:28 AM
karol committed rCOMM37af4e6583b9: [services] Backup - Blob Get Client - Cleanup (authored by karol).
[services] Backup - Blob Get Client - Cleanup
Sep 19 2022, 7:28 AM
karol closed D5096: [services] Backup - Blob Get Client - Refactor put initialize.
Sep 19 2022, 7:28 AM
karol committed rCOMMf7cf2bdf5367: [services] Backup - Blob Get Client - Refactor put initialize (authored by karol).
[services] Backup - Blob Get Client - Refactor put initialize
Sep 19 2022, 7:28 AM
karol closed D5095: [services] Backup - Blob Get Client - Refactor put read.
Sep 19 2022, 7:28 AM
karol committed rCOMMd368b1a6629b: [services] Backup - Blob Get Client - Refactor put read (authored by karol).
[services] Backup - Blob Get Client - Refactor put read
Sep 19 2022, 7:28 AM
karol closed D5094: [services] Backup - Blob Get Client - Refactor put write.
Sep 19 2022, 7:28 AM
karol committed rCOMM6734fee9add9: [services] Backup - Blob Get Client - Refactor put write (authored by karol).
[services] Backup - Blob Get Client - Refactor put write
Sep 19 2022, 7:28 AM
karol closed D5093: [services] Backup - Blob Get Client - Refactor put terminate.
Sep 19 2022, 7:28 AM
karol committed rCOMMc0d83a91976c: [services] Backup - Blob Get Client - Refactor put terminate (authored by karol).
[services] Backup - Blob Get Client - Refactor put terminate
Sep 19 2022, 7:28 AM
karol closed D5092: [services] Backup - Blob Get Client - Refactor get initialize.
Sep 19 2022, 7:28 AM
karol committed rCOMM448ee799463f: [services] Backup - Blob Get Client - Refactor get initialize (authored by karol).
[services] Backup - Blob Get Client - Refactor get initialize
Sep 19 2022, 7:28 AM
karol closed D5091: [services] Backup - Blob Get Client - Refactor get read.
Sep 19 2022, 7:27 AM
karol committed rCOMM14ddb5efea43: [services] Backup - Blob Get Client - Refactor get read (authored by karol).
[services] Backup - Blob Get Client - Refactor get read
Sep 19 2022, 7:27 AM
karol closed D5090: [services] Backup - Blob Get Client - Refactor get terminate.
Sep 19 2022, 7:27 AM
karol committed rCOMM62a36b5fca6b: [services] Backup - Blob Get Client - Refactor get terminate (authored by karol).
[services] Backup - Blob Get Client - Refactor get terminate
Sep 19 2022, 7:27 AM
karol updated the diff for D5099: [services] Backup - Blob Get Client - Pass rust string instead of const char*.

rebase

Sep 19 2022, 7:27 AM
karol updated the diff for D5097: [services] Backup - Blob Get Client - Cleanup.

rebase

Sep 19 2022, 7:27 AM
karol updated the diff for D5096: [services] Backup - Blob Get Client - Refactor put initialize.

rebase

Sep 19 2022, 7:26 AM
karol updated the diff for D5095: [services] Backup - Blob Get Client - Refactor put read.

rebase

Sep 19 2022, 7:26 AM
karol updated the diff for D5094: [services] Backup - Blob Get Client - Refactor put write.

rebase

Sep 19 2022, 7:26 AM
karol updated the diff for D5093: [services] Backup - Blob Get Client - Refactor put terminate.

rebase

Sep 19 2022, 7:26 AM
karol updated the diff for D5092: [services] Backup - Blob Get Client - Refactor get initialize.

rebase

Sep 19 2022, 7:26 AM
karol updated the diff for D5091: [services] Backup - Blob Get Client - Refactor get read.

rebase

Sep 19 2022, 7:25 AM
karol updated the diff for D5090: [services] Backup - Blob Get Client - Refactor get terminate.

rebase

Sep 19 2022, 7:25 AM
karol added inline comments to D5096: [services] Backup - Blob Get Client - Refactor put initialize.
Sep 19 2022, 7:22 AM
karol added inline comments to D5094: [services] Backup - Blob Get Client - Refactor put write.
Sep 19 2022, 7:14 AM
karol added a comment to D5092: [services] Backup - Blob Get Client - Refactor get initialize.
In D5092#150546, @tomek wrote:

Please update the Result type

Sep 19 2022, 7:14 AM
karol added inline comments to D5091: [services] Backup - Blob Get Client - Refactor get read.
Sep 19 2022, 7:13 AM
karol added inline comments to D5068: [services] Rust Integration - c++ - Add worker.
Sep 19 2022, 2:59 AM
karol updated the diff for D5093: [services] Backup - Blob Get Client - Refactor put terminate.

update

Sep 19 2022, 1:31 AM
karol added inline comments to D5093: [services] Backup - Blob Get Client - Refactor put terminate.
Sep 19 2022, 1:29 AM
karol added inline comments to D5090: [services] Backup - Blob Get Client - Refactor get terminate.
Sep 19 2022, 1:16 AM
karol updated the diff for D5090: [services] Backup - Blob Get Client - Refactor get terminate.

remove commented code

Sep 19 2022, 1:16 AM
karol closed D5089: [services] Backup - Blob Get Client - Prepare for error handling.
Sep 19 2022, 1:12 AM
karol closed D5074: [services] Rust Integration - Backup - c++ - Fix wrong order of attachment holders in tests.
Sep 19 2022, 1:12 AM
karol committed rCOMM246f985561db: [services] Rust Integration - Backup - c++ - Fix wrong order of attachment… (authored by karol).
[services] Rust Integration - Backup - c++ - Fix wrong order of attachment…
Sep 19 2022, 1:12 AM
karol committed rCOMM005bd9ece94e: [services] Backup - Blob Get Client - Prepare for error handling (authored by karol).
[services] Backup - Blob Get Client - Prepare for error handling
Sep 19 2022, 1:12 AM
karol closed D5072: [services] Rust Integration - Backup - Rust - Fix wrong order of logs in the tests.
Sep 19 2022, 1:11 AM
karol closed D5073: [services] Rust Integration - Backup - c++ - Use uuid instead of current timestamp when generating log id.
Sep 19 2022, 1:11 AM
karol closed D5071: [services] Rust Integration - c++ - Implement worker in write reactor.
Sep 19 2022, 1:11 AM
karol committed rCOMMdbfcccb47cf6: [services] Rust Integration - Backup - c++ - Use uuid instead of current… (authored by karol).
[services] Rust Integration - Backup - c++ - Use uuid instead of current…
Sep 19 2022, 1:11 AM
karol committed rCOMM82f40e12ac63: [services] Rust Integration - c++ - Implement worker in write reactor (authored by karol).
[services] Rust Integration - c++ - Implement worker in write reactor
Sep 19 2022, 1:11 AM
karol committed rCOMM9c57479adedf: [services] Rust Integration - Backup - Rust - Fix wrong order of logs in the… (authored by karol).
[services] Rust Integration - Backup - Rust - Fix wrong order of logs in the…
Sep 19 2022, 1:11 AM
karol closed D5070: [services] Rust Integration - c++ - Implement worker in read reactor.
Sep 19 2022, 1:11 AM
karol closed D5069: [services] Rust Integration - c++ - Implement worker in bidi reactor.
Sep 19 2022, 1:11 AM
karol committed rCOMM2945eea1616b: [services] Rust Integration - c++ - Implement worker in bidi reactor (authored by karol).
[services] Rust Integration - c++ - Implement worker in bidi reactor
Sep 19 2022, 1:11 AM
karol committed rCOMM62f8680c387b: [services] Rust Integration - c++ - Implement worker in read reactor (authored by karol).
[services] Rust Integration - c++ - Implement worker in read reactor
Sep 19 2022, 1:11 AM
karol closed D5068: [services] Rust Integration - c++ - Add worker.
Sep 19 2022, 1:11 AM
karol committed rCOMMc85e03b61e3b: [services] Rust Integration - c++ - Add worker (authored by karol).
[services] Rust Integration - c++ - Add worker
Sep 19 2022, 1:11 AM
karol updated the diff for D5089: [services] Backup - Blob Get Client - Prepare for error handling.

rebase

Sep 19 2022, 1:00 AM
karol updated the diff for D5074: [services] Rust Integration - Backup - c++ - Fix wrong order of attachment holders in tests.

rebase

Sep 19 2022, 1:00 AM
karol updated the diff for D5073: [services] Rust Integration - Backup - c++ - Use uuid instead of current timestamp when generating log id.

rebase

Sep 19 2022, 12:59 AM
karol updated the diff for D5072: [services] Rust Integration - Backup - Rust - Fix wrong order of logs in the tests.

rebase

Sep 19 2022, 12:58 AM
karol updated the diff for D5071: [services] Rust Integration - c++ - Implement worker in write reactor.

rebase

Sep 19 2022, 12:58 AM
karol updated the diff for D5070: [services] Rust Integration - c++ - Implement worker in read reactor.

rebase

Sep 19 2022, 12:57 AM
karol updated the diff for D5069: [services] Rust Integration - c++ - Implement worker in bidi reactor.

rebase

Sep 19 2022, 12:57 AM
karol updated the diff for D5068: [services] Rust Integration - c++ - Add worker.

rebase

Sep 19 2022, 12:54 AM
karol added inline comments to D5068: [services] Rust Integration - c++ - Add worker.
Sep 19 2022, 12:49 AM
karol added inline comments to D5074: [services] Rust Integration - Backup - c++ - Fix wrong order of attachment holders in tests.
Sep 19 2022, 12:35 AM

Sep 16 2022

karol accepted D5153: [Backup] Use only one tokio runtime.

nice catch

Sep 16 2022, 2:51 AM
karol closed D5112: [services] Rust Integration - c++ - Add getNumberOfCores.
Sep 16 2022, 1:55 AM
karol committed rCOMM4486a9c39522: [services] Rust Integration - c++ - Add getNumberOfCores (authored by karol).
[services] Rust Integration - c++ - Add getNumberOfCores
Sep 16 2022, 1:55 AM
karol closed D5038: [services] Rust Integration - Backup - c++ - Multiple get clients.
Sep 16 2022, 1:55 AM
karol committed rCOMM14039f468bb9: [services] Rust Integration - Backup - c++ - Multiple get clients (authored by karol).
[services] Rust Integration - Backup - c++ - Multiple get clients
Sep 16 2022, 1:55 AM
karol closed D5037: [services] Rust Integration - Backup - Rust - Multiple get clients.
Sep 16 2022, 1:55 AM
karol committed rCOMM7143223f7246: [services] Rust Integration - Backup - Rust - Multiple get clients (authored by karol).
[services] Rust Integration - Backup - Rust - Multiple get clients
Sep 16 2022, 1:55 AM
karol closed D5036: [services] Rust Integration - Backup - c++ - Multiple put clients.
Sep 16 2022, 1:55 AM
karol committed rCOMM26475982e7b9: [services] Rust Integration - Backup - c++ - Multiple put clients (authored by karol).
[services] Rust Integration - Backup - c++ - Multiple put clients
Sep 16 2022, 1:54 AM
karol closed D5035: [services] Rust Integration - Backup - Rust - Multiple put clients.
Sep 16 2022, 1:54 AM
karol committed rCOMM1a07b32b94a7: [services] Rust Integration - Backup - Rust - Multiple put clients (authored by karol).
[services] Rust Integration - Backup - Rust - Multiple put clients
Sep 16 2022, 1:54 AM
karol updated the diff for D5112: [services] Rust Integration - c++ - Add getNumberOfCores.

rebase

Sep 16 2022, 1:54 AM
karol updated the diff for D5038: [services] Rust Integration - Backup - c++ - Multiple get clients.

rebase

Sep 16 2022, 1:54 AM
karol updated the diff for D5037: [services] Rust Integration - Backup - Rust - Multiple get clients.

rebase

Sep 16 2022, 1:53 AM
karol updated the diff for D5036: [services] Rust Integration - Backup - c++ - Multiple put clients.

rebase

Sep 16 2022, 1:53 AM
karol updated the diff for D5035: [services] Rust Integration - Backup - Rust - Multiple put clients.

rebase

Sep 16 2022, 1:53 AM
karol updated the diff for D5112: [services] Rust Integration - c++ - Add getNumberOfCores.

1u

Sep 16 2022, 1:50 AM
karol added inline comments to D5112: [services] Rust Integration - c++ - Add getNumberOfCores.
Sep 16 2022, 1:49 AM
karol retitled D5112: [services] Rust Integration - c++ - Add getNumberOfCores from [services] Rust Integration - c++ - Add getNumberOfCpus to [services] Rust Integration - c++ - Add getNumberOfCores.
Sep 16 2022, 1:47 AM
karol added inline comments to D5037: [services] Rust Integration - Backup - Rust - Multiple get clients.
Sep 16 2022, 1:45 AM
karol added a comment to D5037: [services] Rust Integration - Backup - Rust - Multiple get clients.

Also the CI fails for this diff.

Sep 16 2022, 1:45 AM

Sep 15 2022

karol added a comment to D5090: [services] Backup - Blob Get Client - Refactor get terminate.
In D5090#150521, @tomek wrote:

It would be really helpful if you provided a context behind introducing _new functions.

Sep 15 2022, 9:21 AM
karol updated the diff for D5099: [services] Backup - Blob Get Client - Pass rust string instead of const char*.

remove tools

Sep 15 2022, 9:17 AM
karol updated the diff for D5089: [services] Backup - Blob Get Client - Prepare for error handling.

fix formatting

Sep 15 2022, 9:16 AM
karol updated the diff for D5074: [services] Rust Integration - Backup - c++ - Fix wrong order of attachment holders in tests.

format

Sep 15 2022, 9:15 AM
karol updated the diff for D5037: [services] Rust Integration - Backup - Rust - Multiple get clients.

format

Sep 15 2022, 9:13 AM
karol added a comment to D5089: [services] Backup - Blob Get Client - Prepare for error handling.

I agree about the code formatting.

Sep 15 2022, 9:10 AM
karol added a comment to D5089: [services] Backup - Blob Get Client - Prepare for error handling.
In D5089#150511, @tomek wrote:

feel like the linting stuff should have been applied to the respective revisions. Also feel like the "create more revisions to apply feedback" is creating more churn for everyone, instead of applying the feedback in the original revision, then doing a rebase after applying the feedback.

Strongly agree!

Sep 15 2022, 9:10 AM
karol added inline comments to D5068: [services] Rust Integration - c++ - Add worker.
Sep 15 2022, 9:02 AM
karol updated the diff for D5071: [services] Rust Integration - c++ - Implement worker in write reactor.

rebase

Sep 15 2022, 9:00 AM
karol updated the diff for D5070: [services] Rust Integration - c++ - Implement worker in read reactor.

rebase

Sep 15 2022, 9:00 AM
karol updated the diff for D5069: [services] Rust Integration - c++ - Implement worker in bidi reactor.

rebase

Sep 15 2022, 8:59 AM
karol updated the diff for D5068: [services] Rust Integration - c++ - Add worker.

address feeedback

Sep 15 2022, 8:59 AM
karol planned changes to D5070: [services] Rust Integration - c++ - Implement worker in read reactor.
Sep 15 2022, 8:57 AM
karol added inline comments to D5069: [services] Rust Integration - c++ - Implement worker in bidi reactor.
Sep 15 2022, 8:57 AM
karol added inline comments to D5068: [services] Rust Integration - c++ - Add worker.
Sep 15 2022, 8:49 AM
karol added inline comments to D5016: [services] Backup - Blob Get Client - Add terminate.
Sep 15 2022, 6:47 AM
karol requested review of D5074: [services] Rust Integration - Backup - c++ - Fix wrong order of attachment holders in tests.
Sep 15 2022, 3:13 AM