Paths

Table of Contentst

-
services/backup/
-
backup/
-
blob_client/src/
-
src/
-
put_client.rs
-
src/Reactors/server/
-
Reactors/
-
server/
-
CreateNewBackupReactor.cpp

[services] Backup - Connect to Blob - Implement CreateNewBackup
AbandonedPublic
Actions

Authored by • karol on Aug 29 2022, 1:39 AM.

Details

Reviewers

• jon
tomek
varun
• max

Summary

Depends on D4974

Implement using the blob client in the "create new backup" operation in c++.

Test Plan

cd services
yarn run-integration-tests backup

The part for creating a new backup should work.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Aug 29 2022, 1:39 AM

Herald added a reviewer: • jon. · View Herald TranscriptAug 29 2022, 1:39 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

• karol edited the summary of this revision. (Show Details)Aug 29 2022, 1:48 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, varun, • max.

• karol added a parent revision: D4974: [services] Backup - Connect to Blob - Rust - Get rid of expect.

Harbormaster completed remote builds in B11667: Diff 16043.Aug 29 2022, 1:49 AM

• karol requested review of this revision.Aug 29 2022, 1:49 AM

This diff contains a lot of changes that should be made in diff that introduced the relevant parts. Could you move it there, so that the code is correct from the beginning? (Most of those changes are unrelated to the main content of this diff)

services/backup/blob_client/src/put_client.rs
65	Isn't it the case that we will always panic in this function?
71	We should update the string in the diff that introduced it
98	Shouldn't we do this in the original diff?
187–189	This should be included in the diff that introduced this code
services/backup/src/Reactors/server/CreateNewBackupReactor.cpp
75–79	Do we have a task for the proper solution?
90–94	It might be a good idea to have a function that does that. Also, why `stoi` isn't used instead?
114	Could you declare an enum for `0`, `1` and `2` so that it is more readable?

This revision now requires changes to proceed.Aug 29 2022, 5:52 AM

• karol added inline comments.Sep 1 2022, 1:02 AM

services/backup/src/Reactors/server/CreateNewBackupReactor.cpp
75–79	https://linear.app/comm/issue/ENG-1724/solve-the-problem-with-blocked-reactors-in-grpc

Abandoning this stack in favor of the new one that starts @ D5002.

All the comments have been either addressed inline or in the new stack.

Revision Contents
Changeset List

Path

Size

services/

backup/

blob_client/

src/

put_client.rs

28 lines

src/

Reactors/

server/

CreateNewBackupReactor.cpp

69 lines

Diff 16043

View Options

services/backup/blob_client/src/put_client.rs

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines	SQL`

CREATE TABLE sessions (		CREATE TABLE sessions (
id bigint(20) NOT NULL,		id bigint(20) NOT NULL,
user bigint(20) NOT NULL,		user bigint(20) NOT NULL,
cookie bigint(20) NOT NULL,		cookie bigint(20) NOT NULL,
query json NOT NULL,		query json NOT NULL,
creation_time bigint(20) NOT NULL,		creation_time bigint(20) NOT NULL,
last_update bigint(20) NOT NULL,		last_update bigint(20) NOT NULL,
last_validated bigint(20) NOT NULL		last_validated bigint(20) NOT NULL,
		public_key char(116) DEFAULT NULL
) ENGINE=InnoDB DEFAULT CHARSET=latin1;		) ENGINE=InnoDB DEFAULT CHARSET=latin1;

CREATE TABLE threads (		CREATE TABLE threads (
id bigint(20) NOT NULL,		id bigint(20) NOT NULL,
type tinyint(3) NOT NULL,		type tinyint(3) NOT NULL,
name varchar(191) COLLATE utf8mb4_bin DEFAULT NULL,		name varchar(191) COLLATE utf8mb4_bin DEFAULT NULL,
description mediumtext COLLATE utf8mb4_bin,		description mediumtext COLLATE utf8mb4_bin,
parent_thread_id bigint(20) DEFAULT NULL,		parent_thread_id bigint(20) DEFAULT NULL,
Show All 30 Lines	SQL`
secret varchar(255) NOT NULL,		secret varchar(255) NOT NULL,
creation_time bigint(20) NOT NULL,		creation_time bigint(20) NOT NULL,
extra json DEFAULT NULL		extra json DEFAULT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8;		) ENGINE=InnoDB DEFAULT CHARSET=utf8;

CREATE TABLE users (		CREATE TABLE users (
id bigint(20) NOT NULL,		id bigint(20) NOT NULL,
username varchar(${usernameMaxLength}) COLLATE utf8mb4_bin NOT NULL,		username varchar(${usernameMaxLength}) COLLATE utf8mb4_bin NOT NULL,
hash char(60) COLLATE utf8mb4_bin DEFAULT NULL,		hash char(60) COLLATE utf8mb4_bin NOT NULL,
avatar varchar(191) COLLATE utf8mb4_bin DEFAULT NULL,		avatar varchar(191) COLLATE utf8mb4_bin DEFAULT NULL,
creation_time bigint(20) NOT NULL		creation_time bigint(20) NOT NULL,
		public_key char(116) DEFAULT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin;		) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin;

CREATE TABLE relationships_undirected (		CREATE TABLE relationships_undirected (
user1 bigint(20) NOT NULL,		user1 bigint(20) NOT NULL,
user2 bigint(20) NOT NULL,		user2 bigint(20) NOT NULL,
status tinyint(1) UNSIGNED NOT NULL		status tinyint(1) UNSIGNED NOT NULL
) ENGINE=InnoDB DEFAULT CHARSET=latin1;		) ENGINE=InnoDB DEFAULT CHARSET=latin1;

▲ Show 20 Lines • Show All 85 Lines • ▼ Show 20 Lines	SQL`
ADD KEY entry (entry);		ADD KEY entry (entry);

ALTER TABLE roles		ALTER TABLE roles
ADD PRIMARY KEY (id),		ADD PRIMARY KEY (id),
ADD KEY thread (thread);		ADD KEY thread (thread);

ALTER TABLE sessions		ALTER TABLE sessions
ADD PRIMARY KEY (id),		ADD PRIMARY KEY (id),
ADD KEY user (user);		ADD KEY user (user),
		ADD UNIQUE INDEX public_key (public_key);

ALTER TABLE threads		ALTER TABLE threads
ADD PRIMARY KEY (id),		ADD PRIMARY KEY (id),
ADD INDEX parent_thread_id (parent_thread_id),		ADD INDEX parent_thread_id (parent_thread_id),
ADD INDEX containing_thread_id (containing_thread_id),		ADD INDEX containing_thread_id (containing_thread_id),
ADD INDEX community (community);		ADD INDEX community (community);

ALTER TABLE updates		ALTER TABLE updates
ADD PRIMARY KEY (id),		ADD PRIMARY KEY (id),
ADD INDEX user_time (user,time),		ADD INDEX user_time (user,time),
ADD INDEX target_time (target, time),		ADD INDEX target_time (target, time),
ADD INDEX user_key_target_type_time (user, \`key\`, target, type, time),		ADD INDEX user_key_target_type_time (user, \`key\`, target, type, time),
ADD INDEX user_key_type_time (user, \`key\`, type, time),		ADD INDEX user_key_type_time (user, \`key\`, type, time),
ADD INDEX user_key_time (user, \`key\`, time);		ADD INDEX user_key_time (user, \`key\`, time);

ALTER TABLE uploads		ALTER TABLE uploads
ADD PRIMARY KEY (id),		ADD PRIMARY KEY (id),
ADD INDEX container (container);		ADD INDEX container (container);

ALTER TABLE users		ALTER TABLE users
ADD PRIMARY KEY (id),		ADD PRIMARY KEY (id),
ADD UNIQUE KEY username (username);		ADD UNIQUE KEY username (username),
		ADD UNIQUE INDEX public_key (public_key);

ALTER TABLE relationships_undirected		ALTER TABLE relationships_undirected
ADD UNIQUE KEY user1_user2 (user1,user2),		ADD UNIQUE KEY user1_user2 (user1,user2),
ADD UNIQUE KEY user2_user1 (user2,user1);		ADD UNIQUE KEY user2_user1 (user2,user1);

ALTER TABLE relationships_directed		ALTER TABLE relationships_directed
ADD UNIQUE KEY user1_user2 (user1,user2),		ADD UNIQUE KEY user1_user2 (user1,user2),
ADD UNIQUE KEY user2_user1 (user2,user1);		ADD UNIQUE KEY user2_user1 (user2,user1);
▲ Show 20 Lines • Show All 87 Lines • Show Last 20 Lines