Depends on D4944
I discovered that I can just use Result in Rust and catch std::exception in c++
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/backup/blob_client/src/put_client.rs | ||
|---|---|---|
| 114 ↗ | (On Diff #15922) | Why do we assign here? Can't we just return the value? https://docs.rs/tokio/latest/tokio/runtime/struct.Runtime.html#method.block_on
|
| 149 ↗ | (On Diff #15922) | Why this function doesn't need to call check_error? |
Comment Actions
update
| services/backup/blob_client/src/put_client.rs | ||
|---|---|---|
| 114 ↗ | (On Diff #15922) | This is nice, but we should assign since we have to reassign client.rx in the end eventually. So, if we wanted to return from the block_on, we'd have to have an internal variable in the async block anyway. |
| 149 ↗ | (On Diff #15922) | It should call it |
Comment Actions
Abandoning this stack in favor of the new one that starts @ D5002.
All the comments have been either addressed inline or in the new stack.