Paths

Table of Contentst

Differential D4972

[services] Backup - Connect to Blob - Use vector of bytes instead of String for data chunks
AbandonedPublic
Actions

Authored by • karol on Aug 29 2022, 1:38 AM.

Tags

None

Referenced Files

	F3773284: D4972.diff
	Sun, Jan 12, 8:32 PM

	Unknown Object (File)
	Thu, Jan 9, 5:59 AM

	Unknown Object (File)
	Mon, Jan 6, 11:07 AM

	Unknown Object (File)
	Sat, Jan 4, 7:22 PM

	Unknown Object (File)
	Fri, Dec 27, 5:39 AM

	Unknown Object (File)
	Fri, Dec 27, 5:39 AM

	Unknown Object (File)
	Fri, Dec 27, 5:30 AM

	Unknown Object (File)
	Sun, Dec 15, 1:07 AM

View All 59 Files

Subscribers

Details

Reviewers

• jon
tomek
varun

Summary

Depends on D4946

Ad data chunks may be any bytes, not only utf8 or something, we should store them in the vectors of bytes, not in strings (it's not c++ where std::string is able to store any bytes).

Test Plan

you could try to send some non-utf-8 bytes and see what happens. I didn't have time to do this and this diff is more based on my prior experiences and is more "preventing".

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Aug 29 2022, 1:38 AM

Herald added a reviewer: • jon. · View Herald TranscriptAug 29 2022, 1:38 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

• karol edited the summary of this revision. (Show Details)Aug 29 2022, 1:45 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, varun.

• karol added a parent revision: D4946: [DRAFT] [services] Backup - Connect to Blob - Update put client.

• karol added a child revision: D4973: [services] Backup - Connect to Blob - Rust - Get rid of unwrap.

Harbormaster completed remote builds in B11664: Diff 16040.Aug 29 2022, 1:48 AM

• karol requested review of this revision.Aug 29 2022, 1:48 AM

I didn't have time to do this and this diff

If you have a way of verifying that the code works, it should be quick to modify it to send non-utf8. If you don't have that, you should create it.

This revision now requires changes to proceed.Aug 29 2022, 5:20 AM

Abandoning this stack in favor of the new one that starts @ D5002.

All the comments have been either addressed inline or in the new stack.

Revision Contents
Changeset List

Path

Size

services/

backup/

blob_client/

src/

16 lines

Diff 16040

services/backup/blob_client/src/put_client.rs

Loading...