Page MenuHomePhabricator

[DRAFT] [services] Blob - check for holder/hash presence in terminate callback
ClosedPublic

Authored by karol on Aug 24 2022, 5:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 14, 12:32 AM
Unknown Object (File)
Sun, May 26, 7:53 PM
Unknown Object (File)
Sun, May 26, 7:53 PM
Unknown Object (File)
Sun, May 26, 7:53 PM
Unknown Object (File)
Sun, May 26, 7:52 PM
Unknown Object (File)
Sun, May 26, 7:49 PM
Unknown Object (File)
May 6 2024, 7:16 PM
Unknown Object (File)
May 2 2024, 1:42 PM

Details

Summary

Depends on D4942

We want to check if the mandatory fields are present in terminateCallback, because we cannot know whether the client will not just terminate the connection. In such a case, we should identify the first error that prevented the reactor from working properly.

Test Plan

Test plan in D4946

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

karol retitled this revision from [services] Blob - check for holder/hash presence in terminate callback to [DRAFT] [services] Blob - check for holder/hash presence in terminate callback.Aug 24 2022, 6:02 AM
karol edited the summary of this revision. (Show Details)
karol edited the test plan for this revision. (Show Details)
karol added a reviewer: tomek.
This revision is now accepted and ready to land.Aug 29 2022, 4:31 AM
This revision was landed with ongoing or failed builds.Sep 1 2022, 3:40 AM
This revision was automatically updated to reflect the committed changes.