[DRAFT] [services] Blob - check for holder/hash presence in terminate callback
ClosedPublic
Actions

Authored by • karol on Aug 24 2022, 5:56 AM.

Details

Reviewers

tomek
• jon

Commits

rCOMM1f3284f61889: [DRAFT] [services] Blob - check for holder/hash presence in terminate callback

Summary

Depends on D4942

We want to check if the mandatory fields are present in terminateCallback, because we cannot know whether the client will not just terminate the connection. In such a case, we should identify the first error that prevented the reactor from working properly.

Test Plan

Test plan in D4946

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Aug 24 2022, 5:56 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptAug 24 2022, 5:56 AM

• karol retitled this revision from [services] Blob - check for holder/hash presence in terminate callback to [DRAFT] [services] Blob - check for holder/hash presence in terminate callback.Aug 24 2022, 6:02 AM

• karol edited the summary of this revision. (Show Details)

• karol edited the test plan for this revision. (Show Details)

• karol added a reviewer: tomek.

• karol added a parent revision: D4942: [DRAFT] [services] Backup - Connect to Blob - Prepare for bidi stream.

• karol added a child revision: D4944: [DRAFT] [services] Backup - Connect to Blob - add error messages for async errors.

Harbormaster completed remote builds in B11579: Diff 15920.Aug 24 2022, 6:07 AM

• karol requested review of this revision.Aug 24 2022, 6:07 AM

tomek accepted this revision.Aug 29 2022, 4:31 AM

This revision is now accepted and ready to land.Aug 29 2022, 4:31 AM

Herald added a reviewer: • jon. · View Herald TranscriptAug 29 2022, 4:31 AM

cherry pick to master

• karol removed a parent revision: D4942: [DRAFT] [services] Backup - Connect to Blob - Prepare for bidi stream.Sep 1 2022, 3:40 AM