Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/backup/blob_client/src/put_client.rs | ||
|---|---|---|
| 141–144 | Why can't this if be a part of match? | |
| 144–180 | This code is deeply nested and contains a couple of mutable variables. Could you find a way to simplify it? | |
| 157–162 | What about using try_send instead of hanging? | |
| 228–231 | Why this change is here? The code should be formatted in the diff that introduced it. | |
| services/backup/blob_client/src/put_client.rs | ||
|---|---|---|
| 157–162 | Yes, good idea! | |
Comment Actions
Abandoning this stack in favor of the new one that starts @ D5002.
All the comments have been either addressed inline or in the new stack.