Paths

Table of Contentst

Differential D4974

[services] Backup - Connect to Blob - Rust - Get rid of expect
AbandonedPublic
Actions

Authored by • karol on Aug 29 2022, 1:39 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jun 18, 11:28 AM

	Unknown Object (File)
	May 2 2024, 1:42 PM

	Unknown Object (File)
	Apr 21 2024, 2:57 PM

	Unknown Object (File)
	Apr 21 2024, 2:57 PM

	Unknown Object (File)
	Apr 21 2024, 2:53 PM

	Unknown Object (File)
	Apr 17 2024, 6:36 PM

	Unknown Object (File)
	Apr 12 2024, 3:10 AM

	Unknown Object (File)
	Apr 9 2024, 12:07 PM

View All 27 Files

Subscribers

Details

Reviewers

• jon
tomek
varun

Summary

Depends on D4973

As suggested in D4870, we should not use expect

Test Plan

Service builds correctly

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Aug 29 2022, 1:39 AM

Herald added a reviewer: • jon. · View Herald TranscriptAug 29 2022, 1:39 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

• karol edited the summary of this revision. (Show Details)Aug 29 2022, 1:47 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, varun.

• karol added a parent revision: D4973: [services] Backup - Connect to Blob - Rust - Get rid of unwrap.

• karol added a child revision: D4975: [services] Backup - Connect to Blob - Implement CreateNewBackup.

Harbormaster completed remote builds in B11666: Diff 16042.Aug 29 2022, 1:49 AM

• karol requested review of this revision.Aug 29 2022, 1:49 AM

• karol mentioned this in D4870: [services] Backup - Rust lib - Add terminate.Aug 29 2022, 2:24 AM

This diff increases the indentation by a lot. Could you find a way to refactor the code? (using e.g. early exits, match statements, etc.)

services/backup/blob_client/src/put_client.rs
47–59	This can be simplified to be a single match
66	Do we really want to always execute `error!("could not access error messages")` code? Was this behavior tested?
87–88	Can we return a value from `block_on`?
119–121

This revision now requires changes to proceed.Aug 29 2022, 5:41 AM

• karol mentioned this in D4942: [DRAFT] [services] Backup - Connect to Blob - Prepare for bidi stream.Aug 29 2022, 5:50 AM

Abandoning this stack in favor of the new one that starts @ D5002.

All the comments have been either addressed inline or in the new stack.

Revision Contents
Changeset List

Path

Size

services/

backup/

blob_client/

src/

326 lines

Diff 16042

services/backup/blob_client/src/put_client.rs

Loading...