[DRAFT] [services] Backup - Connect to Blob - Use Result
AbandonedPublic
Actions

Authored by • karol on Aug 24 2022, 5:57 AM.

Details

Reviewers

varun
tomek
• jon

Summary

Depends on D4944

I discovered that I can just use Result in Rust and catch std::exception in c++

Test Plan

Test plan in D4946

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Aug 24 2022, 5:57 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptAug 24 2022, 5:57 AM

• karol retitled this revision from [services] Backup - Connect to Blob - Use Result to [DRAFT] [services] Backup - Connect to Blob - Use Result.Aug 24 2022, 6:04 AM

• karol edited the summary of this revision. (Show Details)

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: varun, tomek.

• karol added a parent revision: D4944: [DRAFT] [services] Backup - Connect to Blob - add error messages for async errors.

• karol added a child revision: D4946: [DRAFT] [services] Backup - Connect to Blob - Update put client.

Harbormaster completed remote builds in B11581: Diff 15922.Aug 24 2022, 6:08 AM

• karol requested review of this revision.Aug 24 2022, 6:08 AM

tomek requested changes to this revision.Aug 29 2022, 4:59 AM

tomek added inline comments.

services/backup/blob_client/src/put_client.rs
114	Why do we assign here? Can't we just return the value? https://docs.rs/tokio/latest/tokio/runtime/struct.Runtime.html#method.block_on This runs the given future on the current thread, blocking until it is complete, and yielding its resolved result.
149	Why this function doesn't need to call `check_error`?

This revision now requires changes to proceed.Aug 29 2022, 4:59 AM

Herald added a reviewer: • jon. · View Herald TranscriptAug 29 2022, 4:59 AM

update

services/backup/blob_client/src/put_client.rs
114	This is nice, but we should assign since we have to reassign `client.rx` in the end eventually. So, if we wanted to return from the `block_on`, we'd have to have an internal variable in the async block anyway.
149	It should call it