Depends on D4974
Implement using the blob client in the "create new backup" operation in c++.
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
This diff contains a lot of changes that should be made in diff that introduced the relevant parts. Could you move it there, so that the code is correct from the beginning? (Most of those changes are unrelated to the main content of this diff)
| services/backup/blob_client/src/put_client.rs | ||
|---|---|---|
| 65 | Isn't it the case that we will always panic in this function? | |
| 71 | We should update the string in the diff that introduced it | |
| 98 | Shouldn't we do this in the original diff? | |
| 187–189 | This should be included in the diff that introduced this code | |
| services/backup/src/Reactors/server/CreateNewBackupReactor.cpp | ||
| 75–79 | Do we have a task for the proper solution? | |
| 90–94 | It might be a good idea to have a function that does that. Also, why stoi isn't used instead? | |
| 114 | Could you declare an enum for 0, 1 and 2 so that it is more readable? | |
| services/backup/src/Reactors/server/CreateNewBackupReactor.cpp | ||
|---|---|---|
| 75–79 | ||
Comment Actions
Abandoning this stack in favor of the new one that starts @ D5002.
All the comments have been either addressed inline or in the new stack.