Page MenuHomePhorge
Feed Search

Sep 12 2022

jakub requested review of D5110: [web] Fix warning - set readOnly param to EnumSettingOption radio.
Sep 12 2022, 1:05 PM

Sep 9 2022

jakub updated the diff for D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.

Change if condition to alternative form

Sep 9 2022, 12:10 PM
jakub closed D4939: [web] Add fake pending thread during chat creation.
Sep 9 2022, 12:03 PM
jakub committed rCOMM34623ec353e4: [web] Add fake pending thread during chat creation.
Sep 9 2022, 12:03 PM
jakub updated the diff for D4939: [web] Add fake pending thread during chat creation.

Rebase before landing

Sep 9 2022, 11:52 AM
jakub updated the diff for D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.

Changing useMemo to useCallback

Sep 9 2022, 11:39 AM

Sep 8 2022

jakub updated the diff for D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.

Change empty string to null, return newThreadID to the previous position and add
conditional callback for onClick

Sep 8 2022, 3:16 PM
jakub updated the diff for D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.

Rebase

Sep 8 2022, 1:35 PM
jakub updated the diff for D4939: [web] Add fake pending thread during chat creation.

Rebase

Sep 8 2022, 1:33 PM
jakub added inline comments to D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.
Sep 8 2022, 11:18 AM

Sep 1 2022

jakub added a comment to D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.

I changed both behaviours. Now, after clicking on active thread in create mode, app keeps focused on it and ThreadComposer doesn't close.
I also considered using a css class with pointer-event: none property instead to dynamically disable onClick event, but this solution has an impact on children pointer-events, so it could be problematic (e.g. onClick on ChatThreadListItemMenu)

Sep 1 2022, 2:41 PM
jakub updated the diff for D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.

Change thread behaviour and refactor logic in nav-selectors.js

Sep 1 2022, 2:40 PM

Aug 31 2022

jakub requested review of D4939: [web] Add fake pending thread during chat creation.
Aug 31 2022, 1:37 PM
jakub updated the diff for D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.

Memoize onClick callback and change enum value names

Aug 31 2022, 10:03 AM
jakub added inline comments to D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.
Aug 31 2022, 9:53 AM

Aug 30 2022

jakub added inline comments to D4939: [web] Add fake pending thread during chat creation.
Aug 30 2022, 9:09 AM

Aug 29 2022

jakub updated the diff for D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.

Updating diff after resolving conflicts

Aug 29 2022, 1:59 PM
jakub updated the diff for D4939: [web] Add fake pending thread during chat creation.

Removing unnecessary props and set name param as createPendingThread argument

Aug 29 2022, 1:57 PM
jakub added inline comments to D4939: [web] Add fake pending thread during chat creation.
Aug 29 2022, 11:37 AM
jakub updated the diff for D4939: [web] Add fake pending thread during chat creation.

Changing useRef to useMemo

Aug 29 2022, 9:44 AM
jakub added inline comments to D4939: [web] Add fake pending thread during chat creation.
Aug 29 2022, 9:43 AM
jakub added inline comments to D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.
Aug 29 2022, 4:26 AM

Aug 26 2022

jakub added inline comments to D4939: [web] Add fake pending thread during chat creation.
Aug 26 2022, 12:34 PM
jakub updated the test plan for D4939: [web] Add fake pending thread during chat creation.
Aug 26 2022, 8:03 AM

Aug 25 2022

jakub updated the diff for D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.

Change boolean to enum and fix bug related to onClick on fake pending "New
thread"

Aug 25 2022, 9:59 AM
jakub added inline comments to D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.
Aug 25 2022, 9:24 AM

Aug 24 2022

jakub added a reviewer for D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer: atul.
Aug 24 2022, 11:38 AM
jakub added a reviewer for D4939: [web] Add fake pending thread during chat creation: atul.
Aug 24 2022, 11:38 AM
jakub updated the summary of D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.
Aug 24 2022, 11:19 AM
jakub updated the summary of D4939: [web] Add fake pending thread during chat creation.
Aug 24 2022, 10:21 AM
jakub requested review of D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.
Aug 24 2022, 9:15 AM
jakub requested review of D4939: [web] Add fake pending thread during chat creation.
Aug 24 2022, 8:38 AM
jakub closed D4792: [Native] Fix uploading images transition.
Aug 24 2022, 8:14 AM
jakub committed rCOMM9e6af893cb11: [Native] Fix uploading images transition.
Aug 24 2022, 8:14 AM

Aug 23 2022

jakub updated the diff for D4792: [Native] Fix uploading images transition.

Rebase before landing

Aug 23 2022, 4:16 PM

Aug 17 2022

jakub added inline comments to D4792: [Native] Fix uploading images transition.
Aug 17 2022, 9:32 AM
jakub added inline comments to D4544: [services] Backup - Add function to get utf8 string length.
Aug 17 2022, 9:31 AM

Aug 12 2022

jakub updated the diff for D4792: [Native] Fix uploading images transition.

Removing unnecessary style and disabling PanGestureHandler

Aug 12 2022, 9:30 AM

Aug 10 2022

jakub requested review of D4792: [Native] Fix uploading images transition.
Aug 10 2022, 3:00 PM

Jul 27 2022

jakub abandoned D4543: [services] Backup - Add unit test for getUtf8Length.

Abandoning, explained in previous diff D4544

Jul 27 2022, 4:05 PM
jakub abandoned D4544: [services] Backup - Add function to get utf8 string length.
Jul 27 2022, 4:05 PM
jakub added a comment to D4544: [services] Backup - Add function to get utf8 string length.

This function seems to be redundant, because the standard c++ string method "length" or "size" return exact size of string in bytes.
source

Jul 27 2022, 4:04 PM
jakub closed D4504: [services] Backup - Remove unnecessary brackets in unit test.
Jul 27 2022, 2:35 PM
jakub closed D4503: [services] Backup - Fix missing hash in unit tests.
Jul 27 2022, 2:35 PM
jakub committed rCOMM80b0b0f5fb84: [services] Backup - Remove unnecessary brackets in unit test.
Jul 27 2022, 2:35 PM
jakub committed rCOMMfeb0d5a36ecb: [services] Backup - Fix missing hash in unit tests.
Jul 27 2022, 2:35 PM
jakub closed D4502: [services] Backup - Fix unchanged variable names in unit tests scripts.
Jul 27 2022, 2:35 PM
jakub committed rCOMM158b8632d463: [services] Backup - Fix unchanged variable names in unit tests scripts.
Jul 27 2022, 2:35 PM
jakub updated the diff for D4544: [services] Backup - Add function to get utf8 string length.

Rebase

Jul 27 2022, 11:59 AM

Jul 26 2022

jakub retitled D4544: [services] Backup - Add function to get utf8 string length from [services] Backup - Fix function to get utf8 string length
Jul 26 2022, 3:32 PM
jakub abandoned D4505: [services] Backup - Add function to get utf8 string length.
Jul 26 2022, 3:27 PM
jakub updated the diff for D4543: [services] Backup - Add unit test for getUtf8Length.

Replacing random data sets with already generated examples

Jul 26 2022, 2:18 PM
jakub updated the diff for D4544: [services] Backup - Add function to get utf8 string length.

Fix typo in comment

Jul 26 2022, 11:16 AM
jakub updated the diff for D4544: [services] Backup - Add function to get utf8 string length.

Add comment with explanations of getUtf8Length function

Jul 26 2022, 10:54 AM

Jul 20 2022

atul renamed jakub.
Jul 20 2022, 6:31 PM

Jul 15 2022

jakub requested review of D4543: [services] Backup - Add unit test for getUtf8Length.
Jul 15 2022, 12:17 PM
jakub updated the summary of D4544: [services] Backup - Add function to get utf8 string length.
Jul 15 2022, 11:45 AM
jakub requested review of D4544: [services] Backup - Add function to get utf8 string length.
Jul 15 2022, 10:44 AM

Jul 14 2022

jakub added reviewers for D4503: [services] Backup - Fix missing hash in unit tests: tomek, karol.
Jul 14 2022, 9:42 AM

Jul 13 2022

jakub added reviewers for D4504: [services] Backup - Remove unnecessary brackets in unit test: tomek, karol.
Jul 13 2022, 12:11 PM
jakub added reviewers for D4505: [services] Backup - Add function to get utf8 string length: tomek, karol.
Jul 13 2022, 12:10 PM

Jul 12 2022

jakub updated the summary of D4505: [services] Backup - Add function to get utf8 string length.
Jul 12 2022, 9:23 AM
jakub updated the summary of D4505: [services] Backup - Add function to get utf8 string length.
Jul 12 2022, 9:20 AM
jakub updated the test plan for D4502: [services] Backup - Fix unchanged variable names in unit tests scripts.
Jul 12 2022, 9:15 AM
jakub updated the test plan for D4503: [services] Backup - Fix missing hash in unit tests.
Jul 12 2022, 9:14 AM
jakub updated the test plan for D4504: [services] Backup - Remove unnecessary brackets in unit test.
Jul 12 2022, 9:14 AM
jakub updated the summary of D4504: [services] Backup - Remove unnecessary brackets in unit test.
Jul 12 2022, 8:57 AM
jakub updated the summary of D4503: [services] Backup - Fix missing hash in unit tests.
Jul 12 2022, 8:57 AM
jakub updated the summary of D4502: [services] Backup - Fix unchanged variable names in unit tests scripts.
Jul 12 2022, 8:57 AM
jakub requested review of D4505: [services] Backup - Add function to get utf8 string length.
Jul 12 2022, 8:35 AM
jakub requested review of D4504: [services] Backup - Remove unnecessary brackets in unit test.
Jul 12 2022, 8:31 AM
jakub requested review of D4503: [services] Backup - Fix missing hash in unit tests.
Jul 12 2022, 8:30 AM
jakub requested review of D4502: [services] Backup - Fix unchanged variable names in unit tests scripts.
Jul 12 2022, 8:28 AM