Simplified code.
Task for the CI build: ENG-2532
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Dec 29 2022
Dec 23 2022
Dec 22 2022
Dec 20 2022
Dec 19 2022
Rewrote the Squirrel startup logic a bit.
Dec 16 2022
Use yarn clean-build in yarn clean
Dec 15 2022
Yeah
Looks good, but does Windows still need rimraf (from this package) instead of rm -rf? Or do a modern Windows environment handle rm -rf well?
It doesn't handle the -rf unfortunately, but I'm not sure if it's worth it thinking about now. This fix is only required for the macOS builds and there are a lot of other things that won't work on windows (like using && in commands or ENV=dev). If we want all the scripts in desktop to work on windows we should probably use some more general solution (maybe something like this? but I'm not sure about it).
Dec 14 2022
Dec 7 2022
Remove the @electron-forge/maker-zip dependency.
Fix typo and update versions
The bundleID wasn't completely intentional, thanks for noticing. I don't think it would cause problems (apple offers universal purchase which requires the same ID on both iOS and macOS, and we could create a macOS section in the current comm App Store Record), but I don't think there are any advantages for us so I'm changes it to app.comm.macos.
Dec 6 2022
Small changes: add name to the BabelPlugin (it's more clearer what's happening in the stdout during packaging) and simplify ignore pattern to ignore whole folder.
Add comments, change order in .eslintignore
Sorry, I sent the comments by mistake before finishing the inline comment about nohoist and I don't think I can edit it.
electron-forge is a package that handles building, packaging, and code signing. It uses different packages for this (e.g. electron-packager, osx-sign) and provides a unified configuration for them. It's not included in the final application. When you run electron-forge package or some other command it uses forge.config.cjs for configuration.
Dec 5 2022
Nov 22 2022
Add --logo-bg css variable.
Nov 21 2022
Add a comment
Nov 17 2022
Rebase, small fixes
Moved the new css class to the header.
Don't define arrow functions on every render, move the doubleClick callbacks to the <header>.
This revision also fixes two additional issues that I haven't noticed before:
- the onNavigate callback should be set in useEffect, and should be removed in the useEffect returned callback
- the history should be cleared when user logs in/out. Otherwise the navigation arrows behave incorrectly after relogging.
Revert formatting. Sorry, I have format-on-save enabled so the changes were made automatically, but I should have noticed that.
Fix keyserver build
Here's the linear webpack issue, I'm going to focus on it whenever I have the time.
Rename to .cjs, documentation changes and other fixes
Nov 16 2022
Responded to some of the review, left comments for the rest
Nov 15 2022
Nov 9 2022
Split into two diffs
Nov 7 2022
Changed type, changed the definition of the UserListItem.
Some additional notes in the inline comments.
Update
Nov 2 2022
- New task for server-side checks created here
- Reverted changes to the forceAddMembers in the keyserver
- Unifying behaviour between native and web app UI when it comes to the selecting non-friend users will be included in the following diff
@ashoat the native app currently works like this:
- if you try to create a chat with someone you are not friends with, the app exits search and puts you in a 1-1 thread with this user
- if you already have someone selected and you try to add a non-friend the app displays an alert
Don't create the relationship
Rebase, add some padding at the bottom
Oct 25 2022
I think you were added when you requested changes? :)
Rebase
Revert the removal of useEffect
Used other method, without position: absolute. Moved padding-top to margin in nav because otherwise some of the calendar and scrollbar were cutoff at the bottom.
We handle this issue correctly on native (here).
Oct 24 2022
Changed awaits to not use them directly. Now we await in two places:
- await before fetchKnownUserInfos so the relationships are updated
- inside navInfoPromise to get validUserIDs
We don't have to await before calendarQuery because it uses only the startDate and endData fields.
Oct 20 2022
Rebase
Rebase
Update
Fix small issue with RETRY? button.