I feel like we should still reduce the width for viewer-composed multimedia messages so all the multimedia messages have a consistently smaller size,
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Mar 16 2023
Mar 16 2023
Mar 15 2023
Mar 15 2023
fix maxWidth for chat bubble so it's not poking out anymore (see test plan for visulization)
With the red border, is that a parent component of the message box? (Generally I would expect the parent component to enclose the child component.)
Have you made sure that that the height measurement code is still working correctly?
thanks for doing this!
Mar 14 2023
Mar 14 2023
ginsu added a comment to D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
Okay sounds good i'll have an update out shortly with a cleaner syntax
ginsu added inline comments to D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
ginsu updated the summary of D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
ginsu updated the diff for D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
address feedback
address feedback
Mar 13 2023
Mar 13 2023
ginsu added inline comments to D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
ginsu requested review of D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
Mar 10 2023
Mar 10 2023
Mar 9 2023
Mar 9 2023
Not an expert in C++ but your code follows the pattern I used when writing the C++ message spec for reactions. Would be helpful to get a second pair of eyes here
I think we should consider if we also need shimUnsupportedMessageInfo and unshimMessageInfo. These functions will help us support older native clients that haven't been updated yet.
Accepting, but if what I suggested doesn't take too long might be worthwhile to update
Mar 2 2023
Mar 2 2023
rebase before landing
rebase before landing
Mar 1 2023
Mar 1 2023
address feedback
Feb 28 2023
Feb 28 2023
Does D6632 need to be updated so that getEmojiKeyboardPosition no longer looks at emojiKeyboard.getBoundingClientRect()?
I attempted to address the feedback above, but still running into one issue where the node passed through the ref still has a height and width of zero. (I saw this by logging node.getBoundingClientRect() in emojiKeyboardRef
address feedback
Feb 27 2023
Feb 27 2023
Feb 26 2023
Feb 26 2023
rebase before landing
ginsu updated the diff for D6829: [keyserver] convert existing logic for building userPushInfoPromises to an async function called generateNotifUserInfoPromise.
rebase before landing
ginsu updated the diff for D6307: [lib] modify reaction message generatesNotifs function to return a pushType based on the reaction action.
rebase before landing
ginsu updated the diff for D6875: [lib/native/web] switch reactions data structure from map to plain object.
rebase before landing
Feb 25 2023
Feb 25 2023
ginsu retitled D6829: [keyserver] convert existing logic for building userPushInfoPromises to an async function called generateNotifUserInfoPromise from [keyserver] convert existing logic for building userPushInfoPromises to an IIFE called generateNotifUserInfoPromise
ginsu updated the diff for D6829: [keyserver] convert existing logic for building userPushInfoPromises to an async function called generateNotifUserInfoPromise.
address ashoat's comments
ginsu updated the test plan for D6875: [lib/native/web] switch reactions data structure from map to plain object.
ginsu updated the diff for D6875: [lib/native/web] switch reactions data structure from map to plain object.
address ashoat's comments
Feb 23 2023
Feb 23 2023
ginsu requested review of D6875: [lib/native/web] switch reactions data structure from map to plain object.
address ashoats comments
ginsu updated the diff for D6829: [keyserver] convert existing logic for building userPushInfoPromises to an async function called generateNotifUserInfoPromise.
address ashoat's comments
Feb 22 2023
Feb 22 2023