review feedback
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Jul 18 2024
Jul 18 2024
will updated the diff for D12730: [terraform] Ensure that the primary service is running before deploying secondary service.
will updated the diff for D12729: [terraform] Make number of secondary nodes configured by the user.
feedback
review feedback with minimum requirements to land
Jul 17 2024
Jul 17 2024
Going to make turning tunnelbroker url and identity socket address into json objects into a follow up
rebase for landing
will retitled D12725: [terraform] add Tunnelbroker configuration variable to self-host from [terraform] add terraform configuration variable to self-host
rebase
rebase
will added a comment to D12688: [terraform] make aws rds instance class configurable for self-hosting.
In D12688#360458, @ashoat wrote:If you could remind me to make sure I set db.m6g.large when we set up my keyserver, that would be great!
feedback
will updated the summary of D12558: [keyserver] add health check route to keyserver for use by load balancer.
will updated the summary of D12558: [keyserver] add health check route to keyserver for use by load balancer.
rebase
will updated the diff for D12710: [terraform] add authoritative keyserver id as a user-specified variable.
make authoritative id variable a config json object
rebase
configure user credentials as json object variable instead of individual string variables
will added a comment to D12730: [terraform] Ensure that the primary service is running before deploying secondary service.
In D12730#361895, @ashoat wrote:Looks like @will figured out a solution within the bash script in D12731
I think this can be solved with some smart load balancer & network configuration (IIRC there is a way to prioritize health checks traffic in AWS), but I need to research on what's the best way of doing that. I think we can figure it out later.
This sounds like potentially a better solution, but the current solution in D12731 works for now – agree we can address it later. @will maybe you can create a follow-up task before landing to investigate @bartek's proposal here?
will added inline comments to D12725: [terraform] add Tunnelbroker configuration variable to self-host.
review feedback, additional checks and comments
remove timestamp trigger, running only on first rds creation
will updated the test plan for D12475: [keyserver] upgrade redis to version 7 on docker based keyserver.
will updated the test plan for D12475: [keyserver] upgrade redis to version 7 on docker based keyserver.
@bartek thanks for catching that
remove copy of keyserver_secondary.tf from root
feedback. remove unnecessary homebrew install deps script
will updated the diff for D12710: [terraform] add authoritative keyserver id as a user-specified variable.
review feedback
Jul 16 2024
Jul 16 2024
rebase
will updated the diff for D12339: [terraform] Use default vpc, subnets, and internet gateway for self-host.
only create vpc, subnets, and internet gateway if user created option is true
feedback
reduce line count
include logic to disable traffic until all nodes available
create secondary resources after primary
will updated the diff for D12339: [terraform] Use default vpc, subnets, and internet gateway for self-host.
typo
include security group
Jul 12 2024
Jul 12 2024
will updated the summary of D12529: [terraform] Allow all ip addresses to access self-host internet gateway.
No longer needed. Included in prior diff
will updated the diff for D12339: [terraform] Use default vpc, subnets, and internet gateway for self-host.
Add option for user created vpc to avoid migration of prod aws rds instance to new vpc
Jul 11 2024
Jul 11 2024
will planned changes to D12710: [terraform] add authoritative keyserver id as a user-specified variable.