CI
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
All Stories
Sep 30 2025
Sep 29 2025
In D15391#423692, @ashoat wrote:Classic! It probably wouldn't be very hard to start enabling React Compiler for at least some of our codebase
Classic! It probably wouldn't be very hard to start enabling React Compiler for at least some of our codebase
In D15388#423665, @ashoat wrote:In D15388#423651, @tomek wrote:If a user using this version dismisses the Farcaster connection and then connects from the profile tab, they won't see the DCs modal after the public release. This will happen because in shouldSkipConnectFarcasterAlert the alertInfo.totalAlerts will be greater than 0.
I don't follow how that would occur. Did you notice that there are two different alertInfos? If I'm reading the code right, the only way connectFarcasterDCsAlertInfo.totalAlerts will be greater than 0 is if we display the DCs modal.
In D15388#423651, @tomek wrote:If a user using this version dismisses the Farcaster connection and then connects from the profile tab, they won't see the DCs modal after the public release. This will happen because in shouldSkipConnectFarcasterAlert the alertInfo.totalAlerts will be greater than 0.
This might be subtly broken:
If a user using this version dismisses the Farcaster connection and then connects from the profile tab, they won't see the DCs modal after the public release. This will happen because in shouldSkipConnectFarcasterAlert the alertInfo.totalAlerts will be greater than 0.
This has a risk that a non-staff user with a new build would see the "connect Farcaster" alert
Sep 27 2025
Sep 26 2025
Address the review
Tested that, with this diff, text notifs are still delivered on iOS.
Sep 25 2025
Remove unnecessary call