Page MenuHomePhabricator
Feed Advanced Search

Sep 12 2022

jakub requested review of D5110: [web] Fix warning - set readOnly param to EnumSettingOption radio.
Sep 12 2022, 6:05 AM

Sep 9 2022

jakub updated the diff for D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.

Change if condition to alternative form

Sep 9 2022, 5:10 AM
jakub closed D4939: [web] Add fake pending thread during chat creation.
Sep 9 2022, 5:03 AM
jakub committed rCOMM34623ec353e4: [web] Add fake pending thread during chat creation (authored by jakub).
[web] Add fake pending thread during chat creation
Sep 9 2022, 5:03 AM
jakub updated the diff for D4939: [web] Add fake pending thread during chat creation.

Rebase before landing

Sep 9 2022, 4:52 AM
jakub updated the diff for D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.

Changing useMemo to useCallback

Sep 9 2022, 4:39 AM

Sep 8 2022

jakub updated the diff for D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.

Change empty string to null, return newThreadID to the previous position and add
conditional callback for onClick

Sep 8 2022, 8:16 AM
jakub updated the diff for D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.

Rebase

Sep 8 2022, 6:35 AM
jakub updated the diff for D4939: [web] Add fake pending thread during chat creation.

Rebase

Sep 8 2022, 6:33 AM
jakub added inline comments to D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.
Sep 8 2022, 4:18 AM

Sep 1 2022

jakub added a comment to D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.

I changed both behaviours. Now, after clicking on active thread in create mode, app keeps focused on it and ThreadComposer doesn't close.
I also considered using a css class with pointer-event: none property instead to dynamically disable onClick event, but this solution has an impact on children pointer-events, so it could be problematic (e.g. onClick on ChatThreadListItemMenu)

Sep 1 2022, 7:41 AM
jakub updated the diff for D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.

Change thread behaviour and refactor logic in nav-selectors.js

Sep 1 2022, 7:40 AM

Aug 31 2022

jakub requested review of D4939: [web] Add fake pending thread during chat creation.
Aug 31 2022, 6:37 AM
jakub updated the diff for D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.

Memoize onClick callback and change enum value names

Aug 31 2022, 3:03 AM
jakub added inline comments to D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.
Aug 31 2022, 2:53 AM

Aug 30 2022

jakub added inline comments to D4939: [web] Add fake pending thread during chat creation.
Aug 30 2022, 2:09 AM

Aug 29 2022

jakub updated the diff for D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.

Updating diff after resolving conflicts

Aug 29 2022, 6:59 AM
jakub updated the diff for D4939: [web] Add fake pending thread during chat creation.

Removing unnecessary props and set name param as createPendingThread argument

Aug 29 2022, 6:57 AM
jakub added inline comments to D4939: [web] Add fake pending thread during chat creation.
Aug 29 2022, 4:37 AM
jakub updated the diff for D4939: [web] Add fake pending thread during chat creation.

Changing useRef to useMemo

Aug 29 2022, 2:44 AM
jakub added inline comments to D4939: [web] Add fake pending thread during chat creation.
Aug 29 2022, 2:43 AM

Aug 28 2022

jakub added inline comments to D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.
Aug 28 2022, 9:26 PM

Aug 26 2022

jakub added inline comments to D4939: [web] Add fake pending thread during chat creation.
Aug 26 2022, 5:34 AM
jakub updated the test plan for D4939: [web] Add fake pending thread during chat creation.
Aug 26 2022, 1:03 AM

Aug 25 2022

jakub updated the diff for D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.

Change boolean to enum and fix bug related to onClick on fake pending "New
thread"

Aug 25 2022, 2:59 AM
jakub added inline comments to D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.
Aug 25 2022, 2:24 AM

Aug 24 2022

jakub added a reviewer for D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer: atul.
Aug 24 2022, 4:38 AM
jakub added a reviewer for D4939: [web] Add fake pending thread during chat creation: atul.
Aug 24 2022, 4:38 AM
jakub updated the summary of D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.
Aug 24 2022, 4:19 AM
jakub updated the summary of D4939: [web] Add fake pending thread during chat creation.
Aug 24 2022, 3:21 AM
jakub requested review of D4940: [web] Change ThreadList behaviour after hiding ChatThreadComposer.
Aug 24 2022, 2:15 AM
jakub requested review of D4939: [web] Add fake pending thread during chat creation.
Aug 24 2022, 1:38 AM
jakub closed D4792: [Native] Fix uploading images transition.
Aug 24 2022, 1:14 AM
jakub committed rCOMM9e6af893cb11: [Native] Fix uploading images transition (authored by jakub).
[Native] Fix uploading images transition
Aug 24 2022, 1:14 AM

Aug 23 2022

jakub updated the diff for D4792: [Native] Fix uploading images transition.

Rebase before landing

Aug 23 2022, 9:16 AM

Aug 17 2022

jakub added inline comments to D4792: [Native] Fix uploading images transition.
Aug 17 2022, 2:32 AM
jakub added inline comments to D4544: [services] Backup - Add function to get utf8 string length.
Aug 17 2022, 2:31 AM

Aug 12 2022

jakub updated the diff for D4792: [Native] Fix uploading images transition.

Removing unnecessary style and disabling PanGestureHandler

Aug 12 2022, 2:30 AM

Aug 10 2022

jakub requested review of D4792: [Native] Fix uploading images transition.
Aug 10 2022, 8:00 AM

Jul 27 2022

jakub abandoned D4543: [services] Backup - Add unit test for getUtf8Length.

Abandoning, explained in previous diff D4544

Jul 27 2022, 9:05 AM
jakub abandoned D4544: [services] Backup - Add function to get utf8 string length.
Jul 27 2022, 9:05 AM
jakub added a comment to D4544: [services] Backup - Add function to get utf8 string length.

This function seems to be redundant, because the standard c++ string method "length" or "size" return exact size of string in bytes.
source

Jul 27 2022, 9:04 AM
jakub closed D4504: [services] Backup - Remove unnecessary brackets in unit test.
Jul 27 2022, 7:35 AM
jakub closed D4503: [services] Backup - Fix missing hash in unit tests.
Jul 27 2022, 7:35 AM
jakub committed rCOMM80b0b0f5fb84: [services] Backup - Remove unnecessary brackets in unit test (authored by jakub).
[services] Backup - Remove unnecessary brackets in unit test
Jul 27 2022, 7:35 AM
jakub committed rCOMMfeb0d5a36ecb: [services] Backup - Fix missing hash in unit tests (authored by jakub).
[services] Backup - Fix missing hash in unit tests
Jul 27 2022, 7:35 AM
jakub closed D4502: [services] Backup - Fix unchanged variable names in unit tests scripts.
Jul 27 2022, 7:35 AM
jakub committed rCOMM158b8632d463: [services] Backup - Fix unchanged variable names in unit tests scripts (authored by jakub).
[services] Backup - Fix unchanged variable names in unit tests scripts
Jul 27 2022, 7:35 AM
jakub updated the diff for D4544: [services] Backup - Add function to get utf8 string length.

Rebase

Jul 27 2022, 4:59 AM

Jul 26 2022

jakub retitled D4544: [services] Backup - Add function to get utf8 string length from [services] Backup - Fix function to get utf8 string length to [services] Backup - Add function to get utf8 string length.
Jul 26 2022, 8:32 AM
jakub abandoned D4505: [services] Backup - Add function to get utf8 string length.
Jul 26 2022, 8:27 AM
jakub updated the diff for D4543: [services] Backup - Add unit test for getUtf8Length.

Replacing random data sets with already generated examples

Jul 26 2022, 7:18 AM
jakub updated the diff for D4544: [services] Backup - Add function to get utf8 string length.

Fix typo in comment

Jul 26 2022, 4:16 AM
jakub updated the diff for D4544: [services] Backup - Add function to get utf8 string length.

Add comment with explanations of getUtf8Length function

Jul 26 2022, 3:54 AM

Jul 20 2022

atul renamed jakub from jakub-kedra-swm to jakub.
Jul 20 2022, 11:31 AM

Jul 15 2022

jakub requested review of D4543: [services] Backup - Add unit test for getUtf8Length.
Jul 15 2022, 5:17 AM
jakub updated the summary of D4544: [services] Backup - Add function to get utf8 string length.
Jul 15 2022, 4:45 AM
jakub requested review of D4544: [services] Backup - Add function to get utf8 string length.
Jul 15 2022, 3:44 AM

Jul 14 2022

jakub added reviewers for D4503: [services] Backup - Fix missing hash in unit tests: tomek, karol.
Jul 14 2022, 2:42 AM

Jul 13 2022

jakub added reviewers for D4504: [services] Backup - Remove unnecessary brackets in unit test: tomek, karol.
Jul 13 2022, 5:11 AM
jakub added reviewers for D4505: [services] Backup - Add function to get utf8 string length: tomek, karol.
Jul 13 2022, 5:10 AM

Jul 12 2022

jakub updated the summary of D4505: [services] Backup - Add function to get utf8 string length.
Jul 12 2022, 2:23 AM
jakub updated the summary of D4505: [services] Backup - Add function to get utf8 string length.
Jul 12 2022, 2:20 AM
jakub updated the test plan for D4502: [services] Backup - Fix unchanged variable names in unit tests scripts.
Jul 12 2022, 2:15 AM
jakub updated the test plan for D4503: [services] Backup - Fix missing hash in unit tests.
Jul 12 2022, 2:14 AM
jakub updated the test plan for D4504: [services] Backup - Remove unnecessary brackets in unit test.
Jul 12 2022, 2:14 AM
jakub updated the summary of D4504: [services] Backup - Remove unnecessary brackets in unit test.
Jul 12 2022, 1:57 AM
jakub updated the summary of D4503: [services] Backup - Fix missing hash in unit tests.
Jul 12 2022, 1:57 AM
jakub updated the summary of D4502: [services] Backup - Fix unchanged variable names in unit tests scripts.
Jul 12 2022, 1:57 AM
jakub requested review of D4505: [services] Backup - Add function to get utf8 string length.
Jul 12 2022, 1:35 AM
jakub requested review of D4504: [services] Backup - Remove unnecessary brackets in unit test.
Jul 12 2022, 1:31 AM
jakub requested review of D4503: [services] Backup - Fix missing hash in unit tests.
Jul 12 2022, 1:30 AM
jakub requested review of D4502: [services] Backup - Fix unchanged variable names in unit tests scripts.
Jul 12 2022, 1:28 AM