User Details
User Details
- User Since
- Dec 29 2021, 2:54 AM (155 w, 5 d)
Sep 27 2024
Sep 27 2024
marcin committed rCOMM39553e6dfb3a: Implement sending large thick thread notifs (authored by marcin).
Implement sending large thick thread notifs
marcin committed rCOMM51312a1e05f8: Create large notifications in thick threads (authored by marcin).
Create large notifications in thick threads
marcin committed rCOMM0a028741d881: Add AES cryptography to EncryptedNotifUtilsAPI (authored by marcin).
Add AES cryptography to EncryptedNotifUtilsAPI
marcin updated the diff for D13495: Implement sending large thick thread notifs.
rebase
marcin updated the diff for D13469: Create large notifications in thick threads.
Rebase before landing
marcin updated the diff for D13468: Add AES cryptography to EncryptedNotifUtilsAPI.
Rebase
marcin updated the test plan for D13495: Implement sending large thick thread notifs.
marcin updated the test plan for D13469: Create large notifications in thick threads.
marcin updated the test plan for D13468: Add AES cryptography to EncryptedNotifUtilsAPI.
marcin updated the diff for D13495: Implement sending large thick thread notifs.
Rebase before landing
marcin updated the diff for D13469: Create large notifications in thick threads.
Rebase before landing
marcin updated the diff for D13495: Implement sending large thick thread notifs.
address review
marcin added inline comments to D13495: Implement sending large thick thread notifs.
marcin updated the diff for D13469: Create large notifications in thick threads.
Update diff
marcin added inline comments to D13469: Create large notifications in thick threads.
marcin updated the diff for D13495: Implement sending large thick thread notifs.
Send string on native and blob on web.
Sep 26 2024
Sep 26 2024
marcin requested review of D13495: Implement sending large thick thread notifs.
Sorry for the confusion. This differential was supposed to bo abandoned.
Sorry for the confusion. This differential was supposed to bo abandoned.
marcin updated the diff for D13468: Add AES cryptography to EncryptedNotifUtilsAPI.
Update to simpler approach
Sep 25 2024
Sep 25 2024
marcin requested review of D13469: Create large notifications in thick threads.
marcin requested review of D13468: Add AES cryptography to EncryptedNotifUtilsAPI.
marcin added a comment to D13466: Enable AES encryption with custom IV on native.
I am actually starting to question this. While putting those diffs I came up with better idea how to achieve the same effect using just JS. I will try to get on phab tomorrow morning. The idea is to pass to createAPNsVisualNotif and createAndroidVisualNotif a map from stringified unencrypted notification + messageInfo to a promise resolving to its encrypted version and a hash.
marcin requested review of D13467: Enable AES encryption with custom IV on web/keyserver.
marcin requested review of D13466: Enable AES encryption with custom IV on native.
Sep 24 2024
Sep 24 2024
Sep 20 2024
Sep 20 2024
marcin committed rCOMM7c26aa8714c5: Fix DM activity handler not to send unnecessary read status update (authored by marcin).
Fix DM activity handler not to send unnecessary read status update
marcin updated the diff for D13383: Fix DM activity handler not to send unnecessary read status update.
Rebase before landing
marcin committed rCOMMcc116bc456de: Pass pairs of message data and raw message info to notif generation code (authored by marcin).
Pass pairs of message data and raw message info to notif generation code
marcin updated the diff for D13417: Pass pairs of message data and raw message info to notif generation code.
Rebase before landing
marcin requested review of D13417: Pass pairs of message data and raw message info to notif generation code.
marcin added inline comments to D13383: Fix DM activity handler not to send unnecessary read status update.
marcin added inline comments to D13383: Fix DM activity handler not to send unnecessary read status update.
marcin added inline comments to D13383: Fix DM activity handler not to send unnecessary read status update.
Sep 19 2024
Sep 19 2024
marcin updated the diff for D13383: Fix DM activity handler not to send unnecessary read status update.
Address review
Sep 18 2024
Sep 18 2024
marcin requested review of D13383: Fix DM activity handler not to send unnecessary read status update.
marcin committed rCOMM819abceeb043: Fix BAD_MESSAGE_FORMAT issue with e2ee web notifs (authored by marcin).
Fix BAD_MESSAGE_FORMAT issue with e2ee web notifs
marcin updated the diff for D13353: Fix BAD_MESSAGE_FORMAT issue with e2ee web notifs.
rebase before landing
marcin committed rCOMM189c1fde4eed: Call textMessageCreationSideEffectsFunc after sending DM text message (authored by marcin).
Call textMessageCreationSideEffectsFunc after sending DM text message
marcin updated the diff for D13334: Call textMessageCreationSideEffectsFunc after sending DM text message.
Rebase before landing
marcin added a comment to D13334: Call textMessageCreationSideEffectsFunc after sending DM text message.
Sep 17 2024
Sep 17 2024
marcin updated the diff for D13353: Fix BAD_MESSAGE_FORMAT issue with e2ee web notifs.
Address review
marcin added inline comments to D13353: Fix BAD_MESSAGE_FORMAT issue with e2ee web notifs.
marcin added inline comments to D13334: Call textMessageCreationSideEffectsFunc after sending DM text message.
marcin updated the diff for D13334: Call textMessageCreationSideEffectsFunc after sending DM text message.
Rebase master
Sep 16 2024
Sep 16 2024
marcin requested review of D13353: Fix BAD_MESSAGE_FORMAT issue with e2ee web notifs.
Sep 13 2024
Sep 13 2024
marcin requested review of D13334: Call textMessageCreationSideEffectsFunc after sending DM text message.
marcin added inline comments to D13316: [lib] DMOperationSpec for create entry operation.
Sep 12 2024
Sep 12 2024
marcin added inline comments to D13287: Update input type of useChangeThreadSettings.
Enhance DMActivityHandler
marcin committed rCOMM0f616c5a4e92: Update input type of useSetThreadUnreadStatus (authored by marcin).
Update input type of useSetThreadUnreadStatus
marcin committed rCOMM6847b92312c1: Update input type of useUpdateSubscription (authored by marcin).
Update input type of useUpdateSubscription
marcin committed rCOMM3909f7edd16f: Update input type of useChangeThreadSettings (authored by marcin).
Update input type of useChangeThreadSettings
Implement joining DM thread
marcin updated the diff for D13305: Enhance DMActivityHandler.
Rebase before landing
marcin updated the diff for D13303: Update input type of useSetThreadUnreadStatus.
Rebase before landing
marcin updated the diff for D13289: Update input type of useUpdateSubscription.
Rebase before landing
marcin updated the diff for D13287: Update input type of useChangeThreadSettings.
Rebase before landing
marcin updated the diff for D13260: Implement joining DM thread.
rebase before landing
marcin requested review of D13305: Enhance DMActivityHandler.
marcin requested review of D13303: Update input type of useSetThreadUnreadStatus.
marcin requested review of D13287: Update input type of useChangeThreadSettings.
Made significant changes to address feedback regarding adding members to thick threads.
marcin updated the diff for D13287: Update input type of useChangeThreadSettings.
Address review
marcin updated the diff for D13260: Implement joining DM thread.
Make input type read only
marcin committed rCOMM29f2689035ef: One check for minimum code version supporting e2ee notifs (authored by marcin).
One check for minimum code version supporting e2ee notifs
marcin updated the diff for D13261: One check for minimum code version supporting e2ee notifs.
rebase before landing
Sep 11 2024
Sep 11 2024
marcin committed rCOMM085726ba64cd: Update threadIsPendingSidebar to handle thick sidebars (authored by marcin).
Update threadIsPendingSidebar to handle thick sidebars
marcin updated the diff for D13274: Update threadIsPendingSidebar to handle thick sidebars.
rebase before landing
marcin requested review of D13261: One check for minimum code version supporting e2ee notifs.
Re-requesting review as this new check is much better - we won't try to create a session nor process any data with device that does not have sufficient code version.
marcin updated the diff for D13261: One check for minimum code version supporting e2ee notifs.
More robust check. If the device doesn't support E2EE notifs we won't even try to create a notifs session with it.
Fix input types from D13050
marcin updated the diff for D13271: Fix input types from D13050.
Rebase before landing
marcin updated the diff for D13274: Update threadIsPendingSidebar to handle thick sidebars.
Extract sidebar and dm_sidebar to constants
marcin requested review of D13289: Update input type of useUpdateSubscription.
marcin updated the diff for D13275: Update search header in chat creation on native not to show GENESIS for thick threads.
Set flag to true in pendingThreadID
marcin attached a referenced file: F2662668: Zrzut ekranu 2024-09-11 o 13.21.52.png.
marcin added a comment to D13275: Update search header in chat creation on native not to show GENESIS for thick threads.
marcin requested review of D13287: Update input type of useChangeThreadSettings.
Sep 10 2024
Sep 10 2024
marcin updated the diff for D13260: Implement joining DM thread.
Implement union of types approach