Page MenuHomePhabricator

Active Repositories

Recent Activity

Today

angelika requested review of D13887: [lib] Add staff alert for missing device keys.
Wed, Nov 6, 1:49 PM
angelika closed D13863: [lib] Remove unecessary utils-copy-error dependency.
Wed, Nov 6, 6:41 AM
angelika closed D13864: [lib] Don't swallow errors in useGetAndUpdateDeviceListsForUsers.
Wed, Nov 6, 6:41 AM
angelika committed rCOMM3f50d089ad51: [lib] Don't swallow errors in useGetAndUpdateDeviceListsForUsers (authored by angelika).
[lib] Don't swallow errors in useGetAndUpdateDeviceListsForUsers
Wed, Nov 6, 6:41 AM
angelika committed rCOMM90e919811458: [lib] Remove unecessary utils-copy-error dependency (authored by angelika).
[lib] Remove unecessary utils-copy-error dependency
Wed, Nov 6, 6:41 AM
angelika closed D13862: [lib] Replace cloneError() with SendMessageError.
Wed, Nov 6, 6:41 AM
angelika committed rCOMM715cdf31911a: [lib] Replace cloneError() with SendMessageError (authored by angelika).
[lib] Replace cloneError() with SendMessageError
Wed, Nov 6, 6:41 AM
bartek accepted D13876: [backup-service] implement endpoint to upload User Keys.
Wed, Nov 6, 6:13 AM
kamil accepted D13862: [lib] Replace cloneError() with SendMessageError.
Wed, Nov 6, 6:00 AM
angelika updated the diff for D13864: [lib] Don't swallow errors in useGetAndUpdateDeviceListsForUsers.

Rebase

Wed, Nov 6, 5:43 AM
angelika updated the diff for D13863: [lib] Remove unecessary utils-copy-error dependency.

Rebase

Wed, Nov 6, 5:43 AM
angelika updated the diff for D13862: [lib] Replace cloneError() with SendMessageError.

Update errors in lib/hooks/input-state-container-hooks.js

Wed, Nov 6, 5:42 AM
kamil published D13879: [backup-service][commtest] implement integration tests for uploading User Keys and User Data separately for review.

Adding more reviewers here - maybe there is more edge-cases that worth testing too

Wed, Nov 6, 5:08 AM
ashoat closed D13871: [native] Get rid of bottomSheetPaddingTop in ConnectFarcasterBottomSheet.
Wed, Nov 6, 4:56 AM
ashoat committed rCOMMf6dbe5552fdc: [native] Get rid of bottomSheetPaddingTop in ConnectFarcasterBottomSheet (authored by ashoat).
[native] Get rid of bottomSheetPaddingTop in ConnectFarcasterBottomSheet
Wed, Nov 6, 4:56 AM
ashoat closed D13870: [native] Get rid of userProfileBottomPadding.
Wed, Nov 6, 4:56 AM
ashoat committed rCOMMd84f08db594c: [native] Get rid of userProfileBottomPadding (authored by ashoat).
[native] Get rid of userProfileBottomPadding
Wed, Nov 6, 4:56 AM
ashoat closed D13869: [native] Fix incorrectly set verticalBounds in UserProfileAvatar.
Wed, Nov 6, 4:56 AM
ashoat committed rCOMM17abf486d396: [native] Fix incorrectly set verticalBounds in UserProfileAvatar (authored by ashoat).
[native] Fix incorrectly set verticalBounds in UserProfileAvatar
Wed, Nov 6, 4:56 AM
ashoat closed D13868: [native] Measure whole KeyserverSelectionBottomSheet.
Wed, Nov 6, 4:56 AM
ashoat committed rCOMM2bb4fd49fe76: [native] Measure whole KeyserverSelectionBottomSheet (authored by ashoat).
[native] Measure whole KeyserverSelectionBottomSheet
Wed, Nov 6, 4:56 AM
ashoat closed D13867: [native] Consider BottomSheetHandle size when setting snapPoints.
Wed, Nov 6, 4:56 AM
ashoat committed rCOMMbfb232d74a50: [native] Consider BottomSheetHandle size when setting snapPoints (authored by ashoat).
[native] Consider BottomSheetHandle size when setting snapPoints
Wed, Nov 6, 4:56 AM
angelika closed D13880: [native] Fix QR code scanning on Android.
Wed, Nov 6, 4:28 AM
angelika committed rCOMM429c59416e23: [native] Fix QR code scanning on Android (authored by angelika).
[native] Fix QR code scanning on Android
Wed, Nov 6, 4:28 AM
angelika added a comment to D13880: [native] Fix QR code scanning on Android.

Great find here!! Is it possible that this fixes ENG-8780 as well? I think that one is also a permissions issue.

Wed, Nov 6, 4:26 AM
kamil published D13878: [backup-service] make `user_data` and `user_keys` optional in `BackupData` for review.
Wed, Nov 6, 3:46 AM
kamil published D13877: [backup-service] implement endpoint to upload User Data for review.
Wed, Nov 6, 3:43 AM
kamil published D13876: [backup-service] implement endpoint to upload User Keys for review.
Wed, Nov 6, 3:41 AM
kamil updated the test plan for D13875: [backup-service] make `user_data` optional in `BackupItem`.
Wed, Nov 6, 3:35 AM
bartek accepted D13880: [native] Fix QR code scanning on Android.

Nice find!

Wed, Nov 6, 2:53 AM
bartek accepted D13875: [backup-service] make `user_data` optional in `BackupItem`.
Wed, Nov 6, 1:06 AM
bartek accepted D13873: [backup-service] refactor uploading function in `/backups` endpoint.
Wed, Nov 6, 1:05 AM
bartek accepted D13849: [CommCoreModule][native_rust_library] update downloading User Keys to support user identifier.

Alternatively, we can download only backupID and read backupDataKey and backupLogDataKey (it should exist on primary always) to avoid downloading User Keys - but curious about @bartek's perspective as I don't fully remember why it was implemented that way,

Wed, Nov 6, 1:01 AM
bartek accepted D13872: [commtest] refactor backup service integration tests.

Nice!

Wed, Nov 6, 12:59 AM
bartek accepted D13871: [native] Get rid of bottomSheetPaddingTop in ConnectFarcasterBottomSheet.
Wed, Nov 6, 12:39 AM
bartek accepted D13870: [native] Get rid of userProfileBottomPadding.
Wed, Nov 6, 12:39 AM
bartek accepted D13869: [native] Fix incorrectly set verticalBounds in UserProfileAvatar.
Wed, Nov 6, 12:39 AM
bartek accepted D13868: [native] Measure whole KeyserverSelectionBottomSheet.
Wed, Nov 6, 12:38 AM
bartek accepted D13867: [native] Consider BottomSheetHandle size when setting snapPoints.
Wed, Nov 6, 12:38 AM