Page MenuHomePhabricator

Active Repositories

Recent Activity

Today

will requested review of D13720: [lib] Do not show sidebar underneath parent if in different tab.
Tue, Oct 15, 3:30 PM
will requested review of D13719: [lib] Show sidebars in top level if parent thread is in a separate tab.
Tue, Oct 15, 3:20 PM
ashoat accepted D13712: Fix payloadSizeExceeded calculated incorrectly.
Tue, Oct 15, 2:53 PM
angelika added a comment to D13713: Rename notificationSizeValidator to isNotificationSizeValid.

You updated the wrong diff – this can happen if you don't rebase back to the original diff before running arc diff again

arc diff basically checks the "Differential Revision: " line of the most recent commit, and updates the corresponding Phabricator diff to match that commit.

Tue, Oct 15, 2:51 PM
angelika updated the diff for D13713: Rename notificationSizeValidator to isNotificationSizeValid.

Rebase

Tue, Oct 15, 2:48 PM
angelika updated the diff for D13712: Fix payloadSizeExceeded calculated incorrectly.

Fix also Android functions

Tue, Oct 15, 2:48 PM
ashoat added a comment to D13713: Rename notificationSizeValidator to isNotificationSizeValid.

You updated the wrong diff – this can happen if you don't rebase back to the original diff before running arc diff again

Tue, Oct 15, 2:47 PM
angelika updated the diff for D13713: Rename notificationSizeValidator to isNotificationSizeValid.

Fix also Android functions

Tue, Oct 15, 2:44 PM
ashoat requested changes to D13718: [lib] change fetchFarcasterChannelByName -> fetchFarcasterChannelByID and refactor.

Glad you independently found the id/name bug!

Tue, Oct 15, 2:00 PM
ashoat committed rCOMMf7f7f537641e: [terraform] Bump keyserver image to 1.0.134 (authored by ashoat).
[terraform] Bump keyserver image to 1.0.134
Tue, Oct 15, 1:53 PM
varun added inline comments to D13718: [lib] change fetchFarcasterChannelByName -> fetchFarcasterChannelByID and refactor.
Tue, Oct 15, 12:48 PM
varun published D13718: [lib] change fetchFarcasterChannelByName -> fetchFarcasterChannelByID and refactor for review.

I see D13717 was landed already but I think this diff is still an improvement. Will rebase and wait for CI before landing

Tue, Oct 15, 12:46 PM
ashoat committed rCOMM9df25fabe52b: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Tue, Oct 15, 12:46 PM
ashoat added a reverting change for rCOMMe620236539b4: [native] Temporary changes for staff release: rCOMM9df25fabe52b: Revert "[native] Temporary changes for staff release".
Tue, Oct 15, 12:46 PM
ashoat committed rCOMM0c11a17f08b1: [native] codeVersion -> 426 (authored by ashoat).
[native] codeVersion -> 426
Tue, Oct 15, 12:46 PM
ashoat committed rCOMMe620236539b4: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Tue, Oct 15, 12:46 PM
ashoat committed rCOMM611fc9230151: [native] codeVersion -> 425 (authored by ashoat).
[native] codeVersion -> 425
Tue, Oct 15, 12:46 PM
ashoat committed rCOMM12b2d77ba378: [web][keyserver] codeVersion -> 134 (authored by ashoat).
[web][keyserver] codeVersion -> 134
Tue, Oct 15, 12:46 PM
ashoat closed D13717: [lib] Fix selecting custom Neynar channel.
Tue, Oct 15, 12:42 PM
ashoat committed rCOMM9f60dd286748: [lib] Fix selecting custom Neynar channel (authored by ashoat).
[lib] Fix selecting custom Neynar channel
Tue, Oct 15, 12:42 PM
ashoat closed D13716: [lib] Disconnect FID when another device disconnects it.
Tue, Oct 15, 12:42 PM
ashoat closed D13715: [lib] Return null for successful fetch with no result in UserIdentityCache.
Tue, Oct 15, 12:42 PM
ashoat committed rCOMMb1e1966377ee: [lib] Disconnect FID when another device disconnects it (authored by ashoat).
[lib] Disconnect FID when another device disconnects it
Tue, Oct 15, 12:42 PM
ashoat committed rCOMMeb8ba0adac2f: [lib] Return null for successful fetch with no result in UserIdentityCache (authored by ashoat).
[lib] Return null for successful fetch with no result in UserIdentityCache
Tue, Oct 15, 12:42 PM
ashoat closed D13714: [keyserver] Make it so Ashoat creates chat with users on registration.
Tue, Oct 15, 12:42 PM
ashoat committed rCOMM9b5ca19cfbb5: [keyserver] Make it so Ashoat creates chat with users on registration (authored by ashoat).
[keyserver] Make it so Ashoat creates chat with users on registration
Tue, Oct 15, 12:42 PM
will accepted D13717: [lib] Fix selecting custom Neynar channel.
Tue, Oct 15, 12:41 PM
ashoat published D13717: [lib] Fix selecting custom Neynar channel for review.
Tue, Oct 15, 12:24 PM
will accepted D13714: [keyserver] Make it so Ashoat creates chat with users on registration.
Tue, Oct 15, 11:36 AM
will accepted D13715: [lib] Return null for successful fetch with no result in UserIdentityCache.
Tue, Oct 15, 11:35 AM
will accepted D13716: [lib] Disconnect FID when another device disconnects it.
Tue, Oct 15, 11:32 AM
ashoat published D13716: [lib] Disconnect FID when another device disconnects it for review.
Tue, Oct 15, 11:28 AM
ashoat published D13715: [lib] Return null for successful fetch with no result in UserIdentityCache for review.
Tue, Oct 15, 11:27 AM
ashoat published D13714: [keyserver] Make it so Ashoat creates chat with users on registration for review.
Tue, Oct 15, 10:10 AM
ashoat requested changes to D13712: Fix payloadSizeExceeded calculated incorrectly.

Nice work! It looks like Android has the same issue, but the variable is named slightly differently. If you agree with my assessment, can you fix it for Android too?

Tue, Oct 15, 9:31 AM
ashoat accepted D13713: Rename notificationSizeValidator to isNotificationSizeValid.

Thanks for doing this!

Tue, Oct 15, 9:26 AM
angelika requested review of D13713: Rename notificationSizeValidator to isNotificationSizeValid.
Tue, Oct 15, 6:05 AM
ashoat closed D13709: [native] Fix reacting to robotext when sidebar is disabled.
Tue, Oct 15, 5:46 AM
ashoat closed D13708: [web] Fix reacting to robotext.
Tue, Oct 15, 5:46 AM
ashoat committed rCOMM25eeb2f33576: [native] Fix reacting to robotext when sidebar is disabled (authored by ashoat).
[native] Fix reacting to robotext when sidebar is disabled
Tue, Oct 15, 5:46 AM