Page MenuHomePhabricator

Active Repositories
View All

Recent Activity
View All

Today

tomek requested review of D14220: [native] Save the correct backup credentials.
Fri, Jan 17, 8:20 AM
bartek accepted D14214: [native] improve conditions about performing migration.

The conditions look correct, I only added a suggestion on how to improve reliability. I analyzed the following cases:

Fri, Jan 17, 4:27 AM
bartek accepted D14217: [native] fix creating new device list in `reorderAndSignDeviceList`.
Fri, Jan 17, 4:16 AM
bartek accepted D14216: [native] handle errors when running migration to new flow.
Fri, Jan 17, 4:15 AM
tomek accepted D14219: [identity] Allow migration for non-primary device.
Fri, Jan 17, 3:50 AM
tomek accepted D14218: [web] Use legacy logout when web is primary.
Fri, Jan 17, 3:49 AM
bartek accepted D14213: [native] cleanup code related to getting device list and add code comments.
Fri, Jan 17, 3:44 AM
bartek accepted D14212: [native] extract migrating to new flow to a hook.
Fri, Jan 17, 3:41 AM
tomek accepted D14217: [native] fix creating new device list in `reorderAndSignDeviceList`.
Fri, Jan 17, 3:40 AM
bartek accepted D14211: [native][lib] extract retrieving current user device list to a hook.

I recall there are other places where this hook might also be useful, but I couldn't quickly identify them.

Fri, Jan 17, 3:40 AM
tomek accepted D14216: [native] handle errors when running migration to new flow.
Fri, Jan 17, 3:40 AM
bartek accepted D14210: [native] move code for testing backup restoration to `BackupMenu`.
Fri, Jan 17, 3:38 AM
tomek accepted D14215: [native] fix not starting backup handler when performing migration to new flow.
Fri, Jan 17, 3:38 AM
tomek accepted D14214: [native] improve conditions about performing migration.
Fri, Jan 17, 3:37 AM
bartek published D14219: [identity] Allow migration for non-primary device for review.
Fri, Jan 17, 3:36 AM
bartek published D14218: [web] Use legacy logout when web is primary for review.
Fri, Jan 17, 3:35 AM
tomek accepted D14213: [native] cleanup code related to getting device list and add code comments.
Fri, Jan 17, 3:28 AM

Yesterday

tomek accepted D14212: [native] extract migrating to new flow to a hook.
Thu, Jan 16, 7:11 AM
tomek accepted D14211: [native][lib] extract retrieving current user device list to a hook.
Thu, Jan 16, 7:10 AM
tomek accepted D14210: [native] move code for testing backup restoration to `BackupMenu`.
Thu, Jan 16, 7:06 AM
kamil published D14217: [native] fix creating new device list in `reorderAndSignDeviceList` for review.
Thu, Jan 16, 6:50 AM
kamil published D14216: [native] handle errors when running migration to new flow for review.
Thu, Jan 16, 6:49 AM
kamil published D14215: [native] fix not starting backup handler when performing migration to new flow for review.
Thu, Jan 16, 6:48 AM
kamil published D14214: [native] improve conditions about performing migration for review.
Thu, Jan 16, 6:47 AM
kamil published D14213: [native] cleanup code related to getting device list and add code comments for review.
Thu, Jan 16, 6:46 AM
kamil published D14212: [native] extract migrating to new flow to a hook for review.
Thu, Jan 16, 6:45 AM
kamil published D14211: [native][lib] extract retrieving current user device list to a hook for review.
Thu, Jan 16, 6:44 AM
kamil published D14210: [native] move code for testing backup restoration to `BackupMenu` for review.
Thu, Jan 16, 6:43 AM
tomek accepted D14208: [identity] Bump minimum supported client version.
Thu, Jan 16, 4:24 AM

Wed, Jan 15

kamil closed D14209: [script] fix `skip_password_reset` usage.
Wed, Jan 15, 6:29 AM
kamil committed rCOMMeb20fb9e5ab7: [script] fix `skip_password_reset` usage (authored by kamil).
[script] fix `skip_password_reset` usage
Wed, Jan 15, 6:29 AM
bartek accepted D14209: [script] fix `skip_password_reset` usage.

Thank you

Wed, Jan 15, 6:26 AM
kamil published D14209: [script] fix `skip_password_reset` usage for review.
Wed, Jan 15, 6:19 AM
angelika added a comment to D14203: [native] Add Flow types for react-native-gesture-handler v2 basic gestures.
In D14203#395762, @ashoat wrote:

Just confirming – you ran prettier --write on this file, right?

Yes, but only on the code I've added. The old code in this file is not formatted.

Wed, Jan 15, 5:50 AM
bartek published D14208: [identity] Bump minimum supported client version for review.
Wed, Jan 15, 4:13 AM
bartek closed D14206: [web] Move KeyserverConnectionHandler into ConnectedApp.
Wed, Jan 15, 3:18 AM
bartek committed rCOMM85fe02279ea6: [web] Move KeyserverConnectionHandler into ConnectedApp (authored by bartek).
[web] Move KeyserverConnectionHandler into ConnectedApp
Wed, Jan 15, 3:18 AM
tomek accepted D14195: [native] Migrate VideoPlaybackModal to Reanimated V2 API.
Wed, Jan 15, 2:21 AM
tomek accepted D14203: [native] Add Flow types for react-native-gesture-handler v2 basic gestures.

Haven't reviewed too closely, but it looks reasonable, and the summary's tradeoffs make sense.

Wed, Jan 15, 2:12 AM
kamil accepted D14206: [web] Move KeyserverConnectionHandler into ConnectedApp.
Wed, Jan 15, 1:49 AM