In D13713#383795, @ashoat wrote:You updated the wrong diff – this can happen if you don't rebase back to the original diff before running arc diff again
arc diff basically checks the "Differential Revision: " line of the most recent commit, and updates the corresponding Phabricator diff to match that commit.
Active Repositories
Active Repositories
Recent Activity
Recent Activity
Today
Today
will requested review of D13719: [lib] Show sidebars in top level if parent thread is in a separate tab.
Rebase
Fix also Android functions
You updated the wrong diff – this can happen if you don't rebase back to the original diff before running arc diff again
Fix also Android functions
ashoat requested changes to D13718: [lib] change fetchFarcasterChannelByName -> fetchFarcasterChannelByID and refactor.
Glad you independently found the id/name bug!
ashoat committed rCOMMf7f7f537641e: [terraform] Bump keyserver image to 1.0.134 (authored by ashoat).
[terraform] Bump keyserver image to 1.0.134
varun added inline comments to D13718: [lib] change fetchFarcasterChannelByName -> fetchFarcasterChannelByID and refactor.
varun published D13718: [lib] change fetchFarcasterChannelByName -> fetchFarcasterChannelByID and refactor for review.
I see D13717 was landed already but I think this diff is still an improvement. Will rebase and wait for CI before landing
ashoat committed rCOMM9df25fabe52b: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
[native] codeVersion -> 426
ashoat committed rCOMMe620236539b4: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
[native] codeVersion -> 425
[web][keyserver] codeVersion -> 134
[lib] Fix selecting custom Neynar channel
ashoat committed rCOMMb1e1966377ee: [lib] Disconnect FID when another device disconnects it (authored by ashoat).
[lib] Disconnect FID when another device disconnects it
ashoat committed rCOMMeb8ba0adac2f: [lib] Return null for successful fetch with no result in UserIdentityCache (authored by ashoat).
[lib] Return null for successful fetch with no result in UserIdentityCache
ashoat committed rCOMM9b5ca19cfbb5: [keyserver] Make it so Ashoat creates chat with users on registration (authored by ashoat).
[keyserver] Make it so Ashoat creates chat with users on registration
ashoat published D13715: [lib] Return null for successful fetch with no result in UserIdentityCache for review.
ashoat published D13714: [keyserver] Make it so Ashoat creates chat with users on registration for review.
Nice work! It looks like Android has the same issue, but the variable is named slightly differently. If you agree with my assessment, can you fix it for Android too?
Thanks for doing this!
ashoat committed rCOMM25eeb2f33576: [native] Fix reacting to robotext when sidebar is disabled (authored by ashoat).
[native] Fix reacting to robotext when sidebar is disabled