Page MenuHomePhabricator
Differential D10140

[native] Rip `LegacyThreadInfo` out of `native/chat`
ClosedPublic
Actions

Authored by atul on Dec 1 2023, 9:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 2, 3:40 AM
Unknown Object (File)
Fri, Mar 28, 8:56 AM
Unknown Object (File)
Sun, Mar 23, 9:53 PM
Unknown Object (File)
Wed, Mar 19, 10:53 PM
Unknown Object (File)
Mar 4 2025, 5:42 AM
Unknown Object (File)
Mar 3 2025, 11:26 PM
Unknown Object (File)
Feb 27 2025, 7:23 PM
Unknown Object (File)
Feb 27 2025, 7:15 PM
View All 79 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMMd1cddf319e6f: [native] Rip `LegacyThreadInfo` out of `native/chat`
Summary

Update all props and callbacks being "drilled" to ThreadInfo from LegacyThreadInfo.

We're now down to 61 usages of LegacyThreadInfo from 700+

Depends on D10139

Test Plan

CI/flow/etc.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Dec 1 2023, 9:10 AM
atul published this revision for review.Dec 1 2023, 9:12 AM
atul edited the summary of this revision. (Show Details)
ashoat accepted this revision.Dec 1 2023, 9:20 AM
This revision is now accepted and ready to land.Dec 1 2023, 9:20 AM
Harbormaster failed remote builds in B24699: Diff 34131!Dec 1 2023, 9:23 AM
atul added a child revision: D10142: Rip `LegacyThreadInfo` out of selectors and related code.Dec 1 2023, 11:24 AM
This revision was landed with ongoing or failed builds.Dec 1 2023, 12:44 PM
Closed by commit rCOMMd1cddf319e6f: [native] Rip `LegacyThreadInfo` out of `native/chat` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMd1cddf319e6f: [native] Rip `LegacyThreadInfo` out of `native/chat`.

Revision Contents
Changeset List

Diff 34158

View Options

native/chat/chat-thread-list-item.react.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import type { SetState } from 'lib/types/hook-types.js'; import type { SetState } from 'lib/types/hook-types.js';
import type { MinimallyEncodedThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import type { LegacyThreadInfo } from 'lib/types/thread-types.js';
import type { NativeChatMessageItem } from './message-data.react.js'; import type { NativeChatMessageItem } from './message-data.react.js';
import type { ChatMessageItemWithHeight } from '../types/chat-types.js'; import type { ChatMessageItemWithHeight } from '../types/chat-types.js';
export type MessagesMeasurer = ( export type MessagesMeasurer = (
?$ReadOnlyArray<NativeChatMessageItem>, ?$ReadOnlyArray<NativeChatMessageItem>,
?LegacyThreadInfo | ?MinimallyEncodedThreadInfo, ?ThreadInfo,
($ReadOnlyArray<ChatMessageItemWithHeight>) => mixed, ($ReadOnlyArray<ChatMessageItemWithHeight>) => mixed,
) => void; ) => void;
export type RegisteredMeasurer = { export type RegisteredMeasurer = {
+measure: MessagesMeasurer, +measure: MessagesMeasurer,
+unregister: () => void, +unregister: () => void,
}; };
Show All 31 Lines
View Options

native/chat/chat-thread-list-see-more-sidebars.react.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import type { SetState } from 'lib/types/hook-types.js'; import type { SetState } from 'lib/types/hook-types.js';
import type { MinimallyEncodedThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import type { LegacyThreadInfo } from 'lib/types/thread-types.js';
import type { NativeChatMessageItem } from './message-data.react.js'; import type { NativeChatMessageItem } from './message-data.react.js';
import type { ChatMessageItemWithHeight } from '../types/chat-types.js'; import type { ChatMessageItemWithHeight } from '../types/chat-types.js';
export type MessagesMeasurer = ( export type MessagesMeasurer = (
?$ReadOnlyArray<NativeChatMessageItem>, ?$ReadOnlyArray<NativeChatMessageItem>,
?LegacyThreadInfo | ?MinimallyEncodedThreadInfo, ?ThreadInfo,
($ReadOnlyArray<ChatMessageItemWithHeight>) => mixed, ($ReadOnlyArray<ChatMessageItemWithHeight>) => mixed,
) => void; ) => void;
export type RegisteredMeasurer = { export type RegisteredMeasurer = {
+measure: MessagesMeasurer, +measure: MessagesMeasurer,
+unregister: () => void, +unregister: () => void,
}; };
Show All 31 Lines
View Options

native/chat/chat-thread-list-sidebar.react.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import type { SetState } from 'lib/types/hook-types.js'; import type { SetState } from 'lib/types/hook-types.js';
import type { MinimallyEncodedThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import type { LegacyThreadInfo } from 'lib/types/thread-types.js';
import type { NativeChatMessageItem } from './message-data.react.js'; import type { NativeChatMessageItem } from './message-data.react.js';
import type { ChatMessageItemWithHeight } from '../types/chat-types.js'; import type { ChatMessageItemWithHeight } from '../types/chat-types.js';
export type MessagesMeasurer = ( export type MessagesMeasurer = (
?$ReadOnlyArray<NativeChatMessageItem>, ?$ReadOnlyArray<NativeChatMessageItem>,
?LegacyThreadInfo | ?MinimallyEncodedThreadInfo, ?ThreadInfo,
($ReadOnlyArray<ChatMessageItemWithHeight>) => mixed, ($ReadOnlyArray<ChatMessageItemWithHeight>) => mixed,
) => void; ) => void;
export type RegisteredMeasurer = { export type RegisteredMeasurer = {
+measure: MessagesMeasurer, +measure: MessagesMeasurer,
+unregister: () => void, +unregister: () => void,
}; };
Show All 31 Lines
View Options

native/chat/chat-thread-list.react.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import type { SetState } from 'lib/types/hook-types.js'; import type { SetState } from 'lib/types/hook-types.js';
import type { MinimallyEncodedThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import type { LegacyThreadInfo } from 'lib/types/thread-types.js';
import type { NativeChatMessageItem } from './message-data.react.js'; import type { NativeChatMessageItem } from './message-data.react.js';
import type { ChatMessageItemWithHeight } from '../types/chat-types.js'; import type { ChatMessageItemWithHeight } from '../types/chat-types.js';
export type MessagesMeasurer = ( export type MessagesMeasurer = (
?$ReadOnlyArray<NativeChatMessageItem>, ?$ReadOnlyArray<NativeChatMessageItem>,
?LegacyThreadInfo | ?MinimallyEncodedThreadInfo, ?ThreadInfo,
($ReadOnlyArray<ChatMessageItemWithHeight>) => mixed, ($ReadOnlyArray<ChatMessageItemWithHeight>) => mixed,
) => void; ) => void;
export type RegisteredMeasurer = { export type RegisteredMeasurer = {
+measure: MessagesMeasurer, +measure: MessagesMeasurer,
+unregister: () => void, +unregister: () => void,
}; };
Show All 31 Lines
View Options

native/chat/compose-subchannel.react.js

Loading...
View Options

native/chat/sidebar-list-modal.react.js

Loading...
View Options

native/chat/subchannels-list-modal.react.js

Loading...
View Options

native/chat/swipeable-thread.react.js

Loading...
View Options

native/chat/thread-list-modal.react.js

Loading...