Page MenuHomePhabricator
Differential D10142

Rip `LegacyThreadInfo` out of selectors and related code
ClosedPublic
Actions

Authored by atul on Dec 1 2023, 11:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 2, 3:38 AM
Unknown Object (File)
Fri, Mar 21, 1:40 PM
Unknown Object (File)
Wed, Mar 19, 10:52 PM
Unknown Object (File)
Mar 4 2025, 10:47 AM
Unknown Object (File)
Mar 4 2025, 5:42 AM
Unknown Object (File)
Feb 27 2025, 7:23 PM
Unknown Object (File)
Feb 27 2025, 7:15 PM
Unknown Object (File)
Feb 27 2025, 7:15 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMMaca9f25487d3: Rip `LegacyThreadInfo` out of selectors and related code
Summary

Ripped LegacyThreadInfo out of selectors and updated related code to use ThreadInfo as well.

We're now down to 6 usages of LegacyThreadInfo from ~750

WARNING: There was one instance where we had to add noop branching to web/modals/threads/settings/thread-settings-modal.react.js:68-72 to appease flow.

Depends on D10140

Test Plan

CI/flow/etc.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Dec 1 2023, 11:24 AM
atul added inline comments.Dec 1 2023, 11:25 AM
web/chat/thread-list-provider.js
152 ↗(On Diff #34135)

This was accidental, it will be removed.

web/modals/threads/settings/thread-settings-modal.react.js
68–72 ↗(On Diff #34135)
NOTE: This is the one place we had to add branching to appease flow.
atul updated this revision to Diff 34136.Dec 1 2023, 11:27 AM

update

atul published this revision for review.Dec 1 2023, 11:28 AM
atul edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B24702: Diff 34135.Dec 1 2023, 11:52 AM
Harbormaster completed remote builds in B24703: Diff 34136.Dec 1 2023, 12:02 PM
ashoat accepted this revision.Dec 1 2023, 12:18 PM
This revision is now accepted and ready to land.Dec 1 2023, 12:18 PM
atul updated this revision to Diff 34143.Dec 1 2023, 12:21 PM

include more

atul edited the summary of this revision. (Show Details)Dec 1 2023, 12:21 PM
This revision was landed with ongoing or failed builds.Dec 1 2023, 12:44 PM
Closed by commit rCOMMaca9f25487d3: Rip `LegacyThreadInfo` out of selectors and related code (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMaca9f25487d3: Rip `LegacyThreadInfo` out of selectors and related code.
Harbormaster completed remote builds in B24710: Diff 34143.Dec 1 2023, 1:23 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
push/
7 lines
lib/
selectors/
19 lines
37 lines
shared/
7 lines
8 lines
10 lines
6 lines
types/
4 lines
utils/
11 lines
native/
chat/
settings/
3 lines
push/
4 lines
selectors/
6 lines
web/
chat/
1 line
modals/
threads/
settings/
13 lines
selectors/
8 lines
types/
4 lines

Diff 34159

View Options

keyserver/src/push/send.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { import {
parseThreadPermissionString, parseThreadPermissionString,
constructThreadPermissionString,
includeThreadPermissionForThreadType, includeThreadPermissionForThreadType,
} from './prefixes.js'; } from './prefixes.js';
import { import {
configurableCommunityPermissions, configurableCommunityPermissions,
threadPermissionFilterPrefixes, threadPermissionFilterPrefixes,
threadPermissionPropagationPrefixes, threadPermissionPropagationPrefixes,
threadPermissions, threadPermissions,
userSurfacedPermissions, userSurfacedPermissions,
▲ Show 20 Lines • Show All 148 Lines • ▼ Show 20 Lines if (!parsed.propagationPrefix) {
continue; continue;
} }
if ( if (
parsed.propagationPrefix === parsed.propagationPrefix ===
threadPermissionPropagationPrefixes.DESCENDANT threadPermissionPropagationPrefixes.DESCENDANT
) { ) {
permissionsForChildren[permissionKey] = permissionValue; permissionsForChildren[permissionKey] = permissionValue;
} }
const permissionWithFilterPrefix = parsed.filterPrefix const withoutPropagationPrefix = constructThreadPermissionString({
? `${parsed.filterPrefix}${parsed.permission}` ...parsed,
: parsed.permission; propagationPrefix: null,
permissionsForChildren[permissionWithFilterPrefix] = permissionValue; });
permissionsForChildren[withoutPropagationPrefix] = permissionValue;
} }
if (Object.keys(permissionsForChildren).length === 0) { if (Object.keys(permissionsForChildren).length === 0) {
return null; return null;
} }
return permissionsForChildren; return permissionsForChildren;
} }
function getRoleForPermissions( function getRoleForPermissions(
▲ Show 20 Lines • Show All 373 Lines • Show Last 20 Lines
View Options

lib/selectors/chat-selectors.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { import {
parseThreadPermissionString, parseThreadPermissionString,
constructThreadPermissionString,
includeThreadPermissionForThreadType, includeThreadPermissionForThreadType,
} from './prefixes.js'; } from './prefixes.js';
import { import {
configurableCommunityPermissions, configurableCommunityPermissions,
threadPermissionFilterPrefixes, threadPermissionFilterPrefixes,
threadPermissionPropagationPrefixes, threadPermissionPropagationPrefixes,
threadPermissions, threadPermissions,
userSurfacedPermissions, userSurfacedPermissions,
▲ Show 20 Lines • Show All 148 Lines • ▼ Show 20 Lines if (!parsed.propagationPrefix) {
continue; continue;
} }
if ( if (
parsed.propagationPrefix === parsed.propagationPrefix ===
threadPermissionPropagationPrefixes.DESCENDANT threadPermissionPropagationPrefixes.DESCENDANT
) { ) {
permissionsForChildren[permissionKey] = permissionValue; permissionsForChildren[permissionKey] = permissionValue;
} }
const permissionWithFilterPrefix = parsed.filterPrefix const withoutPropagationPrefix = constructThreadPermissionString({
? `${parsed.filterPrefix}${parsed.permission}` ...parsed,
: parsed.permission; propagationPrefix: null,
permissionsForChildren[permissionWithFilterPrefix] = permissionValue; });
permissionsForChildren[withoutPropagationPrefix] = permissionValue;
} }
if (Object.keys(permissionsForChildren).length === 0) { if (Object.keys(permissionsForChildren).length === 0) {
return null; return null;
} }
return permissionsForChildren; return permissionsForChildren;
} }
function getRoleForPermissions( function getRoleForPermissions(
▲ Show 20 Lines • Show All 373 Lines • Show Last 20 Lines
View Options

lib/selectors/thread-selectors.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { import {
parseThreadPermissionString, parseThreadPermissionString,
constructThreadPermissionString,
includeThreadPermissionForThreadType, includeThreadPermissionForThreadType,
} from './prefixes.js'; } from './prefixes.js';
import { import {
configurableCommunityPermissions, configurableCommunityPermissions,
threadPermissionFilterPrefixes, threadPermissionFilterPrefixes,
threadPermissionPropagationPrefixes, threadPermissionPropagationPrefixes,
threadPermissions, threadPermissions,
userSurfacedPermissions, userSurfacedPermissions,
▲ Show 20 Lines • Show All 148 Lines • ▼ Show 20 Lines if (!parsed.propagationPrefix) {
continue; continue;
} }
if ( if (
parsed.propagationPrefix === parsed.propagationPrefix ===
threadPermissionPropagationPrefixes.DESCENDANT threadPermissionPropagationPrefixes.DESCENDANT
) { ) {
permissionsForChildren[permissionKey] = permissionValue; permissionsForChildren[permissionKey] = permissionValue;
} }
const permissionWithFilterPrefix = parsed.filterPrefix const withoutPropagationPrefix = constructThreadPermissionString({
? `${parsed.filterPrefix}${parsed.permission}` ...parsed,
: parsed.permission; propagationPrefix: null,
permissionsForChildren[permissionWithFilterPrefix] = permissionValue; });
permissionsForChildren[withoutPropagationPrefix] = permissionValue;
} }
if (Object.keys(permissionsForChildren).length === 0) { if (Object.keys(permissionsForChildren).length === 0) {
return null; return null;
} }
return permissionsForChildren; return permissionsForChildren;
} }
function getRoleForPermissions( function getRoleForPermissions(
▲ Show 20 Lines • Show All 373 Lines • Show Last 20 Lines
View Options

lib/shared/ancestor-threads.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { import {
parseThreadPermissionString, parseThreadPermissionString,
constructThreadPermissionString,
includeThreadPermissionForThreadType, includeThreadPermissionForThreadType,
} from './prefixes.js'; } from './prefixes.js';
import { import {
configurableCommunityPermissions, configurableCommunityPermissions,
threadPermissionFilterPrefixes, threadPermissionFilterPrefixes,
threadPermissionPropagationPrefixes, threadPermissionPropagationPrefixes,
threadPermissions, threadPermissions,
userSurfacedPermissions, userSurfacedPermissions,
▲ Show 20 Lines • Show All 148 Lines • ▼ Show 20 Lines if (!parsed.propagationPrefix) {
continue; continue;
} }
if ( if (
parsed.propagationPrefix === parsed.propagationPrefix ===
threadPermissionPropagationPrefixes.DESCENDANT threadPermissionPropagationPrefixes.DESCENDANT
) { ) {
permissionsForChildren[permissionKey] = permissionValue; permissionsForChildren[permissionKey] = permissionValue;
} }
const permissionWithFilterPrefix = parsed.filterPrefix const withoutPropagationPrefix = constructThreadPermissionString({
? `${parsed.filterPrefix}${parsed.permission}` ...parsed,
: parsed.permission; propagationPrefix: null,
permissionsForChildren[permissionWithFilterPrefix] = permissionValue; });
permissionsForChildren[withoutPropagationPrefix] = permissionValue;
} }
if (Object.keys(permissionsForChildren).length === 0) { if (Object.keys(permissionsForChildren).length === 0) {
return null; return null;
} }
return permissionsForChildren; return permissionsForChildren;
} }
function getRoleForPermissions( function getRoleForPermissions(
▲ Show 20 Lines • Show All 373 Lines • Show Last 20 Lines
View Options

lib/shared/message-utils.js

Loading...
View Options

lib/shared/notif-utils.js

Loading...
View Options

lib/shared/thread-utils.js

Loading...
View Options

lib/types/thread-types.js

Loading...
View Options

lib/utils/entity-helpers.js

Loading...
View Options

native/chat/settings/thread-settings.react.js

Loading...
View Options

native/push/push-handler.react.js

Loading...
View Options

native/selectors/calendar-selectors.js

Loading...
View Options

web/chat/thread-list-provider.js

Loading...
View Options

web/modals/threads/settings/thread-settings-modal.react.js

Loading...
View Options

web/selectors/chat-selectors.js

Loading...
View Options

web/types/nav-types.js

Loading...