[lib] Consume "new" `ThreadInfo` in `lib/selectors`
ClosedPublic
Actions

Authored by atul on Dec 1 2023, 2:15 AM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMMfbc0ea9c266f: [lib] Consume "new" `ThreadInfo` in `lib/selectors`

Summary

Replace instances of LegacyThreadInfo | MinimallyEncodedThreadInfo with ThreadInfo in lib/selectors. Initially defered this because I ran into some flow issues, but it turned out I made a simple typo/mistake.

Depends on D10124

Test Plan

CI/flow/etc.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Dec 1 2023, 2:15 AM

atul published this revision for review.Dec 1 2023, 2:21 AM

ashoat accepted this revision.Dec 1 2023, 2:27 AM

This revision is now accepted and ready to land.Dec 1 2023, 2:27 AM

Harbormaster completed remote builds in B24671: Diff 34085.Dec 1 2023, 2:34 AM

atul added a child revision: D10126: [lib] Replace `LegacyThreadInfo` with `ThreadInfo` where simple.Dec 1 2023, 3:02 AM

Closed by commit rCOMMfbc0ea9c266f: [lib] Consume "new" `ThreadInfo` in `lib/selectors`. · Explain WhyDec 1 2023, 8:44 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMfbc0ea9c266f: [lib] Consume "new" `ThreadInfo` in `lib/selectors`.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

chat-selectors.js

30 lines

nav-selectors.js

7 lines

thread-selectors.js

4 lines

Diff 34149

View Options

lib/selectors/chat-selectors.js

View Options

lib/selectors/nav-selectors.js

View Options

lib/selectors/thread-selectors.js

[lib] Consume "new" `ThreadInfo` in `lib/selectors`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 34149

lib/selectors/chat-selectors.js

lib/selectors/nav-selectors.js

lib/selectors/thread-selectors.js

[lib] Consume "new" `ThreadInfo` in `lib/selectors`
ClosedPublic
Actions

Revision Contents
Changeset List