Page MenuHomePhabricator
Differential D10125

[lib] Consume "new" `ThreadInfo` in `lib/selectors`
ClosedPublic
Actions

Authored by atul on Nov 30 2023, 6:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 28, 4:36 PM
Unknown Object (File)
Wed, Mar 19, 10:56 PM
Unknown Object (File)
Tue, Mar 4, 5:44 AM
Unknown Object (File)
Feb 27 2025, 7:23 PM
Unknown Object (File)
Feb 27 2025, 7:15 PM
Unknown Object (File)
Feb 27 2025, 7:15 PM
Unknown Object (File)
Feb 26 2025, 8:19 AM
Unknown Object (File)
Feb 15 2025, 12:57 AM
View All 70 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMMfbc0ea9c266f: [lib] Consume "new" `ThreadInfo` in `lib/selectors`
Summary

Replace instances of LegacyThreadInfo | MinimallyEncodedThreadInfo with ThreadInfo in lib/selectors. Initially defered this because I ran into some flow issues, but it turned out I made a simple typo/mistake.

Depends on D10124

Test Plan

CI/flow/etc.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
selectors/
30 lines
7 lines
4 lines

Diff 34149

View Options

lib/selectors/chat-selectors.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import type { LegacyThreadInfo } from 'lib/types/thread-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import RoleActionsMenu from './role-actions-menu.react.js'; import RoleActionsMenu from './role-actions-menu.react.js';
import css from './role-panel-entry.css'; import css from './role-panel-entry.css';
import CommIcon from '../CommIcon.react.js'; import CommIcon from '../CommIcon.react.js';
type RolePanelEntryProps = { type RolePanelEntryProps = {
+threadInfo: LegacyThreadInfo, +threadInfo: ThreadInfo,
+roleName: string, +roleName: string,
+memberCount: number, +memberCount: number,
}; };
function RolePanelEntry(props: RolePanelEntryProps): React.Node { function RolePanelEntry(props: RolePanelEntryProps): React.Node {
const { threadInfo, roleName, memberCount } = props; const { threadInfo, roleName, memberCount } = props;
return ( return (
<div className={css.rolePanelEntry}> <div className={css.rolePanelEntry}>
Show All 13 Lines
View Options

lib/selectors/nav-selectors.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import type { LegacyThreadInfo } from 'lib/types/thread-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import RoleActionsMenu from './role-actions-menu.react.js'; import RoleActionsMenu from './role-actions-menu.react.js';
import css from './role-panel-entry.css'; import css from './role-panel-entry.css';
import CommIcon from '../CommIcon.react.js'; import CommIcon from '../CommIcon.react.js';
type RolePanelEntryProps = { type RolePanelEntryProps = {
+threadInfo: LegacyThreadInfo, +threadInfo: ThreadInfo,
+roleName: string, +roleName: string,
+memberCount: number, +memberCount: number,
}; };
function RolePanelEntry(props: RolePanelEntryProps): React.Node { function RolePanelEntry(props: RolePanelEntryProps): React.Node {
const { threadInfo, roleName, memberCount } = props; const { threadInfo, roleName, memberCount } = props;
return ( return (
<div className={css.rolePanelEntry}> <div className={css.rolePanelEntry}>
Show All 13 Lines
View Options

lib/selectors/thread-selectors.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import type { LegacyThreadInfo } from 'lib/types/thread-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import RoleActionsMenu from './role-actions-menu.react.js'; import RoleActionsMenu from './role-actions-menu.react.js';
import css from './role-panel-entry.css'; import css from './role-panel-entry.css';
import CommIcon from '../CommIcon.react.js'; import CommIcon from '../CommIcon.react.js';
type RolePanelEntryProps = { type RolePanelEntryProps = {
+threadInfo: LegacyThreadInfo, +threadInfo: ThreadInfo,
+roleName: string, +roleName: string,
+memberCount: number, +memberCount: number,
}; };
function RolePanelEntry(props: RolePanelEntryProps): React.Node { function RolePanelEntry(props: RolePanelEntryProps): React.Node {
const { threadInfo, roleName, memberCount } = props; const { threadInfo, roleName, memberCount } = props;
return ( return (
<div className={css.rolePanelEntry}> <div className={css.rolePanelEntry}>
Show All 13 Lines