[lib] Update `useRoleUserSurfacedPermissions` to handle `MinimallyEncodedThreadInfo`
ClosedPublic
Actions

Authored by atul on Dec 1 2023, 8:45 AM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMM345bd8382ddf: [lib] Update `useRoleUserSurfacedPermissions` to handle…

Summary

Updated this permissions-related hook to handle MinimallyEncodedThreadInfo. This will allow subsequent removal of LegacyThreadInfo annotations, but will make those changes in separate diff.

Depends on D10137

Test Plan

CI/flow/etc

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Dec 1 2023, 8:45 AM

atul published this revision for review.Dec 1 2023, 8:45 AM

atul added a child revision: D10139: [native][web] Remove `LegacyThreadInfo` where possible after updating `useRoleUserSurfacedPermissions`.Dec 1 2023, 8:58 AM

Harbormaster failed remote builds in B24697: Diff 34129!Dec 1 2023, 9:11 AM

ashoat accepted this revision.Dec 1 2023, 9:16 AM

This revision is now accepted and ready to land.Dec 1 2023, 9:16 AM

Harbormaster completed remote builds in B24697: Diff 34129.Dec 1 2023, 9:29 AM

Closed by commit rCOMM345bd8382ddf: [lib] Update `useRoleUserSurfacedPermissions` to handle… (authored by atul). · Explain WhyDec 1 2023, 12:44 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM345bd8382ddf: [lib] Update `useRoleUserSurfacedPermissions` to handle….

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

9 lines

Diff 34155

View Options

lib/shared/thread-utils.js

	// @flow			// @flow

	import invariant from 'invariant';			import invariant from 'invariant';
	import * as React from 'react';			import * as React from 'react';

	import type { SetState } from 'lib/types/hook-types.js';			import type { SetState } from 'lib/types/hook-types.js';
	import type { MinimallyEncodedThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';			import type { ThreadInfo } from 'lib/types/thread-types.js';
	import type { LegacyThreadInfo } from 'lib/types/thread-types.js';

	import type { NativeChatMessageItem } from './message-data.react.js';			import type { NativeChatMessageItem } from './message-data.react.js';
	import type { ChatMessageItemWithHeight } from '../types/chat-types.js';			import type { ChatMessageItemWithHeight } from '../types/chat-types.js';

	export type MessagesMeasurer = (			export type MessagesMeasurer = (
	?$ReadOnlyArray<NativeChatMessageItem>,			?$ReadOnlyArray<NativeChatMessageItem>,
	?LegacyThreadInfo \| ?MinimallyEncodedThreadInfo,			?ThreadInfo,
	($ReadOnlyArray<ChatMessageItemWithHeight>) => mixed,			($ReadOnlyArray<ChatMessageItemWithHeight>) => mixed,
	) => void;			) => void;

	export type RegisteredMeasurer = {			export type RegisteredMeasurer = {
	+measure: MessagesMeasurer,			+measure: MessagesMeasurer,
	+unregister: () => void,			+unregister: () => void,
	};			};

	Show All 31 Lines

[lib] Update `useRoleUserSurfacedPermissions` to handle `MinimallyEncodedThreadInfo`ClosedPublicActions