Page MenuHomePhabricator
Differential D10254

[lib] Deprecate userSearchIndexForPotentialMembers and userStoreSearchIndex
ClosedPublic
Actions

Authored by rohan on Dec 8 2023, 5:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 7:36 PM
Unknown Object (File)
Wed, Dec 18, 7:36 PM
Unknown Object (File)
Wed, Dec 18, 7:36 PM
Unknown Object (File)
Wed, Dec 18, 7:36 PM
Unknown Object (File)
Wed, Dec 18, 7:36 PM
Unknown Object (File)
Mon, Dec 16, 3:29 PM
Unknown Object (File)
Nov 12 2024, 11:22 AM
Unknown Object (File)
Nov 5 2024, 10:55 PM
View All 61 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
ginsu
inka
Commits
rCOMM63fe093f1cab: [lib] Deprecate userSearchIndexForPotentialMembers and userStoreSearchIndex
Summary

Now that the remaining search experiences have been updated, we can safely deprecate both userSearchIndexForPotentialMembers and userStoreSearchIndex since there are no usages in the codebase.

Addresses ENG-5435

Depends on D10253

Test Plan

Ran flow and made sure everything on the app still works fine

Diff Detail

Repository
rCOMM Comm
Branch
ens
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rohan created this revision.Dec 8 2023, 5:41 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 8 2023, 5:41 AM
rohan added inline comments.Dec 8 2023, 5:42 AM
lib/selectors/user-selectors.js
150–158

Because userSearchIndexForPotentialMembers is removed, searchIndexFromUserInfos also can be removed at the same time

rohan published this revision for review.Dec 8 2023, 6:16 AM
Harbormaster failed remote builds in B24891: Diff 34421!Dec 8 2023, 6:48 AM
inka accepted this revision.Dec 11 2023, 7:42 AM
This revision is now accepted and ready to land.Dec 11 2023, 7:42 AM
inka mentioned this in D10231: [lib/web/native] Introduce hook that constructs a resolved user search index and update usePotentialMemberItems.Dec 12 2023, 1:11 AM
rohan updated this revision to Diff 34721.Dec 15 2023, 8:04 AM

CI

This revision was landed with ongoing or failed builds.Dec 15 2023, 8:33 AM
Closed by commit rCOMM63fe093f1cab: [lib] Deprecate userSearchIndexForPotentialMembers and userStoreSearchIndex (authored by rohan). · Explain Why
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMM63fe093f1cab: [lib] Deprecate userSearchIndexForPotentialMembers and userStoreSearchIndex.
Harbormaster completed remote builds in B25125: Diff 34721.Dec 15 2023, 8:58 AM

Revision Contents
Changeset List

PathSize
lib/
selectors/
29 lines

Diff 34421

View Options

lib/selectors/user-selectors.js

Loading...