[web] rename tabs to tabs legacy
ClosedPublic
Actions

Authored by ginsu on Jan 4 2024, 12:34 AM.

Details

Reviewers

atul
inka

Commits

rCOMM2e6586754590: [web] rename tabs to tabs legacy

Summary

Rename diff.

In order to house the thread list in the panel component, we need to refactor the tabs component. At this moment the tabs component is made of two parts: the tabs and the tab content. The tabs component utilizes the React.Children.* API to interact with those child components. The React.Children.* API is listed as Legacy React API in the react docs and additionally for the redesign I need to decouple the tabs from the tab content to put the tabs in the panel header and the tab content in the panel body.

In order to make this refactor easy to review, I broke this down into many steps. The first step is to rename this file and the imports to "tabs legacy" and then in a subsequent diff I will introduce a new tabs component which will utilize an alternate solution outlined in the react docs: https://react.dev/reference/react/Children#accepting-an-array-of-objects-as-a-prop

Afterwards I will update every tab use case to use the new tabs api

Depends on D10515

Test Plan

flow and ensured that all the tabs worked as expected

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 4 2024, 12:34 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 4 2024, 12:34 AM

ginsu edited the summary of this revision. (Show Details)Jan 4 2024, 12:44 AM

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D10515: [web] rename card color family to panel.

ginsu edited the summary of this revision. (Show Details)

ginsu added a child revision: D10516: [web] refactor tabs component.Jan 4 2024, 12:50 AM

Harbormaster completed remote builds in B25468: Diff 35182.Jan 4 2024, 12:51 AM

ginsu requested review of this revision.Jan 4 2024, 12:51 AM

ginsu added a child revision: D10518: [web] upate emoji avatar selection modal to use new tabs component.Jan 4 2024, 12:58 AM

ginsu removed a child revision: D10518: [web] upate emoji avatar selection modal to use new tabs component.Jan 4 2024, 1:15 AM

Seems reasonable

As an aside, would it make sense to also rename imports to be LegacyTabs? Doesn't really matter and will probably be removed altogether at the end of the stack anyways.

This revision is now accepted and ready to land.Jan 4 2024, 12:08 PM

As an aside, would it make sense to also rename imports to be LegacyTabs? Doesn't really matter and will probably be removed altogether at the end of the stack anyways.

I deprecate and replace everything at the end of this stack so didn't feel like it was necessary to do that

Closed by commit rCOMM2e6586754590: [web] rename tabs to tabs legacy (authored by ginsu). · Explain WhyJan 4 2024, 3:00 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM2e6586754590: [web] rename tabs to tabs legacy.