[web] upate emoji avatar selection modal to use new tabs component
ClosedPublic
Actions

Authored by ginsu on Jan 4 2024, 12:53 AM.

Details

Reviewers

atul
inka

Commits

rCOMM2cd2fecd2035: [web] upate emoji avatar selection modal to use new tabs component

Summary

This diff updates the emoji avatar selection modal to use the new tab components. Since we decoupled the tabs from the tab content with this new tab component, the emoji avatar selection modal now needs to be responsible for rendering the correct tab content.

Depends on D10516

Test Plan

Please see the demo video below to confirm that there are no regressions

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 4 2024, 12:53 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 4 2024, 12:53 AM

ginsu edited the summary of this revision. (Show Details)Jan 4 2024, 12:58 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D10517: [web] rename tabs to tabs legacy.

ginsu attached a referenced file: F1026063: Screen Recording 2024-01-04 at 3.55.53 AM.mov. (Show Details)

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 4 2024, 1:00 AM

Harbormaster failed remote builds in B25470: Diff 35184!

will make sure ci passes before landing

ginsu added a child revision: D10519: [web] update sidebars modal to use new tabs component.Jan 4 2024, 1:06 AM

ginsu edited the summary of this revision. (Show Details)Jan 4 2024, 1:14 AM

ginsu added a parent revision: D10516: [web] refactor tabs component.

ginsu removed a parent revision: D10517: [web] rename tabs to tabs legacy.

Seems reasonable, thanks for including the video in the Test Plan!

web/avatars/emoji-avatar-selection-modal.react.js
25–28 ↗	(On Diff #35184)	Would it make sense to use `"Emoji"` for both? Creating a whole separate object that only really contains one string seems like it might be overkill? Don't feel strongly though, def fine to land as is.

This revision is now accepted and ready to land.Jan 4 2024, 12:41 PM

ginsu added inline comments.Jan 4 2024, 1:25 PM

web/avatars/emoji-avatar-selection-modal.react.js
25–28 ↗	(On Diff #35184)	I made the `header` field a type of `React.Node`. I did this so that if we ever wanted to add other elements to the `header` component we could just pass in a react component as the value of this field. I could imagine us wanting to put icons in the future or doing other things and I thought this would be the best way to make the `tabs` component as flexible/future proof as possible