[web] update thread settings media gallery modal to use new tabs component
ClosedPublic
Actions

Authored by ginsu on Jan 4 2024, 1:08 AM.

Details

Reviewers

atul
inka

Commits

rCOMM70fbabf6f90b: [web] update thread settings media gallery modal to use new tabs component

Summary

This diff updates the thread settings media gallery modal to use the new tab components. Since we decoupled the tabs from the tab content with this new tab component, the thread settings media gallery modal now needs to be responsible for rendering the correct tab content.

Depends on D10519

Test Plan

Please see the demo video below to confirm that there are no regressions

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 4 2024, 1:08 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 4 2024, 1:08 AM

ginsu edited the summary of this revision. (Show Details)Jan 4 2024, 1:11 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D10519: [web] update sidebars modal to use new tabs component.

ginsu edited the summary of this revision. (Show Details)

ginsu added a child revision: D10521: [web] update members modal to use the new tabs component.Jan 4 2024, 1:16 AM

Harbormaster completed remote builds in B25472: Diff 35186.Jan 4 2024, 1:25 AM

ginsu requested review of this revision.Jan 4 2024, 1:25 AM

Looks good

web/modals/threads/gallery/thread-settings-media-gallery.react.js
196–202 ↗	(On Diff #35186)	(Realize it's out of scope of this diff and the rest of the diffs in the stack... but what do you think about sneaking in `React.useMemo`s just for the return values of these components while you're working with them?)