[web] deprecate and clean up unused tabs code
ClosedPublic
Actions

Authored by ginsu on Jan 4 2024, 1:41 AM.

Details

Reviewers

atul
inka

Commits

rCOMM2b719190a1c8: [web] deprecate and clean up unused tabs code

Summary

Now that all the use cases of the tabs component has been updated to use the new tabs component api, we can deprecate our legacy tabs component. Also in this diff took a moment to update the color variables for the tabs style to use the new color design system naming convention

Depends on D10523

Test Plan

flow + confirmed that the tabs had no visual regression

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 4 2024, 1:41 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 4 2024, 1:41 AM

ginsu edited the test plan for this revision. (Show Details)Jan 4 2024, 1:43 AM

ginsu added reviewers: atul, inka.

ginsu edited the summary of this revision. (Show Details)

ginsu added a parent revision: D10523: [web] update chat tabs to use the new tabs component.

ginsu edited the summary of this revision. (Show Details)

ginsu added inline comments.Jan 4 2024, 1:46 AM

web/components/tabs-header.js
22 ↗	(On Diff #35190)	The extra lines are intentional, I found that this component was really cramped and I thought it was easier to read if the different parts had room to breathe
26 ↗	(On Diff #35190)	Thought "in active" was a better variable name than "background" for describing in what situations these styles are used
web/components/tabs-pill.css
1–21 ↗	(On Diff #35190)	These styles were used in the `tabs-legacy` file