Page MenuHomePhabricator

[lib] Stop reducing data loaded, CSAT, theme and user info on set new session
ClosedPublic

Authored by inka on Jan 23 2024, 6:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 6:04 PM
Unknown Object (File)
Sat, Nov 23, 12:46 AM
Unknown Object (File)
Fri, Nov 22, 9:32 PM
Unknown Object (File)
Wed, Nov 13, 6:06 PM
Unknown Object (File)
Tue, Nov 12, 11:43 PM
Unknown Object (File)
Tue, Nov 12, 5:43 PM
Unknown Object (File)
Tue, Nov 12, 12:45 AM
Unknown Object (File)
Mon, Nov 11, 10:35 PM
Subscribers

Details

Summary

issue: ENG-5817

Test Plan

Dispatched the action, checked that dataLoaded and currentUserInfo got updated.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.Jan 23 2024, 6:49 AM
michal requested changes to this revision.Jan 30 2024, 8:02 AM
michal added inline comments.
lib/reducers/user-reducer.js
68–69 ↗(On Diff #36036)

If we enabled userStore sync before CSAT or at the same time this is fine, but if not we probably want to enable this only after that. There is also an issue about handling older clients trying to update user store in general. I've left a comment about this general issue here.

For this specific case it would probably be better to make sessionChange.currentUserInfo an optional field and change the keyserver so that it will only send it to older clients (and finally remove this code completely from the client codebase).

This revision now requires changes to proceed.Jan 30 2024, 8:02 AM

Address review - following the discussion in ENG-4730 we want to keep updating the currentUserInfo sent by Ashoat's keyserver

This revision is now accepted and ready to land.Jan 31 2024, 8:16 AM