issue: ENG-5824
enabled apps, CSAT, theme, backup enabled, crypto store, current user info - are all values that shouldn't be removed when user disconnects from a keyserver.
In some cases change also affects set new session action. This is fince, this data shouldn't also be removed when a keyserver sets a new session. The rest of set new session will be refactored in ENG-5767
Details
Details
Tested that those values still get removed if the user is not using CSAT (didn't test if CSAT is removed because we don't have it, but the code is pretty straightforward)
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
On Linear earlier today I proposed that we continue to use logOutActionTypes.success for whole-app logout (including keyserver and identity logout). If we take that approach, should we undo some of the changes here for logOutActionTypes.success?
| lib/reducers/enabled-apps-reducer.js | ||
|---|---|---|
| 33 ↗ | (On Diff #35774) | Same question as here |
| lib/reducers/services-access-token-reducer.js | ||
| 29–32 ↗ | (On Diff #35774) | Same question as here |
| lib/reducers/theme-reducer.js | ||
| 42–45 ↗ | (On Diff #35774) | Same question as here |
| lib/reducers/user-reducer.js | ||
| 65–71 ↗ | (On Diff #35774) | Same question as here |
| native/redux/redux-setup.js | ||
| 205–213 ↗ | (On Diff #35774) | Same question as here |
| web/redux/crypto-store-reducer.js | ||
| 21 ↗ | (On Diff #35774) | Same question as here |
Comment Actions
Requesting changes for some explanations so I can understand the diff better. Feel free to re-request.
| lib/reducers/user-reducer.js | ||
|---|---|---|
| 67 ↗ | (On Diff #36025) | Don't we also need to update these actions? |
| native/redux/redux-setup.js | ||
| 126–132 ↗ | (On Diff #36025) | Not related to this diff, but will this code, and the ... === keyserverAuthActionTypes.success && invalidSessionRecovery( ... code below, be removed after we completely migrate to identity service? |
| lib/reducers/user-reducer.js | ||
|---|---|---|
| 67 ↗ | (On Diff #36025) | This is done in D10795 |
| native/redux/redux-setup.js | ||
| 126–132 ↗ | (On Diff #36025) | No. The user may still disconnect from a keyserver and connect to it again before the action succeeds |