issue: ENG-5826
We want to only remove the keyservers that the user has disconnected from. The only exception is Ashoat's keyserver, which always needs to be in the store. Additionally to what we were removing from it before I removed lateResponses. lateResponses include message ids, so I'm not sure if it would be ba security breach to leave them. But it looks like this field is only used for the disconnected bar, which is not shown on the logout screen anyway, and soon will not be even connected to the keyserver connection, but to the internet connection (ENG-6137)
Details
Details
Ran the provided test
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
We are discussing in ENG-6424 if logout should be refactored, but delete account has to be refactored anyway
| lib/reducers/keyserver-reducer.js | ||
|---|---|---|
| 337–356 ↗ | (On Diff #35778) | I think we can reduce indentation here. Try inverting the first condition |
| lib/reducers/keyserver-reducer.js | ||
|---|---|---|
| 355 ↗ | (On Diff #35941) | I wonder if we should also add this lateResponses to the logOut/deleteAccount. |