issue: https://linear.app/comm/issue/ENG-6299/save-new-keyserver-on-set-new-session
I will need this value in yet another place so I think it makes sense to extrac it
Details
Details
Tested that add it's still possible to add a keyserver, and the entry looks like it did before
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
lib/types/keyserver-types.js | ||
---|---|---|
27 ↗ | (On Diff #35083) | This feels a bit hacky, setting it to a temporary, empty string. Maybe we could make it a function that takes urlPrefix as a parameter? |
lib/types/keyserver-types.js | ||
---|---|---|
27 ↗ | (On Diff #35083) | Not sure if this is the right solution, but if the intention is to skip the urlPrefix field, we can consider changing the type to Omit<KeyserverInfo, 'urlPrefix'>. |