Page MenuHomePhabricator

[lib][web][native] Create defaultKeyserverInfo
ClosedPublic

Authored by inka on Dec 29 2023, 5:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 16, 3:26 AM
Unknown Object (File)
Wed, Oct 16, 3:26 AM
Unknown Object (File)
Wed, Oct 16, 3:26 AM
Unknown Object (File)
Wed, Oct 16, 3:25 AM
Unknown Object (File)
Wed, Oct 16, 3:25 AM
Unknown Object (File)
Sep 21 2024, 11:34 AM
Unknown Object (File)
Sep 4 2024, 9:05 PM
Unknown Object (File)
Sep 4 2024, 9:05 PM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-6299/save-new-keyserver-on-set-new-session
I will need this value in yet another place so I think it makes sense to extrac it

Test Plan

Tested that add it's still possible to add a keyserver, and the entry looks like it did before

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.Dec 29 2023, 5:40 AM

seems reasonable, thanks for factoring that out!

This revision is now accepted and ready to land.Dec 29 2023, 12:31 PM
michal added inline comments.
lib/types/keyserver-types.js
27 ↗(On Diff #35083)

This feels a bit hacky, setting it to a temporary, empty string.

Maybe we could make it a function that takes urlPrefix as a parameter?

lib/types/keyserver-types.js
27 ↗(On Diff #35083)

Not sure if this is the right solution, but if the intention is to skip the urlPrefix field, we can consider changing the type to Omit<KeyserverInfo, 'urlPrefix'>.

Turn into a function, use in default states