Page MenuHomePhabricator
Differential D10635

[lib][web][native] Make it possible to remove a subset of drafts
ClosedPublic
Actions

Authored by inka on Jan 15 2024, 7:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 12:53 PM
Unknown Object (File)
Oct 14 2024, 6:10 PM
Unknown Object (File)
Oct 14 2024, 6:10 PM
Unknown Object (File)
Oct 14 2024, 6:10 PM
Unknown Object (File)
Oct 8 2024, 7:58 AM
Unknown Object (File)
Sep 11 2024, 1:21 PM
Unknown Object (File)
Sep 11 2024, 1:21 PM
Unknown Object (File)
Sep 11 2024, 1:21 PM
View All 36 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
marcin
Commits
rCOMM80179ace3906: [lib][web][native] Make it possible to remove a subset of drafts
Summary

issue: ENG-5812

Test Plan

Ran the provided test

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Jan 15 2024, 7:27 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 15 2024, 7:27 AM
inka edited the test plan for this revision. (Show Details)Jan 15 2024, 7:27 AM
inka added 1 blocking reviewer(s): kamil.
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 15 2024, 7:46 AM
Harbormaster failed remote builds in B25773: Diff 35635!
inka updated this revision to Diff 35637.Jan 15 2024, 9:00 AM

Fix error

inka added a parent revision: D10628: [lib] Refactor user reducer.Jan 15 2024, 9:00 AM
inka added a child revision: D10636: [lib] Refactor draft reducer.Jan 15 2024, 9:05 AM
Harbormaster completed remote builds in B25774: Diff 35637.Jan 15 2024, 9:20 AM
inka requested review of this revision.Jan 15 2024, 9:20 AM
kamil accepted this revision.Jan 17 2024, 1:38 AM
kamil added inline comments.
native/cpp/CommonCpp/NativeModules/DraftStoreOperations.h
69 ↗(On Diff #35637)

the convention is mixed across different files but let's keep it consistent at least in one file

web/database/queries/draft-queries.test.js
108–112 ↗(On Diff #35637)

I would also check if the remaining draft has key thread_b

This revision is now accepted and ready to land.Jan 17 2024, 1:38 AM
inka updated this revision to Diff 35730.Jan 17 2024, 8:49 AM

Rebase & address review

Harbormaster completed remote builds in B25841: Diff 35730.Jan 17 2024, 9:20 AM
inka updated this revision to Diff 36267.Jan 29 2024, 7:07 AM

Rebase

tomek added inline comments.Jan 29 2024, 7:14 AM
lib/types/draft-types.js
28 ↗(On Diff #36267)

It might be more performant and safer to allow deleting all the entries associated with a given keyserver, e.g.
`DELETE FROM drafts WHERE id LIKE 'threadID|%'. It's probably not worth fixing it now, but it might be a good idea to introduce this improvement later.

Harbormaster completed remote builds in B26256: Diff 36267.Jan 29 2024, 7:36 AM
inka added inline comments.Jan 29 2024, 8:35 AM
lib/types/draft-types.js
28 ↗(On Diff #36267)

I created a task to discuss this, because that could be done in all stores actually ENG-6603

Closed by commit rCOMM80179ace3906: [lib][web][native] Make it possible to remove a subset of drafts (authored by inka). · Explain WhyJan 29 2024, 8:41 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM80179ace3906: [lib][web][native] Make it possible to remove a subset of drafts.

Revision Contents
Changeset List

PathSize
lib/
types/
8 lines
native/
cpp/
CommonCpp/
DatabaseManagers/
1 line
1 line
6 lines
NativeModules/
19 lines
PersistentStorageUtilities/
DataStores/
1 line
4 lines
web/
cpp/
1 line
database/
_generated/
queries/
6 lines
types/
1 line
worker/
3 lines

Diff 36278

View Options

lib/types/draft-types.js

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/DraftStoreOperations.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/DraftStore.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/DraftStore.cpp

Loading...
View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...
View Options

web/database/_generated/comm_query_executor.wasm

Loading...
View Options

web/database/queries/draft-queries.test.js

Loading...
View Options

web/database/types/sqlite-query-executor.js

Loading...
View Options

web/database/worker/process-operations.js

Loading...