Page MenuHomePhabricator
Differential D10659

[lib] Refactor logout in invite links reducer
ClosedPublic
Actions

Authored by inka on Jan 17 2024, 6:04 AM.
Tags
None
Referenced Files
F3525639: D10659.id36285.diff
Mon, Dec 23, 5:55 PM
F3525638: D10659.id35942.diff
Mon, Dec 23, 5:55 PM
F3525637: D10659.id35779.diff
Mon, Dec 23, 5:55 PM
F3525636: D10659.id35721.diff
Mon, Dec 23, 5:55 PM
F3525620: D10659.id.diff
Mon, Dec 23, 5:55 PM
F3525613: D10659.diff
Mon, Dec 23, 5:55 PM
Unknown Object (File)
Mon, Dec 23, 4:07 AM
Unknown Object (File)
Mon, Dec 23, 12:59 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
kamil
ginsu
Commits
rCOMM242e78f9ba70: [lib] Refactor logout in invite links reducer
Summary

issue: ENG-5825
We want to remove the links related to the keyservers the user has disconnected from

Test Plan

Tested that when deleteKeyserverAccountActionTypes.success is dispatched, only links of the specified keyservers are removed.
Tested that if the user logs out from the app, the links store is cleared as it used to be

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Jan 17 2024, 6:04 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 17 2024, 6:04 AM
inka added a comment.Jan 17 2024, 6:04 AM

We are discussing in ENG-6424 if logout should be refactored, but delete account has to be refactored anyway

inka added a parent revision: D10658: [lib] Refactor logout in keyserver reducer.Jan 17 2024, 6:04 AM
Harbormaster completed remote builds in B25832: Diff 35721.Jan 17 2024, 6:32 AM
inka requested review of this revision.Jan 17 2024, 6:32 AM
inka added a child revision: D10661: [lib] Refactor logout in thread activity reducer.Jan 17 2024, 6:57 AM
inka planned changes to this revision.Jan 17 2024, 8:15 AM

We decided to have a single action for logging out of keyservers and identity.

inka updated this revision to Diff 35779.Jan 18 2024, 2:50 AM

Undo changes to logout

Harbormaster completed remote builds in B25884: Diff 35779.Jan 18 2024, 3:12 AM
inka updated this revision to Diff 35942.Jan 22 2024, 4:02 AM

Merge identity delete account with keyserver delete account

Harbormaster completed remote builds in B26009: Diff 35942.Jan 22 2024, 4:29 AM
michal accepted this revision.Jan 29 2024, 6:25 AM
This revision is now accepted and ready to land.Jan 29 2024, 6:25 AM
Closed by commit rCOMM242e78f9ba70: [lib] Refactor logout in invite links reducer (authored by inka). · Explain WhyJan 29 2024, 8:42 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM242e78f9ba70: [lib] Refactor logout in invite links reducer.

Revision Contents
Changeset List

PathSize
lib/
reducers/
16 lines

Diff 36285

View Options

lib/reducers/invite-links-reducer.js

Loading...