issue: ENG-5988
We want to remove all ids of threads that belong to the keyserver the user is logging out of.
IT'S VERY IMPORTANT THAT THE CURRENT BEHAVIOUR STAYS AS IS FOR USERS NOT USING CSAT. It will be the case for all diffs in this stack. Logout / delete account actions will not be replaced like login was, so we are using the same action types and hiding the old logic behind the flag.
Details
Details
Tested that if the user logs out and usingCommServicesAccessToken === true then threads that belong to the keyserver the user is logging out of are deleted. Tested that if usingCommServicesAccessToken === false, then filters are set to default values
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/reducers/calendar-filters-reducer.js | ||
|---|---|---|
| 67 ↗ | (On Diff #35650) | I proposed on Linear earlier that we continue using logOutActionTypes for global app-wide logout (including identity logout and keyserver logout). If we do that, should we keep the old logic for logOutActionTypes.success, even if usingCommServicesAccessToken? |
| lib/reducers/calendar-query-reducer.js | ||
| 28 ↗ | (On Diff #35650) | Same question here |
Comment Actions
Updated according to this discussion - we want to have a singe action for deleting identity account and keyserver accounts, and an action for deleting just a keyserver account (for when the user disconnects from a keyserver)