Page MenuHomePhabricator

[lib] Refactor logout in reduceEntryInfos
ClosedPublic

Authored by inka on Jan 16 2024, 6:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 16, 1:56 AM
Unknown Object (File)
Wed, Oct 16, 1:56 AM
Unknown Object (File)
Wed, Oct 16, 1:56 AM
Unknown Object (File)
Wed, Oct 16, 1:56 AM
Unknown Object (File)
Wed, Oct 16, 1:56 AM
Unknown Object (File)
Wed, Oct 16, 1:56 AM
Unknown Object (File)
Oct 5 2024, 2:20 PM
Unknown Object (File)
Oct 2 2024, 3:27 PM
Subscribers

Details

Summary

issue: ENG-5766
We don't want to remove lastUserInteractionCalendar for users using CSAT.
The rest of the reducer is already correct, because it checks new threads aand based on that removes entries. So if thread reducer removes threads related to the keyserver, the entires will be removed as well

Test Plan

Tested that if a user is connected to another keyserver and logs out of it, the corresponding entires are indeed removed. Tested that for a user not using CSAT, lastUserInteractionCalendar is still reset to 0

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.Jan 16 2024, 6:19 AM

As mentioned in other diffs, not sure if we need to chnage anything for logOutActionTypes.success

inka planned changes to this revision.EditedJan 17 2024, 8:16 AM

We decided to have a single action for identity and ks logout

lib/reducers/entry-reducer.js
184–185 ↗(On Diff #35776)

Same question as here

Merge identity delete account with keyserver delete account

This revision is now accepted and ready to land.Jan 25 2024, 6:25 AM
This revision was automatically updated to reflect the committed changes.