Page MenuHomePhabricator
Differential D10652

[lib] Fix currentAsOf
ClosedPublic
Actions

Authored by inka on Jan 16 2024, 6:50 AM.
Tags
None
Referenced Files
F2135439: D10652.id35668.diff
Fri, Jun 28, 11:22 AM
F2132264: D10652.id.diff
Thu, Jun 27, 10:04 PM
Unknown Object (File)
Wed, Jun 26, 10:03 PM
Unknown Object (File)
Wed, Jun 26, 4:37 PM
Unknown Object (File)
Wed, Jun 26, 11:51 AM
Unknown Object (File)
Wed, Jun 19, 5:55 AM
Unknown Object (File)
Sat, Jun 15, 1:29 PM
Unknown Object (File)
Fri, Jun 14, 11:40 PM
View All 33 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
kamil
ginsu
ashoat
Commits
rCOMMe5200cc68cad: [lib] Fix currentAsOf
Summary

If the keyserver was not present in the message store previously, processedMessageStore.currentAsOf[keyserverID] will be undefined. And max from number and undefined is NaN

Test Plan

Tested that now when a user logs in to a new keyserver and some messages are sent from it, the value is not NaN

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Jan 16 2024, 6:50 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 16 2024, 6:50 AM
inka added a parent revision: D10650: [lib] Refactor logout in reduceEntryInfos.Jan 16 2024, 6:50 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 16 2024, 6:59 AM
Harbormaster failed remote builds in B25799: Diff 35668!
inka added a child revision: D10653: lib] Refactor message reducer.Jan 16 2024, 7:43 AM
Harbormaster completed remote builds in B25799: Diff 35668.Jan 16 2024, 7:51 AM
inka requested review of this revision.Jan 16 2024, 7:51 AM
ashoat accepted this revision.Jan 16 2024, 6:58 PM
This revision is now accepted and ready to land.Jan 16 2024, 6:58 PM
inka removed a child revision: D10653: lib] Refactor message reducer.Jan 17 2024, 1:05 AM
inka added a child revision: D10653: lib] Refactor message reducer.
inka removed a parent revision: D10650: [lib] Refactor logout in reduceEntryInfos.
Closed by commit rCOMMe5200cc68cad: [lib] Fix currentAsOf (authored by inka). · Explain WhyJan 17 2024, 1:07 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMe5200cc68cad: [lib] Fix currentAsOf.

Revision Contents
Changeset List

PathSize
lib/
reducers/
2 lines

Diff 35702

View Options

lib/reducers/message-reducer.js

Loading...