[lib][web][native] Make possible to log out of one keyserver / delete account on one keyserver
ClosedPublic
Actions

Authored by inka on Jan 11 2024, 7:37 AM.

Details

Reviewers

michal
kamil
ginsu

Commits

rCOMM96e3f6f2133d: [lib][web][native] Make possible to log out of one keyserver / delete account…

Summary

issue: ENG-5766
We want to be able to log out / delete account on a subset of keyservers
I'm also moving fetching preRequestUserState into useDeleteKeyserverAccount, to make the code clearer.

Test Plan

Tested that it is still possible to delete account and logout on both platforms

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Jan 11 2024, 7:37 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 11 2024, 7:37 AM

Harbormaster completed remote builds in B25697: Diff 35533.Jan 11 2024, 8:00 AM

inka requested review of this revision.Jan 11 2024, 8:00 AM

michal accepted this revision.Jan 12 2024, 5:50 AM

michal added inline comments.

lib/actions/user-actions.js
74–77 ↗	(On Diff #35533)	Can this be readonly?
lib/types/account-types.js
37–40 ↗	(On Diff #35533)	I think you need to wrap it in `$ReadOnly<>` as flow loses readonly on fields when you spread another object.