Page MenuHomePhabricator
Differential D10603

[lib][web][native] Make possible to log out of one keyserver / delete account on one keyserver
ClosedPublic
Actions

Authored by inka on Jan 11 2024, 7:37 AM.
Tags
None
Referenced Files
F2137973: D10603.diff
Fri, Jun 28, 8:11 PM
Unknown Object (File)
Thu, Jun 27, 3:43 PM
Unknown Object (File)
Thu, Jun 27, 1:10 PM
Unknown Object (File)
Wed, Jun 26, 12:04 PM
Unknown Object (File)
Tue, Jun 25, 10:31 PM
Unknown Object (File)
Fri, Jun 14, 4:43 PM
Unknown Object (File)
Fri, Jun 14, 6:51 AM
Unknown Object (File)
Thu, Jun 13, 6:48 AM
View All 37 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
kamil
ginsu
Commits
rCOMM96e3f6f2133d: [lib][web][native] Make possible to log out of one keyserver / delete account…
Summary

issue: ENG-5766
We want to be able to log out / delete account on a subset of keyservers
I'm also moving fetching preRequestUserState into useDeleteKeyserverAccount, to make the code clearer.

Test Plan

Tested that it is still possible to delete account and logout on both platforms

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Jan 11 2024, 7:37 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 11 2024, 7:37 AM
Harbormaster completed remote builds in B25697: Diff 35533.Jan 11 2024, 8:00 AM
inka requested review of this revision.Jan 11 2024, 8:00 AM
michal accepted this revision.Jan 12 2024, 5:50 AM
michal added inline comments.
lib/actions/user-actions.js
74–77 ↗(On Diff #35533)

Can this be readonly?

lib/types/account-types.js
37–40 ↗(On Diff #35533)

I think you need to wrap it in $ReadOnly<> as flow loses readonly on fields when you spread another object.

This revision is now accepted and ready to land.Jan 12 2024, 5:50 AM
inka added a child revision: D10619: [lib] Refactor report store reducer.Jan 12 2024, 7:30 AM
inka updated this revision to Diff 35602.Jan 15 2024, 1:42 AM

Make read-only

inka added a parent revision: D10484: [lib][web][native] Create defaultKeyserverInfo.Jan 15 2024, 1:43 AM
Harbormaster failed remote builds in B25751: Diff 35602!Jan 15 2024, 1:54 AM
inka updated this revision to Diff 35649.Jan 16 2024, 12:42 AM

Rebase before landing

Harbormaster failed remote builds in B25786: Diff 35649!Jan 16 2024, 12:52 AM
Harbormaster completed remote builds in B25786: Diff 35649.Jan 16 2024, 1:26 AM
Closed by commit rCOMM96e3f6f2133d: [lib][web][native] Make possible to log out of one keyserver / delete account… (authored by inka). · Explain WhyJan 16 2024, 1:52 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM96e3f6f2133d: [lib][web][native] Make possible to log out of one keyserver / delete account….

Revision Contents
Changeset List

PathSize
lib/
actions/
51 lines
types/
5 lines
5 lines
native/
14 lines
profile/
6 lines
4 lines
web/
settings/
6 lines

Diff 35655

View Options

lib/actions/user-actions.js

Loading...
View Options

lib/types/account-types.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

native/crash.react.js

Loading...
View Options

native/profile/delete-account.react.js

Loading...
View Options

native/profile/profile-screen.react.js

Loading...
View Options

web/settings/account-delete-modal.react.js

Loading...