Page MenuHomePhabricator
Differential D10661

[lib] Refactor logout in thread activity reducer
ClosedPublic
Actions

Authored by inka on Jan 17 2024, 6:57 AM.
Tags
None
Referenced Files
F3525643: D10661.id36286.diff
Mon, Dec 23, 5:55 PM
F3525642: D10661.id35943.diff
Mon, Dec 23, 5:55 PM
F3525641: D10661.id35780.diff
Mon, Dec 23, 5:55 PM
F3525640: D10661.id35723.diff
Mon, Dec 23, 5:55 PM
F3525621: D10661.id.diff
Mon, Dec 23, 5:55 PM
F3525612: D10661.diff
Mon, Dec 23, 5:55 PM
Unknown Object (File)
Fri, Nov 29, 6:09 PM
Unknown Object (File)
Wed, Nov 27, 7:31 AM
View All 83 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
kamil
ginsu
Commits
rCOMM5b7df280c482: [lib] Refactor logout in thread activity reducer
Summary

issue: ENG-5827
We want to remove only the threads related to the keyservers the user is disconnecting from

Test Plan

Ran the provided test

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Jan 17 2024, 6:57 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 17 2024, 6:57 AM
inka added a parent revision: D10659: [lib] Refactor logout in invite links reducer.Jan 17 2024, 6:57 AM

We are discussing in ENG-6424 if logout should be refactored, but delete account has to be refactored anyway

Harbormaster completed remote builds in B25834: Diff 35723.Jan 17 2024, 7:15 AM
inka requested review of this revision.Jan 17 2024, 7:15 AM
inka planned changes to this revision.Jan 17 2024, 8:14 AM

We decided to have a single action for logging out of keyservers and identity.

inka updated this revision to Diff 35780.Jan 18 2024, 2:52 AM

Undo changes to logout

Harbormaster completed remote builds in B25885: Diff 35780.Jan 18 2024, 3:10 AM
inka updated this revision to Diff 35943.Jan 22 2024, 4:06 AM

Merge identity delete account with keyserver delete account

Harbormaster completed remote builds in B26010: Diff 35943.Jan 22 2024, 4:35 AM
michal accepted this revision.Jan 29 2024, 7:23 AM
This revision is now accepted and ready to land.Jan 29 2024, 7:23 AM
inka added a child revision: D10778: [web] Handle invalid session downgrade for identity delete account.Jan 29 2024, 7:53 AM
Closed by commit rCOMM5b7df280c482: [lib] Refactor logout in thread activity reducer (authored by inka). · Explain WhyJan 29 2024, 8:42 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM5b7df280c482: [lib] Refactor logout in thread activity reducer.

Revision Contents
Changeset List

Diff 36286

View Options

lib/reducers/thread-activity-reducer.js

Loading...
View Options

lib/reducers/thread-activity-reducer.test.js

Loading...